Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Require correct gogo import paths #14852

Merged
merged 1 commit into from
Jan 31, 2023
Merged

docs: Require correct gogo import paths #14852

merged 1 commit into from
Jan 31, 2023

Conversation

amaury1093
Copy link
Contributor

Description

ref: #14851 (comment)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 requested a review from a team as a code owner January 31, 2023 12:07
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jan 31, 2023
@amaury1093 amaury1093 merged commit 6a441f3 into main Jan 31, 2023
@amaury1093 amaury1093 deleted the am/gogo-upgrading branch January 31, 2023 13:04
@mergify mergify bot mentioned this pull request Jan 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2023
@amaury1093 @mergify
docs: Require correct gogo import paths (#14852)
16121d6 
(cherry picked from commit 6a441f3)

# Conflicts:
#	UPGRADING.md
julienrbrt added a commit that referenced this pull request Jan 31, 2023
@mergify @amaury1093 @julienrbrt
docs: Require correct gogo import paths (backport #14852) (#14853)
5f4ddc6 
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt mentioned this pull request Jan 31, 2023
Merged
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@amaury1093 @tsenart
docs: Require correct gogo import paths (cosmos#14852)
495b42c
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amaury1093 @julienrbrt