docs: Require correct gogo import paths (backport #14852) #14853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 6a441f3) # Conflicts: # UPGRADING.md
|
Preparing the changelog and the release notes here too. |
julienrbrt
reviewed
Jan 31, 2023
| @@ -80,6 +80,16 @@ Please use the `ghcr.io/cosmos/proto-builder` image (version >= `0.11.5`) for ge | |||
|
|
|||
| See which buf commit for `cosmos/cosmos-sdk` to pin in your `buf.yaml` file [here](./proto/README.md). | |||
|
|
|||
| #### Gogoproto Import Paths | |||
There was a problem hiding this comment.
TODO: to put at the correct place in main, when adding v047 changelog to main.
julienrbrt
approved these changes
Jan 31, 2023
julienrbrt
reviewed
Jan 31, 2023
| @@ -8,7 +8,7 @@ require ( | |||
| cosmossdk.io/depinject v1.0.0-alpha.3 | |||
| cosmossdk.io/math v1.0.0-beta.4 | |||
| cosmossdk.io/tools/rosetta v0.2.0 | |||
| github.com/cosmos/cosmos-sdk v0.47.0-alpha2 | |||
| github.com/cosmos/cosmos-sdk v0.47.0-rc2 | |||
There was a problem hiding this comment.
Changing this so it shows the correct version when going to http://127.0.0.1:1317/cosmos/base/tendermint/v1beta1/node_info from simapp built in the v0.47 branch.
It has no other effect, as we use a replace directive.
|
Tagging a rc2 after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #14852 done by Mergify.
Cherry-pick of 6a441f3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com