Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(evidence): move ValidateBasic logic to msgServer #15753

Merged
merged 5 commits into from
Apr 8, 2023
Merged

refactor(evidence): move ValidateBasic logic to msgServer #15753

merged 5 commits into from
Apr 8, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15648

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner April 7, 2023 21:58
julienrbrt
julienrbrt commented Apr 7, 2023
View reviewed changes
x/evidence/types/msgs.go
@@ -63,10 +44,15 @@ func (m MsgSubmitEvidence) GetSigners() []sdk.AccAddress {
}

func (m MsgSubmitEvidence) GetEvidence() exported.Evidence {
if m.Evidence == nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests via message server catched that.

@julienrbrt julienrbrt mentioned this pull request Apr 7, 2023
Closed
19 tasks
alexanderbez
alexanderbez approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited by tac0turtle
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 8, 2023
@mergify mergify bot merged commit d09068f into main Apr 8, 2023
@mergify mergify bot deleted the julien/validate-evidence branch April 8, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/evidence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @alexanderbez @tac0turtle