Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic]: ValidateBasic #15648

Closed
19 tasks done
tac0turtle opened this issue Mar 31, 2023 · 5 comments · Fixed by #15785
Closed
19 tasks done

[Epic]: ValidateBasic #15648

tac0turtle opened this issue Mar 31, 2023 · 5 comments · Fixed by #15785
Assignees
@julienrbrt @atheeshp @likhita-809
Labels
T: Client UX T: Dev UX UX for SDK developers (i.e. how to call our code) T:Epic Epics

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Mar 31, 2023 •
edited by julienrbrt
Loading

Summary

in rfc 001 we accepted the optionality of validatebasic. Within the cosmos sdk we will remove the usage of validate basic in favour of having all validation happen on msg server. We will still support an extension interface for those that would like to continue using validate basic.

Work Breakdown
@tac0turtle tac0turtle added T: Dev UX UX for SDK developers (i.e. how to call our code) T: Client UX T:Epic Epics Q2:2023 labels Mar 31, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Apr 5, 2023
@vishal-kanna
Copy link
Contributor

@tac0turtle Is it changing the sdk.Msg interface( i.e deleting the validate basic from it) and adding the validate basic function in the msg server?

@tac0turtle
Copy link
Member Author

Validate basic would move to the message server. No need for another validate basic function. It can be within the message function.

@vishal-kanna
Copy link
Contributor

vishal-kanna commented Apr 7, 2023 •
edited
Loading

@tac0turtle I didn't get you
Is it using the validatebasic in msgserver
Correct me if i'm wrong and give some more info regrading it.

@tac0turtle
Copy link
Member Author

the checking in validate basic will get moved to the message server.

This was referenced Apr 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
mergify bot pushed a commit that referenced this issue Apr 8, 2023
@julienrbrt
refactor(evidence): move ValidateBasic logic to msgServer (#15753)
d09068f 
## Description

ref: #15648

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
@julienrbrt julienrbrt self-assigned this Apr 8, 2023
This was referenced Apr 8, 2023
Merged
Merged
Merged
@tac0turtle tac0turtle moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Apr 11, 2023
@atheeshp atheeshp mentioned this issue Apr 11, 2023
Merged
19 tasks
This was referenced Apr 11, 2023
Merged
Merged
Merged
@julienrbrt
Copy link
Member

julienrbrt commented Apr 12, 2023 •
edited
Loading

Posting this here as a reminder to look at a way to improve the UX of the submit-proposal gov and group CLI: #15782 (comment)
EDIT: #15809

@julienrbrt julienrbrt assigned julienrbrt and unassigned julienrbrt Apr 12, 2023
@likhita-809 likhita-809 mentioned this issue Apr 12, 2023
Merged
19 tasks
@atheeshp atheeshp mentioned this issue Apr 13, 2023
Merged
19 tasks
@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Apr 18, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
This was referenced Sep 29, 2023
Merged
Closed
@hacheigriega hacheigriega mentioned this issue Nov 30, 2023
Merged
7 tasks
@jonfung-dydx jonfung-dydx mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@atheeshp atheeshp

@likhita-809 likhita-809

Labels
T: Client UX T: Dev UX UX for SDK developers (i.e. how to call our code) T:Epic Epics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(group): move ValidateBasic logic to msgServer cosmos/cosmos-sdk
5 participants
@tac0turtle @julienrbrt @atheeshp @vishal-kanna @likhita-809