refactor(staking): use validator & address codecs in staking #16958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/staking
C:x/distribution
tac0turtle
changed the title
tac0turtle
commented
Jul 13, 2023
x/staking/types/exported.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
|
|
|||
| // DelegationI delegation bond for a delegated proof of stake system | |||
| type DelegationI interface { | |||
| GetDelegatorAddr() sdk.AccAddress // delegator sdk.AccAddress for the bond | |||
| GetDelegatorAddr() string // delegator string for the bond | |||
| GetValidatorAddr() sdk.ValAddress // validator operator address | |||
There was a problem hiding this comment.
i can migrate this one once we merge #16959, that way this interface is consistent
There was a problem hiding this comment.
@tac0turtle why not use bytes?
There was a problem hiding this comment.
would need to do a state migration, this bled into state, we will get rid of it in the next release or the upcoming rewrite of staking
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tac0turtle
changed the title
tac0turtle
changed the title
julienrbrt
added
the
backport/v0.50.x
19 tasks
julienrbrt
reviewed
Jul 17, 2023
github-prbot
requested review from
a team,
julienrbrt and
likhita-809
and removed request for
a team
tac0turtle
force-pushed
the
marko/delegatorAddress_string
branch
from
2aed262 to
99aac9a
Compare
alexanderbez
approved these changes
Jul 18, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit c23505b) # Conflicts: # CHANGELOG.md # tests/integration/distribution/keeper/msg_server_test.go # tests/integration/staking/keeper/validator_bench_test.go # x/distribution/keeper/delegation.go # x/distribution/simulation/operations_test.go # x/slashing/simulation/operations_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr changes the Delegation interface from sdk.Accaddress to string and assumes the caller will change it to the needed format
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change