Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: CLI use --from consistently #1748

Merged
merged 3 commits into from
Jul 19, 2018
Merged

R4R: CLI use --from consistently #1748

merged 3 commits into from
Jul 19, 2018

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jul 19, 2018 •
edited
Loading

closes #1606

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • n/a Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 19, 2018 •
edited
Loading

Codecov Report

Merging #1748 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1748   +/-   ##
=======================================
  Coverage     64.2%   64.2%           
=======================================
  Files          115     115           
  Lines         6834    6834           
=======================================
  Hits          4388    4388           
  Misses        2192    2192           
  Partials       254     254

@rigelrozanski rigelrozanski changed the title WIP: CLI use --from consistently R4R: CLI use --from consistently Jul 19, 2018
@rigelrozanski rigelrozanski mentioned this pull request Jul 19, 2018
Closed
4 tasks
@rigelrozanski rigelrozanski added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Jul 19, 2018
ValarDragon
ValarDragon approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this rigel!

cwgoes
cwgoes approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit d2f70ec into develop Jul 19, 2018
@cwgoes cwgoes deleted the rigel/all-cmds-use---from branch July 19, 2018 06:53
@rigelrozanski rigelrozanski mentioned this pull request Jul 23, 2018
Closed
@jackzampolin
Copy link
Member

This is awesome @rigelrozanski !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@jbibla jbibla Awaiting requested review from jbibla

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
C:CLI T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: make all commands use --from
4 participants
@rigelrozanski @jackzampolin @ValarDragon @cwgoes