Release/v0.24.0

.circleci/config.yml

@@ -62,7 +62,7 @@ jobs:
           name: Get metalinter
           command: |
             export PATH="$GOBIN:$PATH"
-            make get_tools
+            make get_dev_tools
       - run:
           name: Lint source
           command: |
@@ -85,6 +85,54 @@ jobs:
             export PATH="$GOBIN:$PATH"
             make test_cli
 
+  test_sim_modules:
+    <<: *defaults
+    parallelism: 1
+    steps:
+      - attach_workspace:
+          at: /tmp/workspace
+      - restore_cache:
+          key: v1-pkg-cache
+      - restore_cache:
+          key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Test individual module simulations
+          command: |
+            export PATH="$GOBIN:$PATH"
+            make test_sim_modules
+
+  test_sim_gaia_nondeterminism:
+    <<: *defaults
+    parallelism: 1
+    steps:
+      - attach_workspace:
+          at: /tmp/workspace
+      - restore_cache:
+          key: v1-pkg-cache
+      - restore_cache:
+          key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Test individual module simulations
+          command: |
+            export PATH="$GOBIN:$PATH"
+            make test_sim_gaia_nondeterminism
+
+  test_sim_gaia_fast:
+    <<: *defaults
+    parallelism: 1
+    steps:
+      - attach_workspace:
+          at: /tmp/workspace
+      - restore_cache:
+          key: v1-pkg-cache
+      - restore_cache:
+          key: v1-tree-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Test full Gaia simulation
+          command: |
+            export PATH="$GOBIN:$PATH"
+            make test_sim_gaia_fast
+
   test_cover:
     <<: *defaults
     parallelism: 4
@@ -101,9 +149,9 @@ jobs:
           command: |
             export PATH="$GOBIN:$PATH"
             make install
-            for pkg in $(go list github.com/cosmos/cosmos-sdk/... | grep -v /vendor/ | grep -v github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test | circleci tests split --split-by=timings); do
+            for pkg in $(go list github.com/cosmos/cosmos-sdk/... | grep -v github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test | grep -v '/simulation' | circleci tests split --split-by=timings); do
               id=$(basename "$pkg")
-              GOCACHE=off go test -v -timeout 8m -race -coverprofile=/tmp/workspace/profiles/$id.out -covermode=atomic "$pkg" | tee "/tmp/logs/$id-$RANDOM.log"
+              GOCACHE=off go test -timeout 8m -race -coverprofile=/tmp/workspace/profiles/$id.out -covermode=atomic "$pkg" | tee "/tmp/logs/$id-$RANDOM.log"
             done
       - persist_to_workspace:
           root: /tmp/workspace
@@ -133,6 +181,29 @@ jobs:
           name: upload
           command: bash <(curl -s https://codecov.io/bash) -f coverage.txt
 
+  localnet:
+      working_directory: /home/circleci/.go_workspace/src/github.com/cosmos/cosmos-sdk
+      machine:
+        image: circleci/classic:latest
+      environment:
+        GOBIN: /home/circleci/.go_workspace/bin
+        GOPATH: /home/circleci/.go_workspace/
+        GOOS: linux
+        GOARCH: amd64
+      parallelism: 1
+      steps:
+        - checkout
+        - run:
+            name: run localnet and exit on failure
+            command: |
+              set -x
+              make get_tools
+              make get_vendor_deps
+              make build-linux
+              make localnet-start
+              ./scripts/localnet-blocks-test.sh 40 5 10 localhost
+
+
 workflows:
   version: 2
   test-suite:
@@ -144,9 +215,21 @@ workflows:
       - test_cli:
           requires:
             - setup_dependencies
+      - test_sim_modules:
+          requires:
+            - setup_dependencies
+      - test_sim_gaia_nondeterminism:
+          requires:
+            - setup_dependencies
+      - test_sim_gaia_fast:
+          requires:
+            - setup_dependencies
       - test_cover:
           requires:
             - setup_dependencies
+      - localnet:
+          requires:
+            - setup_dependencies
       - upload_coverage:
           requires:
             - test_cover

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,16 +1,17 @@
-<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ 
+<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
 v                               ✰  Thanks for creating a PR! ✰    
-v    Before smashing the submit button please review the checkboxes. 
+v    Before smashing the submit button please review the checkboxes.
 v    If a checkbox is n/a - please still include it but + a little note why
-☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  --> 
+☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->
 
-* [ ] Updated all relevant documentation (`docs/`)
-* [ ] Updated all relevant code comments
-* [ ] Wrote tests
-* [ ] Updated `CHANGELOG.md`
-* [ ] Updated `cmd/gaia` and `examples/`
+- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
+- [ ] Updated all relevant documentation (`docs/`)
+- [ ] Updated all relevant code comments
+- [ ] Wrote tests
+- [ ] Added entries in `PENDING.md` that include links to the relevant issue or PR that most accurately describes the change.
+- [ ] Updated `cmd/gaia` and `examples/`
 ___________________________________
 For Admin Use:
-* [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)
-* [ ] Reviewers Assigned 
-* [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
+- [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)
+- [ ] Reviewers Assigned
+- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))

CHANGELOG.md

@@ -1,5 +1,119 @@
 # Changelog
 
+## 0.24.0
+
+*August 13th, 2018*
+
+BREAKING CHANGES
+
+* Gaia REST API (`gaiacli advanced rest-server`)
+  - [x/stake] \#1880 More REST-ful endpoints (large refactor)
+  - [x/slashing] \#1866 `/slashing/signing_info` takes cosmosvalpub instead of cosmosvaladdr
+  - use time.Time instead of int64 for time. See Tendermint v0.23.0
+  - Signatures are no longer Amino encoded with prefixes (just encoded as raw
+    bytes) - see Tendermint v0.23.0
+
+* Gaia CLI  (`gaiacli`)
+  -  [x/stake] change `--keybase-sig` to `--identity`
+  -  [x/stake] \#1828 Force user to specify amount on create-validator command by removing default
+  -  [x/gov] Change `--proposalID` to `--proposal-id`
+  -  [x/stake, x/gov] \#1606 Use `--from` instead of adhoc flags like `--address-validator`
+        and `--proposer` to indicate the sender address.
+  -  \#1551 Remove `--name` completely
+  -  Genesis/key creation (`gaiad init`) now supports user-provided key passwords
+
+* Gaia
+  - [x/stake] Inflation doesn't use rationals in calculation (performance boost)
+  - [x/stake] Persist a map from `addr->pubkey` in the state since BeginBlock
+    doesn't provide pubkeys.
+  - [x/gov] \#1781 Added tags sub-package, changed tags to use dash-case
+  - [x/gov] \#1688 Governance parameters are now stored in globalparams store
+  - [x/gov] \#1859 Slash validators who do not vote on a proposal
+  - [x/gov] \#1914 added TallyResult type that gets stored in Proposal after tallying is finished
+
+* SDK
+  - [baseapp] Msgs are no longer run on CheckTx, removed `ctx.IsCheckTx()`
+  - [baseapp] NewBaseApp constructor takes sdk.TxDecoder as argument instead of wire.Codec
+  - [types] sdk.NewCoin takes sdk.Int, sdk.NewInt64Coin takes int64
+  - [x/auth] Default TxDecoder can be found in `x/auth` rather than baseapp
+  - [client] \#1551: Refactored `CoreContext` to `TxContext` and `QueryContext`
+      - Removed all tx related fields and logic (building & signing) to separate
+        structure `TxContext` in `x/auth/client/context`
+
+* Tendermint
+    - v0.22.5 -> See [Tendermint PR](https://github.com/tendermint/tendermint/pull/1966)
+        - change all the cryptography imports.
+    - v0.23.0 -> See
+      [Changelog](https://github.com/tendermint/tendermint/blob/v0.23.0/CHANGELOG.md#0230)
+      and [SDK PR](https://github.com/cosmos/cosmos-sdk/pull/1927)
+        - BeginBlock no longer includes crypto.Pubkey
+        - use time.Time instead of int64 for time.
+
+FEATURES
+
+* Gaia REST API (`gaiacli advanced rest-server`)
+    - [x/gov] Can now query governance proposals by ProposalStatus
+
+* Gaia CLI  (`gaiacli`)
+    - [x/gov] added `query-proposals` command. Can filter by `depositer`, `voter`, and `status`
+    - [x/stake] \#2043 Added staking query cli cmds for unbonding-delegations and redelegations
+
+* Gaia
+  - [networks] Added ansible scripts to upgrade seed nodes on a network
+
+* SDK
+  - [x/mock/simulation] Randomized simulation framework
+     - Modules specify invariants and operations, preferably in an x/[module]/simulation package
+     - Modules can test random combinations of their own operations
+     - Applications can integrate operations and invariants from modules together for an integrated simulation
+     - Simulates Tendermint's algorithm for validator set updates
+     - Simulates validator signing/downtime with a Markov chain, and occaisional double-signatures
+     - Includes simulated operations & invariants for staking, slashing, governance, and bank modules
+  - [store] \#1481 Add transient store
+  - [baseapp] Initialize validator set on ResponseInitChain
+  - [baseapp] added BaseApp.Seal - ability to seal baseapp parameters once they've been set
+  - [cosmos-sdk-cli] New `cosmos-sdk-cli` tool to quickly initialize a new
+    SDK-based project
+  - [scripts] added log output monitoring to DataDog using Ansible scripts
+
+IMPROVEMENTS
+
+* Gaia
+  - [spec] \#967 Inflation and distribution specs drastically improved
+  - [x/gov] \#1773 Votes on a proposal can now be queried
+  - [x/gov] Initial governance parameters can now be set in the genesis file
+  - [x/stake] \#1815 Sped up the processing of `EditValidator` txs.
+  - [config] \#1930 Transactions indexer indexes all tags by default.
+  - [ci] [#2057](https://github.com/cosmos/cosmos-sdk/pull/2057) Run `make localnet-start` on every commit and ensure network reaches at least 10 blocks
+
+* SDK
+  - [baseapp] \#1587 Allow any alphanumeric character in route
+  - [baseapp] Allow any alphanumeric character in route
+  - [tools] Remove `rm -rf vendor/` from `make get_vendor_deps`
+  - [x/auth] Recover ErrorOutOfGas panic in order to set sdk.Result attributes correctly
+  - [x/bank] Unit tests are now table-driven
+  - [tests] Add tests to example apps in docs
+  - [tests] Fixes ansible scripts to work with AWS too
+  - [tests] \#1806 CLI tests are now behind the build flag 'cli_test', so go test works on a new repo
+
+BUG FIXES
+
+* Gaia CLI  (`gaiacli`)
+  -  \#1766 Fixes bad example for keybase identity
+  -  [x/stake] \#2021 Fixed repeated CLI commands in staking
+
+* Gaia
+  - [x/stake] [#2077](https://github.com/cosmos/cosmos-sdk/pull/2077) Fixed invalid cliff power comparison
+  - \#1804 Fixes gen-tx genesis generation logic temporarily until upstream updates
+  - \#1799 Fix `gaiad export`
+  - \#1839 Fixed bug where intra-tx counter wasn't set correctly for genesis validators
+  - [x/stake] \#1858 Fixed bug where the cliff validator was not updated correctly
+  - [tests] \#1675 Fix non-deterministic `test_cover`
+  - [tests] \#1551 Fixed invalid LCD test JSON payload in `doIBCTransfer`
+  - [basecoin] Fixes coin transaction failure and account query [discussion](https://forum.cosmos.network/t/unmarshalbinarybare-expected-to-read-prefix-bytes-75fbfab8-since-it-is-registered-concrete-but-got-0a141dfa/664/6)
+  - [x/gov] \#1757 Fix VoteOption conversion to String
+  * [x/stake] [#2083] Fix broken invariant of bonded validator power decrease
+
 ## 0.23.1
 
 *July 27th, 2018*
@@ -20,7 +134,7 @@ IMPROVEMENTS
 * [cli] Improve error messages for all txs when the account doesn't exist
 * [tendermint] Update to v0.22.6
     - Updates the crypto imports/API (#1966)
-* [x/stake] Add revoked to human-readable validator 
+* [x/stake] Add revoked to human-readable validator
 
 BUG FIXES
 * [tendermint] Update to v0.22.6
@@ -77,6 +191,8 @@ BUG FIXES
 * [keys] \#1629 - updating password no longer asks for a new password when the first entered password was incorrect
 * [lcd] importing an account would create a random account
 * [server] 'gaiad init' command family now writes provided name as the moniker in `config.toml`
+* [build] Added Ledger build support via `LEDGER_ENABLED=true|false`
+  * True by default except when cross-compiling
 
 ## 0.20.0
 
@@ -165,7 +281,7 @@ FEATURES
 * [types] Added MinInt and MinUint functions
 * [gaiad] `unsafe_reset_all` now resets addrbook.json
 * [democoin] add x/oracle, x/assoc
-* [tests] created a randomized testing framework. 
+* [tests] created a randomized testing framework.
   - Currently bank has limited functionality in the framework
   - Auth has its invariants checked within the framework
 * [tests] Add WaitForNextNBlocksTM helper method