Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.24.0 #1991

Merged
merged 277 commits into from
Aug 19, 2018
Merged

Release/v0.24.0 #1991

merged 277 commits into from
Aug 19, 2018

Conversation

ebuchman
Copy link
Member

Ref #1935

TODO:

  • bump version
  • fix, update, and review changelog
  • improve changelog further to aid Voyager and other users
  • improve changelog yet further again
  • pull in Add RELEASE_TEST_SCRIPT.md #1899 (?)
  • update/fix/improve any relevant docs

AdityaSripal and others added 30 commits July 13, 2018 12:35
in progress
in progress
stake and slashing now params
fix gaia
fix gaia again
add msg type deactivation
delete local error
in progress
revert actual application in baseapp/gaia/stake
add test, fix apps
fix MinSignedPerWindow, pass lint
fix gaia
fix keeper_test
fit with multiple msgs
fix
apply requests
pass lint
really the last fix
fix dependency
fix keeper_test
fix lint
* Merge pull request #1674: Fix Cross Compile Build/Ledger Build Tag
* Merge pull request #1674: Fix Cross Compile Build/Ledger Build Tag
* Remove incorrect Ledger test
* tools: Ensure Gopkg.lock is correct in linting

This adds dep status to the lint process. Also fixes linting errors
that existed earlier. (not sure why they didn't show up on CI)

Closes #1574

* Update dep, use the lock file new dep version creates
update to tm0.22.4-rc0 and bring back lcd test
…D_PROJECT_SHORT_NAME_ to actual names and packages
* types: Switch table driven test error messages to new format

Make table driven tests in /types follow the format described in #1664

* typos / lower case errors

* lower case, not sentences

* lower case, not sentences
update params for x/gov and default config
Indicates to use require's and asserts, and to use table driven
tests, with error messages as described in #1664.

Closes #1664
@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

Also to-do prior to release: check all testnet params are configured as desired.

Note that params store is not initialized from genesis until #1772 is merged, which is no longer slated for 0.24.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

I think we want to pull #1995 into this release.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

@ebuchman #1999 stages several changes we should pull into this branch prior to releasing 0.24:

  • Update SignedBlocksWindow to 1000
  • Use latest version of Ledger client library
  • Update version/version.go

@cwgoes cwgoes mentioned this pull request Aug 13, 2018
3 tasks
* Set SignedBlocksWindow back to 1000

* Merge PR #1995: upgrading ledger goclient lib

* Update version/version.go
@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

As part of updating/cleaning up the changelog, we should clear PENDING.md

@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

LGTM pending internal testnet testing.

@cwgoes
Copy link
Contributor

cwgoes commented Aug 16, 2018

Blocked on #2063 and we should merge #1783 too.

jackzampolin and others added 6 commits August 16, 2018 20:23
* This demonstrates that the state machine is non-deterministic if there
are more than two txs in a block.

* fix non-deterministic map iteration

* (squash this) fix build errors

* (squash this) iterate using range
* Update cli docs, fixes #2026

* Fixed merge conflicts

* Updated chain_id
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Once merged we should immediately merge master back to develop.

@ebuchman
Copy link
Member Author

Awesome work fam!

@ebuchman ebuchman merged commit d5652d9 into master Aug 19, 2018
@cwgoes cwgoes deleted the release/v0.24.0 branch October 26, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.