Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RELEASE_TEST_SCRIPT.md #1899

Closed
wants to merge 17 commits into from
Closed

Add RELEASE_TEST_SCRIPT.md #1899

wants to merge 17 commits into from

Conversation

jackzampolin
Copy link
Member

This PR adds the /docs/RELEASE_TEST_SCRIPT.md that is mentioned in the /docs/RELEASE_PROCESS.md. It is currently lacking links to documentation, but those can be added later.

- Vote on a proposal
- Query status of a proposal
- Query the votes on a proposal
- Export state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use of doing this without re-importing state? Just to test that gaiad export doesn't crash?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah also funny things could happen on export state (and reloading from an export) like information not being carried properly - maybe we should check that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ but yeah export state didn't work previously - it was just broken on master for a while

Copy link
Member Author

@jackzampolin jackzampolin Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested in the meeting yesterday so I added it. Should it be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - takes 5 seconds anyways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try "export and reload"? I think that's way more informative, and it only takes 10 seconds instead of 5!

(all you need to do is gaiad export > genesis.json; cp genesis.json ~/.gaiad/config/genesis.json; gaiad start)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zramsay do you mind adding that while you are making changes here?

greg-szabo and others added 2 commits August 1, 2018 03:13
* Added seed node update scripts
* Updated PENDING
* Fixed issue with GENESISFILE and added GENESISURL to seed node scripts
* Fixed unsafe reset bug
* As requested, multiline ansible-playbook command
* Added monitoring gaiacli.service to logz.io template
* Added journald configuration ansible script
* Merge pull request #1812: Add BaseApp.Seal

fix pow

move setter functions

apply requests

* fix errors

* fix test

* fix test

* changelog
@zramsay zramsay assigned zramsay and unassigned ebuchman Aug 1, 2018
* Merge pull request #1856: gen-tx: Support User Given Key Passwords

* Fix broken CLI test(s)
@zramsay
Copy link
Contributor

zramsay commented Aug 1, 2018

after a brief chat with @jackzampolin, we're going to add a link to the docs for each bullet point. i'll pick that up

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #1899 into develop will increase coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1899      +/-   ##
===========================================
+ Coverage    63.55%   63.83%   +0.28%     
===========================================
  Files          119      118       -1     
  Lines         7062     7024      -38     
===========================================
- Hits          4488     4484       -4     
+ Misses        2314     2285      -29     
+ Partials       260      255       -5

Copy link
Member Author

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we link to the exact piece of the /docs/validator/validator-setup.md. Any of the TODOs here we should create a new file that describes how to do this.

@zramsay
Copy link
Contributor

zramsay commented Aug 3, 2018

yeah i want to massage the naming of the headings before adding links

```

This will generate a `genesis.json` in `$HOME/.gaiad/config/genesis.json` distribute this file to all validators on your testnet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1915 because the above section needs love.

@jackzampolin
Copy link
Member Author

Looking much better @zramsay!

@jackzampolin jackzampolin mentioned this pull request Aug 7, 2018
3 tasks
@jackzampolin
Copy link
Member Author

Weren't we going to merge this @zramsay?

@ebuchman ebuchman mentioned this pull request Aug 12, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

Needs a rebase.

@jackzampolin
Copy link
Member Author

Has rebase now!

@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

Has rebase now!

Look at the "Files Changed" tab - I don't understand why all these files are in this PR?

@jackzampolin
Copy link
Member Author

jackzampolin commented Aug 13, 2018

@cwgoes We moved all that content out to the comsos/testnets repo. I thought removing it here would be good. If not I can remove those files from this PR and open another one to remove them.

@jackzampolin
Copy link
Member Author

Closing this in favor of #2010

@jackzampolin jackzampolin deleted the jack/add-testing-script branch August 13, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants