-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RELEASE_TEST_SCRIPT.md #1899
Add RELEASE_TEST_SCRIPT.md #1899
Conversation
docs/RELEASE_TEST_SCRIPT.md
Outdated
- Vote on a proposal | ||
- Query status of a proposal | ||
- Query the votes on a proposal | ||
- Export state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use of doing this without re-importing state? Just to test that gaiad export
doesn't crash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah also funny things could happen on export state (and reloading from an export) like information not being carried properly - maybe we should check that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ but yeah export state didn't work previously - it was just broken on master for a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was suggested in the meeting yesterday so I added it. Should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - takes 5 seconds anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try "export and reload"? I think that's way more informative, and it only takes 10 seconds instead of 5!
(all you need to do is gaiad export > genesis.json; cp genesis.json ~/.gaiad/config/genesis.json; gaiad start
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zramsay do you mind adding that while you are making changes here?
* Added seed node update scripts * Updated PENDING * Fixed issue with GENESISFILE and added GENESISURL to seed node scripts * Fixed unsafe reset bug * As requested, multiline ansible-playbook command * Added monitoring gaiacli.service to logz.io template * Added journald configuration ansible script
* Merge pull request #1812: Add BaseApp.Seal fix pow move setter functions apply requests * fix errors * fix test * fix test * changelog
* Merge pull request #1856: gen-tx: Support User Given Key Passwords * Fix broken CLI test(s)
after a brief chat with @jackzampolin, we're going to add a link to the docs for each bullet point. i'll pick that up |
Codecov Report
@@ Coverage Diff @@
## develop #1899 +/- ##
===========================================
+ Coverage 63.55% 63.83% +0.28%
===========================================
Files 119 118 -1
Lines 7062 7024 -38
===========================================
- Hits 4488 4484 -4
+ Misses 2314 2285 -29
+ Partials 260 255 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we link to the exact piece of the /docs/validator/validator-setup.md
. Any of the TODO
s here we should create a new file that describes how to do this.
yeah i want to massage the naming of the headings before adding links |
``` | ||
|
||
This will generate a `genesis.json` in `$HOME/.gaiad/config/genesis.json` distribute this file to all validators on your testnet. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1915 because the above section needs love.
Looking much better @zramsay! |
Weren't we going to merge this @zramsay? |
Needs a rebase. |
…mos-sdk into jack/add-testing-script
Has rebase now! |
Look at the "Files Changed" tab - I don't understand why all these files are in this PR? |
@cwgoes We moved all that content out to the |
Closing this in favor of #2010 |
This PR adds the
/docs/RELEASE_TEST_SCRIPT.md
that is mentioned in the/docs/RELEASE_PROCESS.md
. It is currently lacking links to documentation, but those can be added later.