Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(confix): update latest config value #20012

Merged
merged 1 commit into from
Apr 11, 2024
Merged

chore(confix): update latest config value #20012

merged 1 commit into from
Apr 11, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 11, 2024 •
edited by coderabbitai bot
Loading

Description

ref: #20008 (comment)

To actually have chains have the correct behavior by default, let's update config default value as well.
I'll cherry-pick this PR in #20008 so no need to add the backport label.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Enhanced the mempool configuration to allow disabling of transaction insertions by setting max_txs to -1, labeled as "no-op mempool" for clarity.

@julienrbrt julienrbrt requested a review from a team as a code owner April 11, 2024 10:37
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent modifications involve setting the max_txs parameter to -1 across various configuration files, effectively disabling the insertion of transactions into the mempool. This change is uniformly applied across different versions and tools, ensuring that transactions are not processed in the specified setups, marking them as no-operation (no-op) mempools.

Changes

File Path Change Summary
server/config/toml.go Added note "no-op mempool" to clarify disabling transactions in mempool
tools/confix/data/v0.50-app.toml
tools/confix/data/v0.51-app.toml		 Set max-txs to -1, disabling transaction insertion into the mempool
Recent Review Details

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between a0d727e and 472da7f.
Files selected for processing (3)
  • server/config/toml.go (1 hunks)
  • tools/confix/data/v0.50-app.toml (1 hunks)
  • tools/confix/data/v0.51-app.toml (1 hunks)
Additional Context Used
Path-based Instructions (1)
server/config/toml.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (3)
tools/confix/data/v0.50-app.toml (1)

235-235: The update of max-txs from 5000 to -1 effectively disables the mempool, which aligns with the intended behavior changes. Ensure that this change is well-documented in user-facing materials to avoid confusion.

tools/confix/data/v0.51-app.toml (1)

236-236: The update of max-txs from 5000 to -1 in this version of the configuration file maintains consistency with other versions. This ensures uniform behavior across different deployments. Documentation should clearly explain this change to users.

server/config/toml.go (1)

243-243: The addition of the comment explaining the no-op mempool behavior when max_txs is set to -1 enhances clarity. This is a valuable addition for both developers and users to understand the operational impact of this setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:Confix Issues and PR related to Confix label Apr 11, 2024
@samricotta samricotta added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 57b659e Apr 11, 2024
64 checks passed
@samricotta samricotta deleted the julien/update-config branch April 11, 2024 14:25
julienrbrt added a commit that referenced this pull request Apr 11, 2024
@julienrbrt
chore(confix): update latest config value (#20012)
ccb5b57
alpe added a commit to alpe/cosmos-sdk that referenced this pull request Apr 15, 2024
@alpe
Merge branch 'main' into alex/testnet
183e1ee 
* main: (25 commits)
  fix: Implement gogoproto customtype to secp256r1 keys (cosmos#20027)
  fix(x/epochs): avoid invalid epoch duration in simulation (cosmos#20030)
  fix(x/bank): align query with multi denoms for send-enabled (cosmos#20028)
  refactor(x/slashing)!: remove Accounts String (cosmos#20026)
  refactor(x/evidence)!: remove Address.String() (cosmos#20016)
  chore: make telemetry consistent (cosmos#20025)
  chore: prepare x/tx changelog (cosmos#20015)
  build(deps): Bump actions/add-to-project from 1.0.0 to 1.0.1 (cosmos#20018)
  feat(x/bank): support depinject for send restrictions (cosmos#20014)
  feat: Conditionally emit metrics based on enablement (cosmos#19903)
  fix(store): fix the typo (cosmos#20011)
  docs(x/feegrant): fix allowance typo (cosmos#20000)
  chore(confix): update latest config value (cosmos#20012)
  refactor(x/auth): auth module can recognize x/accounts account (cosmos#20002)
  fix(mempool): use no-op mempool as default (cosmos#19970)
  fix(simapp): add epoch store to upgrade (cosmos#20007)
  test(kv): add unit tests for the helpers functions kv.AssertKeyAtLeas… (cosmos#19965)
  feat(x/tx): Rename custom Amino JSON encoder to "inline_json" (cosmos#19919)
  refactor(x/auth): use transaction service (cosmos#19967)
  fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (cosmos#19976)
  ...
alpe added a commit that referenced this pull request Apr 15, 2024
@alpe
Merge branch 'main' into alex/system_tests_wip
1297157 
* main:
  fix: Implement gogoproto customtype to secp256r1 keys (#20027)
  fix(x/epochs): avoid invalid epoch duration in simulation (#20030)
  fix(x/bank): align query with multi denoms for send-enabled (#20028)
  refactor(x/slashing)!: remove Accounts String (#20026)
  refactor(x/evidence)!: remove Address.String() (#20016)
  chore: make telemetry consistent (#20025)
  chore: prepare x/tx changelog (#20015)
  build(deps): Bump actions/add-to-project from 1.0.0 to 1.0.1 (#20018)
  feat(x/bank): support depinject for send restrictions (#20014)
  feat: Conditionally emit metrics based on enablement (#19903)
  fix(store): fix the typo (#20011)
  docs(x/feegrant): fix allowance typo (#20000)
  chore(confix): update latest config value (#20012)
@okdas okdas mentioned this pull request Jul 11, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samricotta samricotta samricotta approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees

@tac0turtle tac0turtle

@samricotta samricotta

Labels
C:Confix Issues and PR related to Confix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @tac0turtle @samricotta