[CosmosSDK] Bump to v0.50.7 #682

okdas · 2024-07-11T01:18:09Z

Summary

Bumps cosmos-sdk to the latest available.

Issue

[CosmosSDK] Upgrade SDK version to >= 0.50.5 #591

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

Unit Tests: make go_develop_and_test
LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

Summary by CodeRabbit

New Features
- Updated module dependencies to the latest versions for improved performance and security.
Configuration Changes
- Mempool configuration now allows an unlimited number of transactions.
- Updated version in config.toml to "0.38.7".

coderabbitai · 2024-07-11T01:18:14Z

Walkthrough

The recent updates primarily involve version upgrades for various Go modules and configuration adjustments for the local network setup. Notable changes include incrementing versions in go.mod, setting the maximum number of transactions in the mempool to unlimited in app.toml, and updating the version in config.toml.

Changes

File	Change Summary
`go.mod`	Updated versions for dependencies including `cosmossdk.io/math`, `github.com/cosmos/cosmos-sdk`, `google.golang.org/grpc`, etc.
`localnet/poktrolld/config/app.toml`	Changed max transactions in the mempool from `5000` to `-1` (unlimited).
`localnet/poktrolld/config/config.toml`	Updated configuration version from "0.38.5" to "0.38.7".

Poem

In lines of code and modules bright,
We set dependencies to new height,
Mempools now with endless might,
Configs updated, future's in sight,
Celebrate the changes, oh what a delight!
🌟🐇✨

Tip

You can customize the tone of the comments in your PRs

Specify the tone of the comments in your PRs by configuring the tone-instructions setting in your project's settings in CodeRabbit.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-11T01:18:53Z

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 682)
Grafana network dashboard for devnet-issue-{issue-id}

github-actions · 2024-07-11T01:22:33Z

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 682)
Grafana network dashboard for devnet-issue-{issue-id}

okdas · 2024-07-11T01:42:16Z

Alright, everything seems to work locally, including e2e and stress tests. I had to bump my local buf binary to the latest. With the version changed in go.mod, it might not be necessary, but this is a note for the reviewer to try to switch to that branch and run a LocalNet. The new developer setup should work; it's the already existing setup I'm worried about.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bdbc365 and f0c6b49.

Files ignored due to path filters (17)

api/poktroll/application/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/application/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/gateway/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/gateway/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/proof/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/proof/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/service/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/service/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/session/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/session/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/shared/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/shared/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/supplier/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/supplier/tx_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/tokenomics/query_grpc.pb.go is excluded by !**/*.pb.go
api/poktroll/tokenomics/tx_grpc.pb.go is excluded by !**/*.pb.go
go.sum is excluded by !**/*.sum

Files selected for processing (3)

go.mod (9 hunks)
localnet/poktrolld/config/app.toml (1 hunks)
localnet/poktrolld/config/config.toml (1 hunks)

Files skipped from review due to trivial changes (2)

localnet/poktrolld/config/app.toml
localnet/poktrolld/config/config.toml

Additional comments not posted (10)

go.mod (10)

26-26: Approved: Update to cosmossdk.io/math

The update to cosmossdk.io/math v1.3.0 is approved.

27-27: Approved: Update to cosmossdk.io/store

The update to cosmossdk.io/store v1.1.0 is approved.

37-38: Approved: Updates to github.com/cosmos/cosmos-proto and github.com/cosmos/cosmos-sdk

The updates to github.com/cosmos/cosmos-proto v1.0.0-beta.5 and github.com/cosmos/cosmos-sdk v0.50.7 are approved.

39-39: Approved: Update to github.com/cosmos/gogoproto

The update to github.com/cosmos/gogoproto v1.5.0 is approved.

49-50: Approved: Updates to github.com/grpc-ecosystem/grpc-gateway/v2 and github.com/hashicorp/go-metrics

The updates to github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 and github.com/hashicorp/go-metrics v0.5.3 are approved.

62-66: Approved: Updates to github.com/prometheus/client_golang and github.com/spf13/cobra

The updates to github.com/prometheus/client_golang v1.19.0 and github.com/spf13/cobra v1.8.1 are approved.

69-69: Approved: Update to github.com/stretchr/testify

The update to github.com/stretchr/testify v1.9.0 is approved.

71-74: Approved: Updates to golang.org/x/crypto, golang.org/x/exp, golang.org/x/sync, and golang.org/x/tools

The updates to golang.org/x/crypto v0.25.0, golang.org/x/exp v0.0.0-20240707233637-46b078467d37, golang.org/x/sync v0.7.0, and golang.org/x/tools v0.23.0 are approved.

75-76: Approved: Updates to google.golang.org/genproto/googleapis/api and google.golang.org/grpc

The updates to google.golang.org/genproto/googleapis/api v0.0.0-20240709173604-40e1e62336c5 and google.golang.org/grpc v1.65.0 are approved.

83-93: Approved: Updates to indirect dependencies

The updates to various indirect dependencies are approved.

okdas · 2024-07-11T01:48:04Z

@bryanchriswhite do you have any cycles to look into that? jk, the PR is not that large! All changes are code generated.

bryanchriswhite

🚀

bryanchriswhite · 2024-07-11T06:27:05Z

localnet/poktrolld/config/app.toml

-  max-txs = 5000
+  max-txs = -1


Is this intentional?

According to the docs, this disables the mempool but I don't see why we would want to do that.

@bryanchriswhite this is the value cosmos-sdk generates by default now. I, personally, like to keep the default values. And we do adjust this config on the live network.

Related PRs explaining the change:

cosmos/cosmos-sdk#20008 (original: cosmos/cosmos-sdk#19970)
cosmos/cosmos-sdk#20012

@bryanchriswhite To be clear, I do not oppose using the 5000 value here! :) Reading these two PRs still leaves the question of what the expectation for this value is on the full-blown network. I guess, just like with the existing mainnet, we will learn the behavior of the network and adjust.

bryanchriswhite

Thanks @okdas! 🙌

Preemptively approving. I just wanted to confirm the mempool config change.

…ent-balances * pokt/main: [TODOs] refactor: proof path calculation (#659) [Dependencies] bump go-getter and ibc-go (#691) [Relayminer] refactor: `relayerSessionsManager#waitForBlock()` (#648) [Observables] chore: add `ReplayObservable#SubscribeFromLatestBufferedOffset()` (#647) [Observability] Add claim relays counter (#644) [Code Health] chore: log unused error when updating relay mining difficulty (#683) [Testing] chore: uncomment proof CLI query tests (#668) build(deps): bump ws from 7.5.9 to 7.5.10 in /docusaurus (#686) build(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /docusaurus (#688) build(deps): bump express from 4.18.2 to 4.19.2 in /docusaurus (#687) build(deps): bump follow-redirects from 1.15.3 to 1.15.6 in /docusaurus (#685) build(deps): bump braces from 3.0.2 to 3.0.3 in /docusaurus (#689) [CosmosSDK] Bump to v0.50.7 (#682)

…ation-overserviced * pokt/main: [TODOs] refactor: proof path calculation (#659) [Dependencies] bump go-getter and ibc-go (#691) [Relayminer] refactor: `relayerSessionsManager#waitForBlock()` (#648) [Observables] chore: add `ReplayObservable#SubscribeFromLatestBufferedOffset()` (#647) [Observability] Add claim relays counter (#644) [Code Health] chore: log unused error when updating relay mining difficulty (#683) [Testing] chore: uncomment proof CLI query tests (#668) build(deps): bump ws from 7.5.9 to 7.5.10 in /docusaurus (#686) build(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /docusaurus (#688) build(deps): bump express from 4.18.2 to 4.19.2 in /docusaurus (#687) build(deps): bump follow-redirects from 1.15.3 to 1.15.6 in /docusaurus (#685) build(deps): bump braces from 3.0.2 to 3.0.3 in /docusaurus (#689) [CosmosSDK] Bump to v0.50.7 (#682)

…ation-use-index * pokt/main: [TODOs] refactor: proof path calculation (#659) [Dependencies] bump go-getter and ibc-go (#691) [Relayminer] refactor: `relayerSessionsManager#waitForBlock()` (#648) [Observables] chore: add `ReplayObservable#SubscribeFromLatestBufferedOffset()` (#647) [Observability] Add claim relays counter (#644) [Code Health] chore: log unused error when updating relay mining difficulty (#683) [Testing] chore: uncomment proof CLI query tests (#668) build(deps): bump ws from 7.5.9 to 7.5.10 in /docusaurus (#686) build(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /docusaurus (#688) build(deps): bump express from 4.18.2 to 4.19.2 in /docusaurus (#687) build(deps): bump follow-redirects from 1.15.3 to 1.15.6 in /docusaurus (#685) build(deps): bump braces from 3.0.2 to 3.0.3 in /docusaurus (#689) [CosmosSDK] Bump to v0.50.7 (#682)

bump cosmos-sdk to v0.50.7

48bdcfe

okdas self-assigned this Jul 11, 2024

okdas added the infra Infra or tooling related improvements, additions or fixes label Jul 11, 2024

okdas added this to the Shannon Beta TestNet Launch milestone Jul 11, 2024

okdas added the devnet-test-e2e label Jul 11, 2024

github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jul 11, 2024

okdas added dependencies Pull requests that update a dependency file and removed push-image CI related - pushes images to ghcr.io devnet labels Jul 11, 2024

github-actions bot removed the devnet-test-e2e label Jul 11, 2024

okdas added the devnet-test-e2e label Jul 11, 2024

github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jul 11, 2024

okdas added 2 commits July 10, 2024 18:31

buf bump and config changes

8a8f235

wip

f0c6b49

okdas marked this pull request as ready for review July 11, 2024 01:42

okdas requested a review from bryanchriswhite July 11, 2024 01:45

coderabbitai bot reviewed Jul 11, 2024

View reviewed changes

bryanchriswhite reviewed Jul 11, 2024

View reviewed changes

bryanchriswhite approved these changes Jul 11, 2024

View reviewed changes

okdas merged commit d812602 into main Jul 11, 2024
10 checks passed

okdas mentioned this pull request Jul 12, 2024

[CosmosSDK] Upgrade SDK version to >= 0.50.5 #591

Closed

2 tasks

okdas added a commit that referenced this pull request Nov 14, 2024

[CosmosSDK] Bump to v0.50.7 (#682)

4405050

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CosmosSDK] Bump to v0.50.7 #682

[CosmosSDK] Bump to v0.50.7 #682

okdas commented Jul 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

okdas commented Jul 11, 2024

coderabbitai bot left a comment

okdas commented Jul 11, 2024 •

edited

Loading

bryanchriswhite left a comment

bryanchriswhite Jul 11, 2024

okdas Jul 11, 2024

okdas Jul 11, 2024

bryanchriswhite left a comment

[CosmosSDK] Bump to v0.50.7 #682

[CosmosSDK] Bump to v0.50.7 #682

Conversation

okdas commented Jul 11, 2024 • edited by coderabbitai bot Loading

Summary

Issue

Type of change

Testing

Sanity Checklist

Summary by CodeRabbit

coderabbitai bot commented Jul 11, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

okdas commented Jul 11, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

okdas commented Jul 11, 2024 • edited Loading

bryanchriswhite left a comment

Choose a reason for hiding this comment

bryanchriswhite Jul 11, 2024

Choose a reason for hiding this comment

okdas Jul 11, 2024

Choose a reason for hiding this comment

okdas Jul 11, 2024

Choose a reason for hiding this comment

bryanchriswhite left a comment

Choose a reason for hiding this comment

okdas commented Jul 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

okdas commented Jul 11, 2024 •

edited

Loading