fix: nested multisig signatures using CLI (backport #20438)

[mergify]

Description

Closes: #20355 and #20382

This PR enables the CLI to sign nested multisig txs, by modifying how the signer check is done and adding a flag to disable signature verification. Also #20404 was included here.

It was tested with 4 common accounts (alice, bob, carol and dave) forming 3 multisigs: ms1 (alice, bob), ms2 (bob, carol) and ms3 (bob, dave, ms1, ms2). Then a tx from ms3 is created and signed by all the participants.

./build/simd keys add alice --keyring-backend test --home ./.testnets/node0/simd/
./build/simd keys add bob --keyring-backend test --home ./.testnets/node0/simd/
./build/simd keys add carol --keyring-backend test --home ./.testnets/node0/simd/
./build/simd keys add dave --keyring-backend test --home ./.testnets/node0/simd/

./build/simd keys add ms1 --multisig alice,bob --multisig-threshold 2 --home ./.testnets/node0/simd/ --keyring-backend test
./build/simd keys add ms2 --multisig bob,carol --multisig-threshold 2 --home ./.testnets/node0/simd/ --keyring-backend test
./build/simd keys add ms3 --multisig bob,dave,ms1,ms2 --multisig-threshold 4 --home ./.testnets/node0/simd/ --keyring-backend test

./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show alice --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show bob --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show carol --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show dave --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show ms1 --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show ms2 --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/
./build/simd tx bank send $(./build/simd keys show node0 --address  --keyring-backend=test --home ./.testnets/node0/simd/) $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/) 100stake --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/


./build/simd tx bank send $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/)  $(./build/simd keys show ms1 --address  --keyring-backend=test --home ./.testnets/node0/simd/)  3stake --fees 5stake --generate-only --chain-id chain-BbTt8V --keyring-backend test > tx.json

./build/simd tx sign tx.json --home ./.testnets/node0/simd/ --multisig $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/) --chain-id chain-BbTt8V --keyring-backend test  --from alice > sig-alice.json
./build/simd tx sign tx.json --home ./.testnets/node0/simd/ --multisig $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/) --chain-id chain-BbTt8V --keyring-backend test  --from bob > sig-bob.json
./build/simd tx sign tx.json --home ./.testnets/node0/simd/ --multisig $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/) --chain-id chain-BbTt8V --keyring-backend test  --from carol > sig-carol.json
./build/simd tx sign tx.json --home ./.testnets/node0/simd/ --multisig $(./build/simd keys show ms3 --address  --keyring-backend=test --home ./.testnets/node0/simd/) --chain-id chain-BbTt8V --keyring-backend test  --from dave > sig-dave.json

./build/simd tx multisign tx.json ms1 sig-alice.json sig-bob.json --chain-id chain-BbTt8V --home ./.testnets/node0/simd/  --keyring-backend test --signature-only --skip-signature-verification > sig-ms1.json 
./build/simd tx multisign tx.json ms2 sig-bob.json sig-carol.json --chain-id chain-BbTt8V --home ./.testnets/node0/simd/  --keyring-backend test --signature-only --skip-signature-verification > sig-ms2.json 
./build/simd tx multisign tx.json ms3 sig-bob.json sig-dave.json sig-ms1.json sig-ms2.json --chain-id chain-BbTt8V --home ./.testnets/node0/simd/  --keyring-backend test > tx-ms3.json

./build/simd tx broadcast tx-ms3.json --gas auto --fees 5stake --chain-id chain-BbTt8V --keyring-backend test --home ./.testnets/node0/simd/ --from dave

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced the --skip-signature-verification flag for multisig transactions, allowing users to skip signature verification.
  • Added support for nested multisig transactions, enabling multisig accounts to include other multisig accounts.

• Bug Fixes

  • Improved the packPubKeys function to correctly unmarshal public keys.

• Tests

  • Added a new test for nested multisig key outputs.

• Documentation

  • Updated documentation to reflect new features related to nested multisig transactions and the --skip-signature-verification flag.

---

This is an automatic backport of pull request #20438 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of b9ca318 has failed:

On branch mergify/bp/release/v0.50.x/pr-20438
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit b9ca31812.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/keys/output_test.go
	modified:   crypto/keys/multisig/multisig.go
	modified:   x/auth/README.md
	modified:   x/auth/client/cli/tx_multisign.go
	modified:   x/auth/client/cli/tx_sign.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/auth/client/tx.go
	both modified:   x/tx/CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

can we add a changelog in CHANGELOG.md? (x/auth isn't extracted in v0.50)

[julienrbrt]

As said in the other PR, changelog was misplaced here, this should all be reverted

[facundomedica]

DNM please, I'm testing 👍

[facundomedica]

LGTM, tested locally and works. It stopped working on main tho, something else must have broken it

[julienrbrt]

utACK