docs: update script to fix copying issue #20720
Conversation
WalkthroughWalkthroughThis update modifies the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
docs/pre.sh (1)
Line range hint
18-18: There's a TODO comment related to issue #9958. Ensure that this issue is actively being addressed to prevent it from becoming stale.Would you like me to help with resolving this or should I open a reminder issue on GitHub?
| @@ -7,7 +7,7 @@ for D in ../x/*; do | |||
|
|
|||
| # Skip specific directories | |||
| if [[ "$DIR_NAME" != "counter" ]]; then | |||
| MODULE_DIRECTORY=build/modules/$DIR_NAME | |||
| MODULE_DIRECTORY=docs/build/modules/$DIR_NAME | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The search results indicate that the new path MODULE_DIRECTORY=docs/build/modules is only present in docs/pre.sh, and there are no references to the old path MODULE_DIRECTORY=build/modules elsewhere in the repository.
docs/pre.sh:MODULE_DIRECTORY=docs/build/modules/$DIR_NAME
This suggests that the updated path is not used consistently across the project. Please review and update all relevant references to ensure consistency.
Analysis chain
The updated MODULE_DIRECTORY path looks correct for the intended fix. Please ensure that all references to this path elsewhere in the project have been updated accordingly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all references to `MODULE_DIRECTORY` use the new path.
# Search for the old path and the new path to ensure consistency.
rg --type bash 'MODULE_DIRECTORY=build/modules'
rg --type bash 'MODULE_DIRECTORY=docs/build/modules'
Length of output: 158
Script:
#!/bin/bash
# Description: Verify all references to `MODULE_DIRECTORY` use the new path.
# Search for the old path and the new path to ensure consistency.
rg 'MODULE_DIRECTORY=build/modules'
rg 'MODULE_DIRECTORY=docs/build/modules'
Length of output: 140
Description
Closes: #XXXX
Updates folder placement for documentation as some of the files are being imported to the wrong place
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit