Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update script to fix copying issue #20720

Merged
merged 2 commits into from
Jun 19, 2024
+1 −1
Merged

docs: update script to fix copying issue #20720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b280547
Update pre.sh
samricotta Jun 18, 2024
b825067
Merge branch 'main' into sam/pre-script-docs
samricotta Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/pre.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ for D in ../x/*; do

# Skip specific directories
if [[ "$DIR_NAME" != "counter" ]]; then
MODULE_DIRECTORY=build/modules/$DIR_NAME
MODULE_DIRECTORY=docs/build/modules/$DIR_NAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The search results indicate that the new path MODULE_DIRECTORY=docs/build/modules is only present in docs/pre.sh, and there are no references to the old path MODULE_DIRECTORY=build/modules elsewhere in the repository.

  • docs/pre.sh: MODULE_DIRECTORY=docs/build/modules/$DIR_NAME

This suggests that the updated path is not used consistently across the project. Please review and update all relevant references to ensure consistency.

Analysis chain

The updated MODULE_DIRECTORY path looks correct for the intended fix. Please ensure that all references to this path elsewhere in the project have been updated accordingly.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to `MODULE_DIRECTORY` use the new path.

# Search for the old path and the new path to ensure consistency.
rg --type bash 'MODULE_DIRECTORY=build/modules'
rg --type bash 'MODULE_DIRECTORY=docs/build/modules'

Length of output: 158

Script:

#!/bin/bash
# Description: Verify all references to `MODULE_DIRECTORY` use the new path.

# Search for the old path and the new path to ensure consistency.
rg 'MODULE_DIRECTORY=build/modules'
rg 'MODULE_DIRECTORY=docs/build/modules'

Length of output: 140

rm -rf "$MODULE_DIRECTORY"
mkdir -p "$MODULE_DIRECTORY"
if [ -f "$D"/README.md ]; then
Expand Down
Loading