build(deps): use Go 1.23 instead of Go 1.22 #21280
Conversation
WalkthroughWalkthroughThe changes primarily involve upgrading the Go version across various GitHub Actions workflow files and Go module configuration files from 1.22 to 1.23. This update ensures compatibility with new features, performance improvements, and bug fixes introduced in the latest Go release. Additionally, several core dependencies have been upgraded to a stable version (v1.0.0), enhancing the overall stability and functionality of the modules. Changes
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
|
Need to run |
…ntal-features flakes update nixpkgs`
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
server/v2/cometbft/go.mod (1)
3-3: Compatibility Issues with Go 1.23 IdentifiedThe codebase contains several deprecated features and functions that may not be compatible with Go 1.23. Here are some key points:
Deprecated Features: The codebase uses deprecated functions and fields in various modules, such as
x/upgrade,x/staking,x/gov, and others. These may cause issues with newer Go versions.Dependencies: The
go.modfile lists several dependencies. Ensure that these are compatible with Go 1.23, as some might require updates or replacements.Please review these areas to ensure smooth operation with Go 1.23.
- Files with deprecated features:
x/upgrade/types/upgrade.pb.gox/staking/types/tx.pb.gox/gov/client/testutil/helpers.gox/distribution/types/distribution.pb.gox/auth/keeper/keeper.gox/auth/ante/basic.goAnalysis chain
Verify compatibility with Go 1.23.
Ensure that all code and dependencies are compatible with Go 1.23. This update may introduce new features or deprecations.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of codebase with Go 1.23. # Test: Check for any Go version-specific code or dependencies. rg --type go 'go1\.(22|23)' -A 3Length of output: 34
Script:
#!/bin/bash # Check for deprecated functions or features in Go 1.23 that might be used in the codebase. rg --type go 'deprecated' -A 3 # List Go module dependencies to check for any known compatibility issues with Go 1.23. cat server/v2/cometbft/go.modLength of output: 81296
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
Files selected for processing (69)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/dependabot-update-all.yml (1 hunks)
- .github/workflows/dependencies-review.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/pr-go-mod-tidy-mocks.yml (2 hunks)
- .github/workflows/release-confix.yml (1 hunks)
- .github/workflows/release-cosmovisor.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/sims-047.yml (5 hunks)
- .github/workflows/sims-050.yml (5 hunks)
- .github/workflows/sims-052.yml (5 hunks)
- .github/workflows/sims-nightly.yml (1 hunks)
- .github/workflows/sims.yml (5 hunks)
- .github/workflows/software-compat-v052.yml (1 hunks)
- .github/workflows/test.yml (42 hunks)
- .github/workflows/v2-test.yml (4 hunks)
- Dockerfile (1 hunks)
- client/v2/go.mod (1 hunks)
- collections/go.mod (1 hunks)
- contrib/devtools/Dockerfile (1 hunks)
- contrib/images/simd-dlv/Dockerfile (1 hunks)
- contrib/images/simd-env/Dockerfile (1 hunks)
- core/go.mod (1 hunks)
- core/testing/go.mod (1 hunks)
- crypto/armor_test.go (2 hunks)
- flake.nix (1 hunks)
- go.mod (1 hunks)
- go.work.example (1 hunks)
- indexer/postgres/tests/go.mod (2 hunks)
- orm/go.mod (1 hunks)
- runtime/v2/go.mod (2 hunks)
- schema/testing/go.mod (2 hunks)
- scripts/build/linting.mk (1 hunks)
- scripts/build/protobuf.mk (1 hunks)
- server/v2/appmanager/go.mod (1 hunks)
- server/v2/cometbft/go.mod (2 hunks)
- server/v2/go.mod (2 hunks)
- server/v2/stf/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- store/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/systemtests/go.mod (1 hunks)
- tools/confix/go.mod (1 hunks)
- tools/cosmovisor/go.mod (1 hunks)
- types/context_test.go (3 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/go.mod (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/tx/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (16)
- .github/workflows/build.yml
- .github/workflows/pr-go-mod-tidy-mocks.yml
- .github/workflows/release.yml
- .github/workflows/sims-047.yml
- .github/workflows/sims.yml
- .github/workflows/v2-test.yml
- Dockerfile
- contrib/images/simd-env/Dockerfile
- core/go.mod
- go.work.example
- orm/go.mod
- scripts/build/linting.mk
- server/v2/stf/go.mod
- tests/systemtests/go.mod
- tools/confix/go.mod
- x/tx/go.mod
Additional context used
Path-based instructions (3)
types/context_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"crypto/armor_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (89)
server/v2/appmanager/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that the codebase is compatible with this version and that any new features or changes in Go 1.23 are considered.
Verification successful
Go 1.23 Compatibility Verified
The codebase uses
os.RemoveAll, but there are no known deprecations or changes affecting this function in Go 1.23. There is no usage ofSetFinalizer, indicating no issues with this feature. It is recommended to review the Go 1.23 release notes for any other changes that might affect your codebase.
- Instances of
os.RemoveAllfound in multiple files, such as:
x/upgrade/plan/info.gosimapp/test_helpers.gostore/snapshots/store.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with Go 1.23 by checking for any deprecated features or changes. # Test: Search for deprecated features in Go 1.23. Expect: No deprecated features used. rg --type go 'deprecated' --since 1.23Length of output: 448
Script:
#!/bin/bash # Description: Check for deprecated or changed features in Go 1.23. # Test: Search for common deprecated or changed features in Go 1.23. # Example checks could include changes to the 'go' command, stdlib changes, etc. rg --type go 'SetFinalizer' --since 1.23 rg --type go 'os.RemoveAll' --since 1.23Length of output: 901
Script:
#!/bin/bash # Description: Check for deprecated or changed features in Go 1.23 without using '--since'. # Test: Search for specific features that are known to be deprecated or changed in Go 1.23. # Example checks could include changes to the 'go' command, stdlib changes, etc. rg --type go 'SetFinalizer' rg --type go 'os.RemoveAll'Length of output: 2030
7-7: Update dependency tocosmossdk.io/core v1.0.0.The dependency
cosmossdk.io/corehas been updated to v1.0.0. This major version change might introduce breaking changes or new features. Ensure that the module is compatible with this version.core/testing/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that the codebase is compatible with this version and that any new features or changes in Go 1.23 are considered.
8-8: Update dependency tocosmossdk.io/core v1.0.0.The dependency
cosmossdk.io/corehas been updated to v1.0.0. This major version change might introduce breaking changes or new features. Ensure that the module is compatible with this version.schema/testing/go.mod (1)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that the codebase is compatible with this version and that any new features or changes in Go 1.23 are considered.
collections/go.mod (2)
3-3: Ensure compatibility with Go 1.23.The Go version has been updated to 1.23. Ensure that all code and dependencies are compatible with this version.
6-6: Verify compatibility withcosmossdk.io/corev1.0.0.The core dependency has been updated to v1.0.0. Ensure that any breaking changes or new features are addressed in the codebase.
contrib/images/simd-dlv/Dockerfile (1)
1-1: Verify the build process with Go 1.23.The base image has been updated to
golang:1.23-alpine. Ensure that the build process and dependencies are compatible with this version..github/workflows/dependencies-review.yml (1)
17-17: Verify CI workflow with Go 1.23.The Go version in the CI workflow has been updated to 1.23. Ensure that all CI checks and dependency reviews are compatible with this version.
scripts/build/protobuf.mk (1)
1-1: Verify compatibility with the updated proto-builder version.The
protoVerhas been updated to0.15.0. Ensure that all scripts and dependencies are compatible with this new version to prevent build issues.indexer/postgres/tests/go.mod (1)
3-3: Verify compatibility with Go 1.23.The Go version has been updated to
1.23. Ensure that the codebase is compatible with this version and that any new features or changes are accounted for.contrib/devtools/Dockerfile (1)
5-6: Verify Dockerfile build with updated base images.The base images have been updated to
bufbuild/buf:1.36.0andgolang:1.23-alpine. Ensure that the Dockerfile builds successfully and that all dependencies are compatible with these versions..github/workflows/release-confix.yml (1)
19-19: Go version update approved.The update from Go 1.22 to 1.23 in the GitHub Actions workflow is correct and aligns with the PR objectives. Ensure that all dependencies and code are compatible with Go 1.23.
.github/workflows/release-cosmovisor.yml (1)
19-19: Go version update approved.The update from Go 1.22 to 1.23 in the GitHub Actions workflow is correct and aligns with the PR objectives. Ensure that all dependencies and code are compatible with Go 1.23.
.github/workflows/dependabot-update-all.yml (1)
20-20: Go version update approved.The update from Go 1.22 to 1.23 in the GitHub Actions workflow is correct and aligns with the PR objectives. Ensure that all dependencies and code are compatible with Go 1.23.
.github/workflows/lint.yml (1)
21-21: LGTM! Go version updated to 1.23.The upgrade to Go 1.23 in the GitHub Actions workflow is consistent with the PR objectives. Ensure that all dependencies and tools are compatible with this version.
.github/workflows/codeql-analysis.yml (1)
32-32: LGTM! Go version updated to 1.23.The upgrade to Go 1.23 in the CodeQL analysis workflow aligns with the PR objectives. No issues with the formatting change.
flake.nix (1)
57-57: LGTM! Go version updated to 1.23.The upgrade to Go 1.23 in the Nix flake configuration is consistent with the PR objectives. Ensure that all dependencies are compatible with this version.
.github/workflows/sims-nightly.yml (1)
24-24: Go version update approved.The Go version has been successfully updated from 1.22 to 1.23. This aligns with the PR objectives.
.github/workflows/software-compat-v052.yml (1)
21-21: Go version update approved.The Go version has been successfully updated from 1.22 to 1.23. This aligns with the PR objectives.
store/v2/go.mod (2)
3-3: Go version update approved.The Go version has been successfully updated from 1.21 to 1.23. This aligns with the PR objectives.
6-6: Verify the impact of updatingcosmossdk.io/coreto v1.0.0.The dependency on
cosmossdk.io/corehas been updated to a new major version. Ensure that any breaking changes are addressed in the codebase..github/workflows/sims-052.yml (1)
26-26: Consistent Go version update to 1.23.The Go version has been updated consistently across all job steps. This ensures that all simulations run with the latest Go version.
Also applies to: 40-40, 56-56, 72-72, 88-88
.github/workflows/sims-050.yml (1)
24-24: Consistent Go version update to 1.23.The Go version has been updated consistently across all job steps. This ensures that all simulations run with the latest Go version.
Also applies to: 36-36, 55-55, 74-74, 93-93
runtime/v2/go.mod (2)
3-3: Go version updated to 1.23.The Go version update aligns with the workflow changes, ensuring consistency across the project.
18-18: Verify the impact of updatingcosmossdk.io/coreto v1.0.0.The update to
cosmossdk.io/corev1.0.0 might introduce new features or breaking changes. Ensure that the codebase is compatible with this version.server/v2/go.mod (2)
3-3: Update to Go 1.23 approved.The Go version update to 1.23 is a standard upgrade to leverage new features and improvements. Ensure compatibility with all parts of the codebase.
18-18: Update to stable core version approved.The dependency update to
cosmossdk.io/core v1.0.0is a positive move towards using stable releases. Verify that this change does not introduce breaking changes elsewhere in the codebase.types/context_test.go (3)
21-21: Introduction ofdummyCtxKeyapproved.Using a named type for context keys improves type safety and prevents potential collisions. This is a good practice for context management.
142-142: Context key update inTestContextWithCustomapproved.The use of
dummyCtxKeyinTestContextWithCustomenhances clarity and robustness. Ensure that all tests pass with this change.
230-230: Context key update inTestUnwrapSDKContextapproved.The change to use
dummyCtxKeyinTestUnwrapSDKContextis a positive step towards better context management. Confirm that this does not affect test outcomes.x/accounts/defaults/lockup/go.mod (2)
3-3: Update to Go 1.23 approved.The Go version update to 1.23 is a standard upgrade to leverage new features and improvements. Ensure compatibility with all parts of the codebase.
7-7: Update to stable core version approved.The dependency update to
cosmossdk.io/core v1.0.0is a positive move towards using stable releases. Verify that this change does not introduce breaking changes elsewhere in the codebase.server/v2/cometbft/go.mod (1)
25-25: Verify impact ofcosmossdk.io/coreupdate to v1.0.0.Ensure that the update to a stable version of
cosmossdk.io/coredoes not introduce breaking changes or require updates in the codebase.x/auth/go.mod (2)
3-3: Verify compatibility with Go 1.23.Ensure that all code and dependencies in the
x/authmodule are compatible with Go 1.23. This update may introduce new features or deprecations.
8-8: Verify impact ofcosmossdk.io/coreupdate to v1.0.0.Ensure that the update to a stable version of
cosmossdk.io/coredoes not introduce breaking changes or require updates in thex/authmodule.x/consensus/go.mod (2)
3-3: Verify compatibility with Go 1.23.Ensure that all code and dependencies in the
x/consensusmodule are compatible with Go 1.23. This update may introduce new features or deprecations.
8-8: Verify impact ofcosmossdk.io/coreupdate to v1.0.0.Ensure that the update to a stable version of
cosmossdk.io/coredoes not introduce breaking changes or require updates in thex/consensusmodule.x/staking/go.mod (2)
3-3: Update to Go 1.23 looks good.The Go version has been updated to 1.23. Ensure compatibility with the rest of the codebase.
8-8: Update tocosmossdk.io/corev1.0.0 looks good.The core dependency has been updated to a stable release. Verify that this update does not introduce breaking changes.
x/bank/go.mod (2)
3-3: Update to Go 1.23 looks good.The Go version has been updated to 1.23. Ensure compatibility with the rest of the codebase.
8-8: Update tocosmossdk.io/corev1.0.0 looks good.The core dependency has been updated to a stable release. Verify that this update does not introduce breaking changes.
crypto/armor_test.go (2)
46-46: Correct usage oferrors.Is.The argument order in
errors.Ishas been corrected, which enhances error handling accuracy.
168-168: Correct usage oferrors.Is.The argument order in
errors.Ishas been corrected, which enhances error handling accuracy.x/nft/go.mod (2)
7-7: Updatecosmossdk.io/coredependency to v1.0.0.The dependency has been updated to a stable release. Ensure that any new features or changes in this version are compatible with your module.
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code and dependencies are compatible with this new version.
Verification successful
Go Version Update Verified
The update to Go 1.23 does not introduce any compatibility issues with deprecated features in the codebase. No usage of specific deprecated features was found.
- No usage of
os/exec: CommandContext.- No usage of
net/http: ServeContent.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of the codebase with Go 1.23. # Test: Check if there are any Go files using deprecated features. rg --type go -l 'deprecated' || echo "No deprecated features found."Length of output: 2215
Script:
#!/bin/bash # Description: Check for specific deprecated features in Go 1.23. # Define a list of deprecated features or functions in Go 1.23. deprecated_features=( "os/exec: CommandContext" "net/http: ServeContent" # Add more known deprecated features here. ) # Search for usage of deprecated features in the codebase. for feature in "${deprecated_features[@]}"; do rg --type go "$feature" || echo "No usage of $feature found." doneLength of output: 433
x/evidence/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code and dependencies are compatible with this new version.
8-8: Updatecosmossdk.io/coredependency to v1.0.0.The dependency has been updated to a stable release. Ensure that any new features or changes in this version are compatible with your module.
x/epochs/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code and dependencies are compatible with this new version.
8-8: Updatecosmossdk.io/coredependency to v1.0.0.The dependency has been updated to a stable release. Ensure that any new features or changes in this version are compatible with your module.
x/protocolpool/go.mod (2)
8-8: Updatecosmossdk.io/coreto v1.0.0.The core library has been upgraded to a stable release. Verify that all code using this library is compatible with the new version.
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure that all code and dependencies are compatible with this version.
x/slashing/go.mod (2)
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure compatibility with this version throughout the codebase.
8-8: Updatecosmossdk.io/coreto v1.0.0.The core library has been upgraded to a stable release. Verify compatibility with existing code.
x/circuit/go.mod (2)
8-8: Updatecosmossdk.io/coreto v1.0.0.The core library has been upgraded to a stable release. Verify that all code using this library is compatible with the new version.
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure that all code and dependencies are compatible with this version.
x/authz/go.mod (2)
3-3: Go version update to 1.23 approved.The Go version update aligns with the PR objectives to leverage improvements in Go 1.23.
7-7: Dependency update tocosmossdk.io/core v1.0.0approved.Transitioning to a stable release of
cosmossdk.io/coreis a positive change for stability and feature completeness.x/mint/go.mod (2)
3-3: Go version update to 1.23 approved.The Go version update is consistent with the PR objectives and should help leverage new features and optimizations.
8-8: Dependency update tocosmossdk.io/core v1.0.0approved.Updating to a stable release of
cosmossdk.io/coreis beneficial for stability and feature enhancements.x/distribution/go.mod (2)
3-3: Go version update to 1.23 approved.Updating the Go version is in line with the PR objectives and should provide performance improvements.
8-8: Dependency update tocosmossdk.io/core v1.0.0approved.Moving to a stable release of
cosmossdk.io/coreis a positive step for stability and functionality.x/gov/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code and dependencies are compatible with this version.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The
cosmossdk.io/coredependency has been upgraded to version 1.0.0. This is a major version change and may include breaking changes or new features. Verify compatibility and functionality.x/params/go.mod (2)
7-7: Upgradecosmossdk.io/coreto v1.0.0.The
cosmossdk.io/coredependency has been upgraded to version 1.0.0. This is a major version change and may include breaking changes or new features. Verify compatibility and functionality.
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code and dependencies are compatible with this version.
tools/cosmovisor/go.mod (1)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.4 to 1.23. Ensure that all code and dependencies are compatible with this version.
x/feegrant/go.mod (2)
3-3: Go version update approved.The Go version has been updated to 1.23. This change should bring improvements and new features.
8-8: Core dependency update approved.The
cosmossdk.io/coredependency has been updated to a stable releasev1.0.0. Verify that this update does not introduce any breaking changes.x/accounts/go.mod (2)
3-3: Go version update approved.The Go version has been updated to 1.23. This change should enhance performance and introduce new features.
8-8: Core dependency update approved.The
cosmossdk.io/coredependency has been updated to a stable releasev1.0.0. Ensure that this update does not introduce any breaking changes.x/accounts/defaults/multisig/go.mod (2)
3-3: Go version update approved.The Go version has been updated to 1.23. This change is expected to bring improvements and new features.
7-7: Core dependency update approved.The
cosmossdk.io/coredependency has been updated to a stable releasev1.0.0. Verify that this update does not introduce any breaking changes.client/v2/go.mod (2)
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure that all dependencies and code are compatible with this version.
7-7: Updatecosmossdk.io/coreto v1.0.0.The core dependency has been updated to v1.0.0. Ensure that this version is compatible with other dependencies and the current codebase.
go.mod (2)
1-1: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure that all dependencies and code are compatible with this version.
8-8: Updatecosmossdk.io/coreto v1.0.0.The core dependency has been updated to v1.0.0. Ensure that this version is compatible with other dependencies and the current codebase.
x/group/go.mod (2)
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23. Ensure that all dependencies and code are compatible with this version.
Verification successful
Go 1.23 Compatibility Verified
The codebase does not contain any deprecated or removed features that would cause compatibility issues with Go 1.23. The upgrade should proceed without problems.
- No instances of deprecated
ioutilfunctions were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if there are any compatibility issues with Go 1.23. # Test: List all Go files and check for compatibility issues. Expect: No issues. find . -name '*.go' -exec go vet {} +Length of output: 79
Script:
#!/bin/bash # Description: Search for Go version specific patterns or deprecated features that might indicate compatibility issues with Go 1.23. # Test: Search for deprecated or removed features in Go 1.23. rg 'context.TODO\(\)|ioutil\.ReadAll\(\)|ioutil\.WriteFile\(\)' --glob '*.go' -A 2Length of output: 5326
7-7: Updatecosmossdk.io/coreto v1.0.0.The core dependency has been updated to v1.0.0. Ensure that this version is compatible with other dependencies and the current codebase.
x/upgrade/go.mod (2)
3-3: Update Go Version to 1.23The Go version has been updated to 1.23. Ensure that all code is compatible with this version and take advantage of any new features or improvements.
7-7: Update Core Dependency to v1.0.0The
cosmossdk.io/coredependency has been updated to v1.0.0. Verify that the changes in this version are compatible with your code and update any affected areas.tests/go.mod (2)
3-3: Update Go Version to 1.23The Go version has been updated to 1.23. Ensure that all test code is compatible with this version and take advantage of any new features or improvements.
8-8: Update Core Dependency to v1.0.0The
cosmossdk.io/coredependency has been updated to v1.0.0. Verify that the changes in this version are compatible with your test code and update any affected areas.simapp/go.mod (2)
3-3: Update Go Version to 1.23The Go version has been updated to 1.23. Ensure that all code in the
simappmodule is compatible with this version and take advantage of any new features or improvements.
9-9: Update Core Dependency to v1.0.0The
cosmossdk.io/coredependency has been updated to v1.0.0. Verify that the changes in this version are compatible with your code in thesimappmodule and update any affected areas.simapp/v2/go.mod (2)
8-8: Verify core dependency update impact.The
cosmossdk.io/coredependency has been updated to v1.0.0. Ensure that there are no breaking changes affecting the codebase.
3-3: Verify Go version compatibility.The Go version has been updated to 1.23. Ensure that this version is compatible with all dependencies and the codebase.
Verification successful
Go Version Compatibility Verified
The Go version 1.23 specified in
go.modappears compatible with the current dependencies and codebase. No explicit compatibility issues were identified. However, ensure to monitor dependency updates for any potential issues.
- The codebase includes comments and build tags for various Go versions, indicating maintained backward compatibility.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any Go version compatibility issues in the codebase. # Test: Search for Go version compatibility issues. Expect: No issues found. rg --type go 'go[[:space:]]+1\.23'Length of output: 168
Script:
#!/bin/bash # Check the go.mod file for dependencies that might have compatibility issues with Go 1.23 cat simapp/v2/go.mod # Search for any Go version-specific features or directives in the codebase rg --type go 'go[[:space:]]*1\.[0-9]+'Length of output: 17012
.github/workflows/test.yml (2)
23-23: LGTM! Consistent Go version update.The Go version has been consistently updated to 1.23 across all jobs. This ensures uniformity in the CI/CD pipeline.
Also applies to: 57-57, 91-91, 122-122, 156-156, 250-250, 283-283, 314-314, 344-344, 488-488, 518-518, 554-554, 582-582, 624-624, 655-655, 686-686, 717-717, 748-748, 816-816, 885-885, 916-916, 939-939, 962-962, 993-993, 1024-1024, 1055-1055, 1086-1086, 1117-1117, 1148-1148, 1178-1178, 1208-1208, 1238-1238, 1268-1268, 1299-1299, 1330-1330, 1361-1361, 1392-1392, 1423-1423, 1454-1454, 1485-1485, 1516-1516
831-831: Verify directory path change.The directory path in the command has been changed from
cd store/v2tocd ../... Ensure this change does not affect the workflow execution.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
Files selected for processing (69)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/dependabot-update-all.yml (1 hunks)
- .github/workflows/dependencies-review.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/pr-go-mod-tidy-mocks.yml (2 hunks)
- .github/workflows/release-confix.yml (1 hunks)
- .github/workflows/release-cosmovisor.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/sims-047.yml (5 hunks)
- .github/workflows/sims-050.yml (5 hunks)
- .github/workflows/sims-052.yml (5 hunks)
- .github/workflows/sims-nightly.yml (1 hunks)
- .github/workflows/sims.yml (5 hunks)
- .github/workflows/software-compat-v052.yml (1 hunks)
- .github/workflows/test.yml (42 hunks)
- .github/workflows/v2-test.yml (4 hunks)
- Dockerfile (1 hunks)
- client/v2/go.mod (1 hunks)
- collections/go.mod (1 hunks)
- contrib/devtools/Dockerfile (1 hunks)
- contrib/images/simd-dlv/Dockerfile (1 hunks)
- contrib/images/simd-env/Dockerfile (1 hunks)
- core/go.mod (1 hunks)
- core/testing/go.mod (1 hunks)
- crypto/armor_test.go (2 hunks)
- flake.nix (1 hunks)
- go.mod (1 hunks)
- go.work.example (1 hunks)
- indexer/postgres/tests/go.mod (2 hunks)
- orm/go.mod (1 hunks)
- runtime/v2/go.mod (2 hunks)
- schema/testing/go.mod (2 hunks)
- scripts/build/linting.mk (1 hunks)
- scripts/build/protobuf.mk (1 hunks)
- server/v2/appmanager/go.mod (1 hunks)
- server/v2/cometbft/go.mod (2 hunks)
- server/v2/go.mod (2 hunks)
- server/v2/stf/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- store/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- tests/systemtests/go.mod (1 hunks)
- tools/confix/go.mod (1 hunks)
- tools/cosmovisor/go.mod (1 hunks)
- types/context_test.go (3 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/go.mod (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/tx/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (14)
- .github/workflows/build.yml
- .github/workflows/pr-go-mod-tidy-mocks.yml
- .github/workflows/sims-052.yml
- .github/workflows/sims-nightly.yml
- .github/workflows/v2-test.yml
- flake.nix
- go.work.example
- orm/go.mod
- scripts/build/protobuf.mk
- server/v2/stf/go.mod
- tests/systemtests/go.mod
- tools/cosmovisor/go.mod
- x/slashing/go.mod
- x/tx/go.mod
Additional context used
Path-based instructions (3)
types/context_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"crypto/armor_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (108)
server/v2/appmanager/go.mod (2)
7-7: ```shell
#!/bin/bashList all function definitions in types.go
rg --type go --line-number --only-matching --regexp 'func\s+\w+' server/v2/appmanager/types.go
List all function definitions in appmanager.go
rg --type go --line-number --only-matching --regexp 'func\s+\w+' server/v2/appmanager/appmanager.go
List all function definitions in appmanager_builder.go
rg --type go --line-number --only-matching --regexp 'func\s+\w+' server/v2/appmanager/appmanager_builder.go
--- `3-3`: **Verify compatibility with Go 1.23.** Ensure that all features and dependencies used in the module are compatible with Go 1.23. </blockquote></details> <details> <summary>core/testing/go.mod (2)</summary><blockquote> `3-3`: **Verify compatibility with Go 1.23.** Ensure that all features and dependencies used in the module are compatible with Go 1.23. ```shell #!/bin/bash # Description: Check for compatibility issues with Go 1.23. # Test: List all Go files and check for deprecated or incompatible features. rg --type go 'deprecated|incompatible' core/testing/
8-8: Verify compatibility withcosmossdk.io/corev1.0.0.The upgrade to a stable version might introduce breaking changes. Verify that the module is compatible with the new version of
cosmossdk.io/core.#!/bin/bash # Description: Check for compatibility issues with `cosmossdk.io/core` v1.0.0. # Test: Search for the usage of `cosmossdk.io/core` and ensure compatibility. rg --type go 'cosmossdk.io/core' core/testing/core/go.mod (1)
6-6: Verify compatibility with Go 1.23.Ensure that all features and dependencies used in the module are compatible with Go 1.23.
#!/bin/bash # Description: Check for compatibility issues with Go 1.23. # Test: List all Go files and check for deprecated or incompatible features. rg --type go 'deprecated|incompatible' core/schema/testing/go.mod (1)
3-3: Verify compatibility with Go 1.23.The Go version has been updated to 1.23. Ensure that all dependencies and code are compatible with this version.
collections/go.mod (2)
3-3: Verify compatibility with Go 1.23.The Go version has been updated to 1.23. Ensure that all dependencies and code are compatible with this version.
6-6: ```shell
#!/bin/bashDescription: Search for changelog or release notes for
cosmossdk.io/corev1.0.0 to identify breaking changes.Find files that might contain changelog or release notes
fd -H -I -i changelog -e md -e rst -e txt
fd -H -I -i release -e md -e rst -e txt</blockquote></details> <details> <summary>scripts/build/linting.mk (1)</summary><blockquote> `1-1`: **Verify compatibility with `golangci-lint` v1.60.1.** The `golangci-lint` version has been updated to v1.60.1. Ensure that the linter configuration and code are compatible with this version. ```shell #!/bin/bash # Description: Verify compatibility with `golangci-lint` v1.60.1. # Test: Run the linter to check for any new issues. make lintcontrib/images/simd-dlv/Dockerfile (1)
1-1: Go version update approved.The Dockerfile has been successfully updated to use Go 1.23, aligning with the PR's objective. No further changes are necessary.
.github/workflows/dependencies-review.yml (1)
17-17: Go version update approved.The GitHub Actions workflow has been updated to use Go 1.23. This change is consistent with the PR's objective and should enhance compatibility with the latest Go features.
indexer/postgres/tests/go.mod (1)
3-3: Go version update approved.The Go module file has been updated to specify Go 1.23, which aligns with the PR's objective. The dependencies remain unchanged.
contrib/devtools/Dockerfile (1)
5-6: Update of base images approved.The base images for
bufbuild/bufandgolanghave been updated to newer versions. This aligns with the PR objectives to use Go 1.23. Ensure that these changes are tested to confirm compatibility..github/workflows/release-confix.yml (1)
19-19: Go version update approved.The Go version in the GitHub Actions workflow has been updated to 1.23. This change aligns with the PR objectives and ensures the workflow uses the latest Go features and improvements.
.github/workflows/release-cosmovisor.yml (1)
19-19: Go version update approved.The Go version in the GitHub Actions workflow has been updated to 1.23. This change aligns with the PR objectives and ensures the workflow uses the latest Go features and improvements.
.github/workflows/dependabot-update-all.yml (1)
20-20: Update to Go 1.23 approved.The Go version update from 1.22 to 1.23 in the workflow file is appropriate and aligns with the PR's objective.
.github/workflows/lint.yml (1)
21-21: Update to Go 1.23 approved.The Go version update from 1.22.2 to 1.23 in the linting workflow file is appropriate and aligns with the PR's objective.
.github/workflows/release.yml (1)
23-23: Update to Go 1.23 approved.The Go version update from 1.22 to 1.23 in the release workflow file is appropriate and aligns with the PR's objective.
.github/workflows/codeql-analysis.yml (1)
32-32: Go version updated to 1.23.The Go version has been successfully updated in the CodeQL analysis workflow. Ensure that this update is consistent across all relevant workflows and configuration files.
contrib/images/simd-env/Dockerfile (1)
1-1: Base image updated to Go 1.23-alpine.The Dockerfile now uses the
golang:1.23-alpinebase image. Verify that all dependencies and applications are compatible with this Go version..github/workflows/software-compat-v052.yml (1)
21-21: Go version updated to 1.23.The Go version has been successfully updated in the software compatibility workflow. Ensure that this update is consistent across all relevant workflows and configuration files.
Dockerfile (1)
15-15: Upgrade to Go 1.23 approved.The base image has been updated to
golang:1.23-alpine, aligning with the PR's objective to upgrade the Go version. Ensure compatibility with this new version in your application.store/v2/go.mod (2)
3-3: Go version upgrade to 1.23 approved.The Go version has been updated to 1.23, consistent with the PR's objectives.
6-6: ```shell
#!/bin/bashDescription: Search for common changelog or release note files in the repository.
Corrected command to find potential changelog or release note files.
fd --type f 'CHANGELOG|RELEASE|HISTORY|NOTES'
</blockquote></details> <details> <summary>.github/workflows/sims.yml (1)</summary><blockquote> `24-24`: **Go version update to 1.23 approved across workflow.** The Go version has been consistently updated to 1.23 in all relevant jobs, aligning with the PR's objectives. Also applies to: 36-36, 50-50, 64-64, 78-78 </blockquote></details> <details> <summary>.github/workflows/sims-047.yml (1)</summary><blockquote> `24-24`: **Go version update approved.** The Go version has been updated to 1.23 across multiple steps in the workflow. This ensures the workflow benefits from the latest features and optimizations available in Go 1.23. Also applies to: 36-36, 55-55, 74-74, 93-93 </blockquote></details> <details> <summary>.github/workflows/sims-050.yml (1)</summary><blockquote> `24-24`: **Go version update approved.** The Go version has been updated to 1.23 across multiple steps in the workflow. This ensures the workflow benefits from the latest features and optimizations available in Go 1.23. Also applies to: 36-36, 55-55, 74-74, 93-93 </blockquote></details> <details> <summary>runtime/v2/go.mod (2)</summary><blockquote> `3-3`: **Go version update approved.** The Go version has been updated to 1.23, aligning with the PR objectives to leverage improvements in the latest Go release. --- `18-18`: **Verify the impact of upgrading `cosmossdk.io/core` to v1.0.0.** The dependency has been upgraded to a stable version, which may introduce breaking changes or new features. Ensure that the codebase is compatible with this version. </blockquote></details> <details> <summary>server/v2/go.mod (2)</summary><blockquote> `3-3`: ```shell #!/bin/bash # Description: Check for actual Go 1.23 deprecated or removed features. # Replace 'actualDeprecatedFeature1' and 'actualDeprecatedFeature2' with real features from Go 1.23 release notes. rg --type go 'actualDeprecatedFeature1|actualDeprecatedFeature2' --ignore-case
18-18: Dependency update to stable version v1.0.0.The
cosmossdk.io/coredependency has been updated tov1.0.0. Ensure that this update does not introduce breaking changes that affect the module.types/context_test.go (3)
21-21: IntroducedummyCtxKeyfor context safety.The introduction of
dummyCtxKeyenhances type safety by avoiding potential key collisions when using context values. This is a good practice for maintaining clarity and safety in context usage.
142-142: UsedummyCtxKeyinTestContextWithCustom.The use of
dummyCtxKeyinstead of an anonymous struct for context keys improves clarity and reduces the risk of key collisions inTestContextWithCustom.
230-230: UsedummyCtxKeyinTestUnwrapSDKContext.The change to use
dummyCtxKeyfor context keys inTestUnwrapSDKContextenhances type safety and consistency across tests.tools/confix/go.mod (1)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that the codebase is compatible with any new features or changes introduced in this version.
#!/bin/bash # Description: Verify compatibility with Go 1.23. # Test: Check if any files use deprecated features removed in Go 1.23. rg --type go 'deprecated|removed' --ignore-casex/accounts/defaults/lockup/go.mod (2)
7-7: Updatecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been updated to a stable release version v1.0.0. This may introduce new features or breaking changes. Verify that the module remains compatible with this update.
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23, which may introduce new language features or optimizations. Ensure that the codebase is compatible with this version.
server/v2/cometbft/go.mod (2)
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23, which may introduce new language features or optimizations. Ensure that the codebase is compatible with this version.
#!/bin/bash # Description: Verify compatibility with Go 1.23. # Test: Check if any Go files are incompatible with Go 1.23. # Expect: No incompatible code. go vet ./...
25-25: Updatecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been updated to a stable release version v1.0.0. This may introduce new features or breaking changes. Verify that the module remains compatible with this update.#!/bin/bash # Description: Verify compatibility with `cosmossdk.io/core` v1.0.0. # Test: Run tests to ensure compatibility. # Expect: All tests pass. go test ./...x/auth/go.mod (2)
3-3: Upgrade Go version to 1.23.The Go version has been updated to 1.23, which may introduce new language features or optimizations. Ensure that the codebase is compatible with this version.
#!/bin/bash # Description: Verify compatibility with Go 1.23. # Test: Check if any Go files are incompatible with Go 1.23. # Expect: No incompatible code. go vet ./...
8-8: Updatecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been updated to a stable release version v1.0.0. This may introduce new features or breaking changes. Verify that the module remains compatible with this update.#!/bin/bash # Description: Verify compatibility with `cosmossdk.io/core` v1.0.0. # Test: Run tests to ensure compatibility. # Expect: All tests pass. go test ./...x/consensus/go.mod (2)
3-3: Update Go version to 1.23.The Go version update to 1.23 is consistent with the PR objectives and should bring in new features and optimizations.
8-8: Updatecosmossdk.io/coredependency to v1.0.0.The update to a stable version of the core library indicates improved stability and functionality.
Ensure that there are no compatibility issues introduced by this update.
x/staking/go.mod (2)
3-3: Update Go version to 1.23.The Go version update to 1.23 is consistent with the PR objectives and should bring in new features and optimizations.
8-8: Updatecosmossdk.io/coredependency to v1.0.0.The update to a stable version of the core library indicates improved stability and functionality.
Ensure that there are no compatibility issues introduced by this update.
#!/bin/bash # Description: Verify compatibility of `cosmossdk.io/core` v1.0.0 with the codebase. # Test: Search for usages of `cosmossdk.io/core` in the codebase to ensure compatibility with v1.0.0. rg --type go 'cosmossdk\.io/core' -A 5x/bank/go.mod (2)
3-3: Update Go version to 1.23.The Go version update to 1.23 is consistent with the PR objectives and should bring in new features and optimizations.
8-8: Updatecosmossdk.io/coredependency to v1.0.0.The update to a stable version of the core library indicates improved stability and functionality.
Ensure that there are no compatibility issues introduced by this update.
#!/bin/bash # Description: Verify compatibility of `cosmossdk.io/core` v1.0.0 with the codebase. # Test: Search for usages of `cosmossdk.io/core` in the codebase to ensure compatibility with v1.0.0. rg --type go 'cosmossdk\.io/core' -A 5crypto/armor_test.go (2)
46-46: Correct usage oferrors.Is.The change correctly updates the usage of
errors.Isto compare errors accurately.
168-168: Correct usage oferrors.Is.The change correctly updates the usage of
errors.Isto compare errors accurately.x/nft/go.mod (2)
3-3: Go version updated to 1.23.The update to Go 1.23 is consistent with the PR objectives and may bring performance improvements and new features.
7-7: Update to stable core versionv1.0.0.The upgrade to a stable release may enhance stability and functionality but could also introduce breaking changes. Ensure compatibility with the module.
x/evidence/go.mod (2)
3-3: Go version updated to 1.23.The update to Go 1.23 is consistent with the PR objectives and may bring performance improvements and new features.
8-8: Update to stable core versionv1.0.0.The upgrade to a stable release may enhance stability and functionality but could also introduce breaking changes. Ensure compatibility with the module.
x/epochs/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure that all code is compatible with the new Go version and take advantage of any new features or improvements.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been upgraded to a stable release version v1.0.0. This transition should enhance stability and functionality. Verify that all usages of this dependency are compatible with the new version.x/protocolpool/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure compatibility with the new Go version and leverage any improvements.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been upgraded to a stable release version v1.0.0. This should improve stability and functionality. Verify compatibility with the new version.x/circuit/go.mod (4)
3-3: Update Go version to 1.23.The Go version has been updated from 1.22.2 to 1.23. Ensure compatibility with the new Go version and leverage any improvements.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been upgraded to a stable release version v1.0.0. This should improve stability and functionality. Verify compatibility with the new version.
9-9: Introducecosmossdk.io/depinjectat v1.0.0.The
cosmossdk.io/depinjectdependency has been added at version v1.0.0. Ensure that its introduction is necessary and verify its integration within the module.
10-10: Updatecosmossdk.io/errorsto v1.0.1.The
cosmossdk.io/errorsdependency has been updated to version v1.0.1. Ensure compatibility with the updated version and verify any changes in error handling.x/authz/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23, which may include new language features, performance improvements, or bug fixes. Ensure that the codebase is compatible with this version.
7-7: Upgradecosmossdk.io/coreto v1.0.0.The
cosmossdk.io/coredependency has been upgraded to a stable release, v1.0.0. This change may introduce new features or improvements. Verify compatibility with other modules.x/mint/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23, which may include new language features, performance improvements, or bug fixes. Ensure that the codebase is compatible with this version.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The
cosmossdk.io/coredependency has been upgraded to a stable release, v1.0.0. This change may introduce new features or improvements. Verify compatibility with other modules.x/distribution/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23, which may include new language features, performance improvements, or bug fixes. Ensure that the codebase is compatible with this version.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The
cosmossdk.io/coredependency has been upgraded to a stable release, v1.0.0. This change may introduce new features or improvements. Verify compatibility with other modules.x/gov/go.mod (2)
3-3: Go version updated to 1.23.The Go version has been updated from 1.22.2 to 1.23. This change is consistent with the PR objective to use the latest Go version. Ensure that all parts of the codebase are compatible with Go 1.23.
8-8: ```shell
#!/bin/bashDescription: Search for changelog or release notes files that might contain information about
cosmossdk.io/corev1.0.0.Look for files commonly used for changelogs or release notes
fd -e md -e rst -e txt -i 'changelog|release' | xargs rg -i 'cosmossdk.io/core.*v1.0.0'
</blockquote></details> <details> <summary>x/params/go.mod (2)</summary><blockquote> `3-3`: **Go version updated to 1.23.** The Go version has been updated from 1.22.2 to 1.23. This aligns with the PR's goal of using the latest Go version. Ensure compatibility across the module with Go 1.23. --- `7-7`: **Core dependency updated to v1.0.0.** The `cosmossdk.io/core` dependency has been upgraded to version 1.0.0. This major version change could introduce new features or breaking changes. Verify compatibility with this version. </blockquote></details> <details> <summary>x/feegrant/go.mod (2)</summary><blockquote> `3-3`: **Go version updated to 1.23.** The Go version has been updated from 1.22.2 to 1.23. This update is part of the PR's objective to use the latest Go version. Ensure that the module is compatible with Go 1.23. --- `8-8`: **Core dependency updated to v1.0.0.** The `cosmossdk.io/core` dependency has been upgraded to version 1.0.0. This major version change could introduce new features or breaking changes. Verify compatibility with this version. </blockquote></details> <details> <summary>x/accounts/go.mod (2)</summary><blockquote> `3-3`: **Go version update to 1.23.** The Go version has been updated to 1.23, which may include new language features and performance improvements. Ensure compatibility with existing code. --- `8-8`: **Core dependency update to v1.0.0.** The `cosmossdk.io/core` dependency has been upgraded to v1.0.0. This major version change might introduce breaking changes or new features. Verify compatibility with the rest of the codebase. </blockquote></details> <details> <summary>x/accounts/defaults/multisig/go.mod (2)</summary><blockquote> `3-3`: **Go version update to 1.23.** The Go version has been updated to 1.23, which may include new language features and performance improvements. Ensure compatibility with existing code. --- `7-7`: **Core dependency update to v1.0.0.** The `cosmossdk.io/core` dependency has been upgraded to v1.0.0. This major version change might introduce breaking changes or new features. Verify compatibility with the rest of the codebase. ```shell #!/bin/bash # Description: Verify compatibility of the updated core dependency with the codebase. # Test: Search for usage of `cosmossdk.io/core` to identify potential breaking changes. rg --type go 'cosmossdk\.io/core'client/v2/go.mod (2)
3-3: Go version update to 1.23.The Go version has been updated to 1.23, which may include new language features and performance improvements. Ensure compatibility with existing code.
7-7: Core dependency update to v1.0.0.The
cosmossdk.io/coredependency has been upgraded to v1.0.0. This major version change might introduce breaking changes or new features. Verify compatibility with the rest of the codebase.#!/bin/bash # Description: Verify compatibility of the updated core dependency with the codebase. # Test: Search for usage of `cosmossdk.io/core` to identify potential breaking changes. rg --type go 'cosmossdk\.io/core'go.mod (2)
1-1: Go version update approved.The Go version update to 1.23 is consistent with the PR objectives and should bring performance improvements and new features.
8-8: Dependency update approved.Updating
cosmossdk.io/coreto v1.0.0 is a positive change towards using a stable release.x/group/go.mod (2)
3-3: Go version update approved.The Go version update to 1.23 is consistent with the PR objectives and should enhance performance and introduce new features.
7-7: Dependency update approved.Updating
cosmossdk.io/coreto v1.0.0 is a positive step towards using a stable release.x/upgrade/go.mod (2)
3-3: Go version update approved.The Go version update to 1.23 aligns with the PR objectives and should provide performance improvements and new features.
7-7: Dependency updates approved.Updating
cosmossdk.io/coreto v1.0.0 andcosmossdk.io/depinjectto v1.0.0 are positive steps towards using stable releases.tests/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that all code is compatible with any new features or changes introduced in this version.
8-8: ```shell
#!/bin/bashSearch for test files or results related to
cosmossdk.io/coreto check for compatibility with v1.0.0.fd -I -e go -e txt -e log | xargs rg 'cosmossdk.io/core'
</blockquote></details> <details> <summary>simapp/go.mod (2)</summary><blockquote> `3-3`: **Update Go version to 1.23.** The Go version has been updated to 1.23. Ensure that all code is compatible with any new features or changes introduced in this version. --- `9-9`: **Upgrade `cosmossdk.io/core` to v1.0.0.** The dependency `cosmossdk.io/core` has been upgraded to v1.0.0. Verify that the codebase is compatible with any breaking changes or new features introduced in this stable release. ```shell #!/bin/bash # Description: Verify compatibility with `cosmossdk.io/core` v1.0.0. # Test: Check for any deprecated or changed APIs in `cosmossdk.io/core`. rg 'cosmossdk.io/core' --type gosimapp/v2/go.mod (2)
3-3: Update Go version to 1.23.The Go version has been updated to 1.23. Ensure that all code is compatible with any new features or changes introduced in this version.
8-8: Upgradecosmossdk.io/coreto v1.0.0.The dependency
cosmossdk.io/corehas been upgraded to v1.0.0. Verify that the codebase is compatible with any breaking changes or new features introduced in this stable release.#!/bin/bash # Description: Verify compatibility with `cosmossdk.io/core` v1.0.0. # Test: Check for any deprecated or changed APIs in `cosmossdk.io/core`. rg 'cosmossdk.io/core' --type go.github/workflows/test.yml (17)
23-23: Go version updated to 1.23.This change aligns with the PR objective of upgrading to the latest Go version.
57-57: Go version updated to 1.23.This update is consistent with the PR's goal to use the latest Go version.
91-91: Go version updated to 1.23.This update is consistent with the goal of the PR to upgrade the Go version.
122-122: Go version updated to 1.23.This update aligns with the PR's objective to upgrade the Go version.
156-156: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade to the latest Go version.
250-250: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
283-283: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade the Go version.
314-314: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
344-344: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade the Go version.
488-488: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
518-518: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade the Go version.
554-554: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
582-582: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade the Go version.
624-624: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
655-655: Go version updated to 1.23.This change is consistent with the PR's goal to upgrade the Go version.
686-686: Go version updated to 1.23.This update aligns with the PR's objective to use the latest Go version.
831-831: Verify thenix developcommand path change.The command path for
nix develophas been changed from..to../... Ensure this change aligns with the intended environment setup and does not affect dependency resolution or testing.
(cherry picked from commit 8193308) # Conflicts: # .github/workflows/sims-052.yml # .github/workflows/software-compat-v052.yml # client/v2/go.mod # collections/go.mod # core/go.mod # core/testing/go.mod # go.mod # indexer/postgres/tests/go.mod # orm/go.mod # runtime/v2/go.mod # schema/testing/go.mod # server/v2/appmanager/go.mod # server/v2/cometbft/go.mod # server/v2/go.mod # server/v2/stf/go.mod # simapp/go.mod # simapp/v2/go.mod # store/v2/go.mod # tests/go.mod # tools/cosmovisor/go.mod # x/accounts/defaults/lockup/go.mod # x/accounts/defaults/multisig/go.mod # x/accounts/go.mod # x/auth/go.mod # x/authz/go.mod # x/bank/go.mod # x/circuit/go.mod # x/consensus/go.mod # x/distribution/go.mod # x/epochs/go.mod # x/evidence/go.mod # x/feegrant/go.mod # x/gov/go.mod # x/group/go.mod # x/mint/go.mod # x/nft/go.mod # x/params/go.mod # x/protocolpool/go.mod # x/slashing/go.mod # x/staking/go.mod # x/tx/go.mod # x/upgrade/go.mod
* main: (76 commits) docs: more app v2 renaming (#21336) chore: update link in disclaimer (#21339) refactor(x/distribution): audit QA (#21316) docs: rename app v2 to app di when talking about runtime v0 (#21329) feat(schema): specify JSON mapping (#21243) fix(x/authz): bring back msg response in `DispatchActions` (#21044) chore: fix all lint issue since golangci-lint bump (#21326) refactor(x/mint): v0.52 audit x/mint (#21301) chore: fix spelling errors (#21327) feat: export genesis in simapp v2 (#21199) fix(baseapp)!: Halt at height now does not produce the halt height block (#21256) refactor(scripts): remove unused variable (#21320) chore(schema/testing): upgrade to go 1.23 iterators (#21282) chore: readmes + upgrading docs (#21271) feat(client): add auto cli for node service (#21074) ci: fix github workflow vulnerable to script injection (#21304) build(deps): Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.0 (#21307) build(deps): use Go 1.23 instead of Go 1.22 (#21280) refactor(x/auth): audit x/auth changes (#21146) chore: remove todo: "abstract out staking message back to staking" (#21266) ...
Description
Use Go 1.23 where Go 1.22 was used.
Go mod with lower minimum version stay unchanged (on purpose, as those modules should be compatible with older SDK versions).
todos:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Dependency Updates
cosmossdk.io/coredependency to version 1.0.0 in multiple modules, indicating a transition to a stable release with possible breaking changes or new functionalities.Docker Image Updates
golang:1.23-alpine, enhancing compatibility and performance.