-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove x/exp dep (backport #21281) #21358
refactor: remove x/exp dep (backport #21281) #21358
Conversation
(cherry picked from commit 6f30de3) # Conflicts: # runtime/v2/app.go # runtime/v2/go.mod # runtime/v2/manager.go # server/v2/api/grpc/server.go # server/v2/go.mod # server/v2/stf/core_event_service.go # server/v2/stf/go.mod # store/v2/commitment/store.go # store/v2/go.mod # store/v2/go.sum # tests/systemtests/go.mod # tools/confix/go.mod # x/staking/go.mod
Cherry-pick of 6f30de3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
Closes: #19892
Finally! Came to hate that package because it has bitten us.
We can finally break freeeee.
Blocked on #21280
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!
in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
slices
package for improved performance and clarity.Bug Fixes
Refactor
NewModuleManager
function to sort module keys prior to further operations.Style
slices
package instead of external dependencies, enhancing clarity in the codebase.This is an automatic backport of pull request #21281 done by [Mergify](https://mergify.com).