Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Governance BFT Time #2217

Merged
merged 6 commits into from
Sep 7, 2018
Merged

R4R: Governance BFT Time #2217

merged 6 commits into from
Sep 7, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Sep 3, 2018

closes #2195

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #2217 into develop will increase coverage by 0.19%.
The diff coverage is 90.9%.

@@             Coverage Diff             @@
##           develop    #2217      +/-   ##
===========================================
+ Coverage    63.98%   64.18%   +0.19%     
===========================================
  Files          140      140              
  Lines         8608     8566      -42     
===========================================
- Hits          5508     5498      -10     
+ Misses        2723     2692      -31     
+ Partials       377      376       -1

@sunnya97 sunnya97 changed the title Sunny/gov bft time R4R: Governance BFT Time Sep 3, 2018
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, a few questions.

docs/spec/governance/state.md Show resolved Hide resolved
docs/spec/governance/state.md Show resolved Hide resolved
@cwgoes cwgoes merged commit 94b86f8 into develop Sep 7, 2018
@cwgoes cwgoes deleted the sunny/gov-bft-time branch September 7, 2018 06:53
cwgoes added a commit that referenced this pull request Sep 7, 2018
This reverts commit 94b86f8, reversing
changes made to 2a4edcc.
@cwgoes cwgoes restored the sunny/gov-bft-time branch September 7, 2018 15:33
@cwgoes
Copy link
Contributor

cwgoes commented Sep 7, 2018

@sunnya97 Looks like this made develop non-deterministic (CI didn't catch on this PR for some reason) - any ideas?

alexanderbez pushed a commit that referenced this pull request Sep 18, 2018
@ValarDragon ValarDragon deleted the sunny/gov-bft-time branch September 23, 2018 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance Periods to use BFT Time
5 participants