Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge PR #2217: Governance BFT Time" #2263

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Sep 7, 2018

This reverts commit 94b86f8, reversing
changes made to 2a4edcc.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This reverts commit 94b86f8, reversing
changes made to 2a4edcc.
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Issue reference: #2264

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #2263 into develop will increase coverage by <.01%.
The diff coverage is 91.3%.

@@             Coverage Diff             @@
##           develop    #2263      +/-   ##
===========================================
+ Coverage    63.73%   63.73%   +<.01%     
===========================================
  Files          140      140              
  Lines         8641     8642       +1     
===========================================
+ Hits          5507     5508       +1     
  Misses        2755     2755              
  Partials       379      379

@cwgoes cwgoes merged commit d1dc6cc into develop Sep 7, 2018
@cwgoes cwgoes deleted the cwgoes/revert-governance-bft-time branch September 7, 2018 15:33
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
change the number of validators from 150 to 175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants