Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/bank): use cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec #23304

Closed
wants to merge 1 commit into from

Conversation

hungdinh82
Copy link

@hungdinh82 hungdinh82 commented Jan 10, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation

    • Updated import paths for codec package from github.com/cosmos/cosmos-sdk/codec to cosmossdk.io/core/codec
    • Enhanced documentation for interface encoding and state serialization in Cosmos SDK
    • Introduced new interfaces for improved codec and interface management
  • Refactor

    • Modernized codec and interface handling approaches
    • Improved compatibility with Protocol Buffers and state encoding strategies

@hungdinh82 hungdinh82 requested a review from a team as a code owner January 10, 2025 04:30
Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

📝 Walkthrough

Walkthrough

This pull request focuses on updating import paths for the codec package across multiple documentation files in the Cosmos SDK. The changes primarily involve replacing the import statement from github.com/cosmos/cosmos-sdk/codec to cosmossdk.io/core/codec. The modifications affect documentation in the collections README, architecture decision record (ADR) for protobuf state encoding, and user interaction documentation. The changes maintain the existing functionality while updating the package import references.

Changes

File Change Summary
collections/README.md Updated codec import path and refined documentation for codec usage with collections
docs/architecture/adr-019-protobuf-state-encoding.md Introduced new interfaces (InterfaceRegistry, InterfaceUnpacker) and methods for improved state encoding
docs/user/run-node/02-interact-node.md Updated codec import path in Go code snippets

Possibly related PRs

Suggested labels

C:x/bank, C:collections, T:Docs

Suggested reviewers

  • julienrbrt
  • tac0turtle
  • sontrinh16
  • kocubinski

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 517839b and 1beb134.

📒 Files selected for processing (3)
  • collections/README.md (8 hunks)
  • docs/architecture/adr-019-protobuf-state-encoding.md (1 hunks)
  • docs/user/run-node/02-interact-node.md (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • docs/user/run-node/02-interact-node.md
  • collections/README.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/architecture/adr-019-protobuf-state-encoding.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
docs/architecture/adr-019-protobuf-state-encoding.md (1)

232-232: LGTM! Import path updated correctly.

The import path has been updated from github.com/cosmos/cosmos-sdk/codec to cosmossdk.io/core/codec, which aligns with the PR objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -191,7 +191,7 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/metadata"

"github.com/cosmos/cosmos-sdk/codec"
"cosmossdk.io/core/codec"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do this replacement in the documents, please check if this is correct.

e.g.: If you do replacement here, codec.NewProtoCodec in line 212 would throw error

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me, I have fixed it.

@hungdinh82 hungdinh82 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants