feat: Upgrade root module to CometBFT v1.0.1 #24528

fcecin · 2025-04-15T20:36:34Z

Description

This PR is part of #24114

Summary:

fix go.mod with comet v1 upgraded dependencies:
fix tendermint -> cometbft.v1 imports & proto field names
regenerated gogo proto code (pb.go files) tendermint -> cometbft
doc fixes for cometbft v1
fix more ABCI enum values & types to comet 1 format
fix several callsites to satisfy the new Comet 1 API, following mostly what SDK v52 did to satisfy Comet 1
revert addition of internal/conv/comet.go (unnecessary)
fix x/consensus/keeper/keeper_test.go and ToProtoConsensusParams() to handle new ABCI consensus params API
regen golden x/genutil/types/testdata/app_genesis.json which adds new ABCI consensus params for Comet v1
fix TestABCI_CheckTx assuming CHECK_TX_TYPE_CHECK is 0
fix baseapp ABCI & ABCI tests to handle FeatureParams

Description:

This upgrade has been mostly guided by SDK v52 changes done to port v52 to CometBFT v1.0.1, with the assumption that if it worked for SDK v52, it should still work now. So in a sense this is a backport of the SDK v52's Comet v1 port of the root module. Only the changes that were necessary to get the SDK working with Comet v1 were ported.

Tests:

Testing that involve modules that were not yet upgraded to Comet v1 will not work. Unit tests for the root module pass. e.g. go test -mod=readonly -tags="cgo ledger test_ledger_mock norace" -count=1 ./.... When all tests are enabled, we can act on their failures and fix whatever issues remain.

Other CI failures:

There are other CI failures also pointing to modules that have not yet ported to Comet v1 in this PR (such as x/evidence). Like the tests, these CI jobs won't pass until the offending modules are ported.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

- fix go.mod with comet v1 upgraded dependencies: api, core, x/tx - fix go.mod: add temporary replace to ./store (comet v1 upgraded) - fix tendermint -> cometbft.v1 imports & proto field names - regenerated gogo proto code (pb.go files) tendermint -> cometbft - doc fixes for cometbft v1 - misc Go API fixes (incomplete, WIP)

ironbird-prod · 2025-04-15T20:36:37Z

Ironbird - launch a network

To use Ironbird, you can use the following commands:

/ironbird loadtests - List of load test modes that ironbird can run against testnet
/ironbird start OR /ironbird start --load-test-config= - Launch a testnet with the specified chain and load test configuration.
/ironbird chains - List of chain images that ironbird can use to spin-up testnet

Custom Load Test Configuration

You can provide a custom load test configuration using the `--load-test-config=` flag:

/ironbird start cosmos --load-test-config={
  "block_gas_limit_target": 0.75,
  "num_of_blocks": 50,
  "msgs": [
    {"weight": 0.3, "type": "MsgSend"},
    {"weight": 0.3, "type": "MsgMultiSend"},
	{"weight": 0.4, "type": "MsgArr", "ContainedType": "MsgSend", "NumMsgs": 3300}
  ]
}

Use /ironbird loadtests to see more examples.

- remove store module replace & fix existing require instead; go mod tidy now works - more comet v1 code fixes (enums, fields, imports) (WIP)

- fix more ABCI enum values & types to comet 1 format - fix several callsites to satisfy the new Comet 1 API, following mostly what SDK v52 did to satisfy Comet 1 - revert addition of internal/conv/comet.go (unnecessary) - fix x/consensus/keeper/keeper_test.go and ToProtoConsensusParams() to handle new ABCI consensus params API - regen golden x/genutil/types/testdata/app_genesis.json which adds new ABCI consensus params for Comet v1 - fix TestABCI_CheckTx assuming CHECK_TX_TYPE_CHECK is 0

server/cmt_cmds.go

x/staking/types/validator.go

-
+	tmPk, err := encoding.PubKeyFromProto(tmProtoPk)
+	if err != nil {
+		panic(err)


x/staking/types/validator.go

-
+	tmPk, err := encoding.PubKeyFromProto(tmProtoPk)
+	if err != nil {
+		panic(err)


- fix baseapp ABCI now handles FeatureParams - fix baseapp ABCI tests now handles FeatureParams - fix lint/fmt problem with import statement ordering

github-actions · 2025-04-25T00:24:10Z

@fcecin your pull request is missing a changelog!

baseapp/abci_utils.go

client/rpc/tx.go

go.mod

runtime/app.go

testutil/mock/privval.go

aljo242 · 2025-04-25T15:12:53Z

x/genutil/client/cli/collect.go

+				return errors.Wrap(err, "Failed to get consensus key algo")
+			}
+
+			nodeID, valPubKey, err := genutil.InitializeNodeValidatorFiles(config, consensusKey)


why did this api change?

InitializeNodeValidatorFiles calls InitializeNodeValidatorFilesFromMnemonic, which calls privval.LoadOrGenFilePV from Comet here, but this API has changed in Comet V1. So I just copied the fixed InitializeNodeValidatorFilesFromMnemonic from SDK v52, which takes a key type string as argument, and pulled in everything that needs. If we don't want this, we can do something else.

(x2) I have reverted all these "ed25519 validator keys but BLS keys maybe" changes. CometBFT can take a nil for a key generator function and it will just use the ed25519 as default.

Sounds good as long as we have a comment explianing that default behavior

x/genutil/utils_test.go

x/simulation/mock_cometbft.go

github-project-automation bot added this to Interchain Public Works Apr 15, 2025

github-actions bot added C:x/staking C:CLI C:x/gov C:x/slashing C:x/distribution distribution module related C:x/mint C:Simulations C:x/bank C:x/auth C:x/genutil genutil module issues C:x/authz C:x/group Type: ADR C:x/consensus labels Apr 15, 2025

fcecin added 2 commits April 15, 2025 19:07

feat: upgrade root module to comet v1 (WIP) (2)

1d517b0

- remove store module replace & fix existing require instead; go mod tidy now works - more comet v1 code fixes (enums, fields, imports) (WIP)

github-advanced-security bot found potential problems Apr 24, 2025

View reviewed changes

server/cmt_cmds.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Apr 24, 2025

View reviewed changes

fcecin added 5 commits April 24, 2025 16:11

fix: fix mocks to use import alias generated by mockgen

3c18540

fix: fix int64 -> uint64 conversion (gosec)

1f6e241

fix: baseapp fixes

44e772f

- fix baseapp ABCI now handles FeatureParams - fix baseapp ABCI tests now handles FeatureParams - fix lint/fmt problem with import statement ordering

fix: import lint/fmt

bd7816a

fix: import lint/fmt (2)

674051b

fcecin marked this pull request as ready for review April 25, 2025 00:23

fcecin mentioned this pull request Apr 25, 2025

feat: upgrade systemtests and tests/systemtests modules to CometBFT v1.0.1 #24577

Merged

9 tasks

aljo242 reviewed Apr 25, 2025

View reviewed changes

fcecin added 3 commits April 25, 2025 15:52

fix: use string constant & remove duplicated comet tmhash code

7a1e426

fix: revert API break

77ca1c3

fix: revert API break (2)

94b270a

aljo242 approved these changes Apr 28, 2025

View reviewed changes

fcecin merged commit 7acf61e into feature/comet_v1_upgrade Apr 28, 2025
38 of 48 checks passed

fcecin deleted the fcecin/comet_v1_root branch April 28, 2025 15:20

github-project-automation bot moved this to 🥳 Done in Interchain Public Works Apr 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Upgrade root module to CometBFT v1.0.1 #24528

feat: Upgrade root module to CometBFT v1.0.1 #24528

Uh oh!

fcecin commented Apr 15, 2025 •

edited

Loading

Uh oh!

ironbird-prod bot commented Apr 15, 2025

Uh oh!

Uh oh!

Check warning

Check warning

github-actions bot commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aljo242 Apr 25, 2025

Uh oh!

fcecin Apr 25, 2025 •

edited

Loading

Uh oh!

fcecin Apr 28, 2025

Uh oh!

aljo242 Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Upgrade root module to CometBFT v1.0.1 #24528

feat: Upgrade root module to CometBFT v1.0.1 #24528

Uh oh!

Conversation

fcecin commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Uh oh!

ironbird-prod bot commented Apr 15, 2025

Uh oh!

Uh oh!

Check warning

Check warning

github-actions bot commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aljo242 Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

fcecin Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fcecin Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

aljo242 Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fcecin commented Apr 15, 2025 •

edited

Loading

fcecin Apr 25, 2025 •

edited

Loading