Skip to content

Conversation

@fcecin
Copy link

@fcecin fcecin commented Apr 25, 2025

Description

This PR is part of #24114

This PR upgrades systemtests/go.mod to depend on CometBFT v1.0.1 and on the comet v1 upgrade of the root module (#24528) which pulls in the other comet v1 upgrades as indirect dependencies (core, store, x/tx, api). It also includes minor Comet v1 go API fixes.

This PR also upgrades the tests/systemtests module since it seems to be hard-wired to systemtests via a go.mod replace. As part of that upgrade, a replace for the SDK root module was commented out in tests/systemtests/go.mod.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues. Your PR will not be merged unless you satisfy
all of these items.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

- require root module upgraded to cometbft v1 (which pulls other
upgraded modules as indirect deps)
- remove "/websocket" from comet RPC ctor (not needed)
- fix ABCI RequestQuery -> QueryRequest
@ironbird-prod
Copy link

ironbird-prod bot commented Apr 25, 2025

Ironbird - launch a network To use Ironbird, you can use the following commands:
  • /ironbird chains - List of chain images that ironbird can use to spin-up testnet
  • /ironbird loadtests - List of load test modes that ironbird can run against testnet
  • /ironbird start OR /ironbird start --load-test-config= - Launch a testnet with the specified chain and load test configuration.
Custom Load Test Configuration You can provide a custom load test configuration using the `--load-test-config=` flag:
/ironbird start cosmos --load-test-config={
  "block_gas_limit_target": 0.75,
  "num_of_blocks": 50,
  "msgs": [
    {"weight": 0.3, "type": "MsgSend"},
    {"weight": 0.3, "type": "MsgMultiSend"},
	{"weight": 0.4, "type": "MsgArr", "ContainedType": "MsgSend", "NumMsgs": 3300}
  ]
}

Use /ironbird loadtests to see more examples.

./tests/systemtests is hardwired (via a go.mod replace) to
./systemtests, so it probably needs to be upgdaded together with it.
@fcecin fcecin marked this pull request as ready for review April 25, 2025 19:00
@fcecin fcecin changed the title feat: upgrade systemtests module to CometBFT v1.0.1 feat: upgrade systemtests and tests/systemtests modules to CometBFT v1.0.1 Apr 25, 2025
@fcecin
Copy link
Author

fcecin commented Apr 28, 2025

Nothing important has changed in this last commit (just small code fixes in the root module), but the CI now has assorted failures related to the migration to Comet v1 being done in steps. It was weird that the CI passed in the previous commit, but now it has the types of failures that were expected.

@fcecin fcecin merged commit c03e9fe into feature/comet_v1_upgrade Apr 28, 2025
37 of 45 checks passed
@fcecin fcecin deleted the fcecin/comet_v1_systemtests branch April 28, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants