Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release test script links #3035

Merged
merged 1 commit into from
Dec 11, 2018
Merged

update release test script links #3035

merged 1 commit into from
Dec 11, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Dec 7, 2018

closes #2606

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zramsay zramsay mentioned this pull request Dec 7, 2018
Closed
@codecov
Copy link

codecov bot commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #3035 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3035      +/-   ##
===========================================
+ Coverage    52.04%   52.13%   +0.09%     
===========================================
  Files          136      136              
  Lines         9638     9623      -15     
===========================================
+ Hits          5016     5017       +1     
+ Misses        4285     4269      -16     
  Partials       337      337

jackzampolin
jackzampolin approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@jackzampolin jackzampolin merged commit b2f458a into develop Dec 11, 2018
@jackzampolin jackzampolin deleted the zach/rel-test-script branch December 11, 2018 19:52
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix links in release test script
2 participants
@zramsay @jackzampolin