Remove tools from go.sum deps #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4251 +/- ##
=========================================
- Coverage 58.91% 58.9% -0.02%
=========================================
Files 215 215
Lines 14482 14482
=========================================
- Hits 8532 8530 -2
- Misses 5310 5312 +2
Partials 640 640 |
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
reviewed
May 2, 2019
| @@ -110,7 +110,7 @@ go-mod-cache: go.sum | |||
| @echo "--> Download go modules to local cache" | |||
| @go mod download | |||
|
|
|||
| go.sum: tools go.mod | |||
| go.sum: go.mod | |||
| @echo "--> Ensure dependencies have not been modified" | |||
| @go mod verify | |||
There was a problem hiding this comment.
Do we not need -mod=readonly here?
There was a problem hiding this comment.
-mod=readonly is not supported by go mod just yet - from what I can see here golang/go#31372 and here https://go-review.googlesource.com/c/go/+/174258/, it seems that upstream will include it in Go 1.14
alexanderbez
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go.sum target does not need to depend on tools to run successfully.
Closes: #4165
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: