Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tools from go.sum deps #4251

Merged
merged 1 commit into from
May 2, 2019
Merged

Remove tools from go.sum deps #4251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ go-mod-cache: go.sum
@echo "--> Download go modules to local cache"
@go mod download

go.sum: tools go.mod
go.sum: go.mod
@echo "--> Ensure dependencies have not been modified"
@go mod verify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need -mod=readonly here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-mod=readonly is not supported by go mod just yet - from what I can see here golang/go#31372 and here https://go-review.googlesource.com/c/go/+/174258/, it seems that upstream will include it in Go 1.14


Expand Down