AnteDecorator #5006

AdityaSripal · 2019-09-05T20:39:59Z

implementation of SimpleDecorators approach described in ADR 010: #4942

closes: #4572

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…itya/ante-decorator

x/auth/ante/sigverify_test.go

x/auth/ante/setup_test.go

x/auth/ante/sigverify_test.go

x/auth/ante/basic_test.go

x/auth/ante/sigverify_test.go

AdityaSripal · 2019-09-17T22:03:35Z

Currently all decorators require tx be auth.StdTx which makes this change a bit useless.
Solution: Define specific interfaces for each decorator that tx must fulfill for that decorator to be used

TODOs:

Define Decorator-specific tx interfaces
Documentation

x/auth/ante/sigverify.go

codecov · 2019-09-18T07:04:07Z

Codecov Report

Merging #5006 into master will decrease coverage by 0.03%.
The diff coverage is 70.9%.

@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
- Coverage   54.98%   54.94%   -0.04%     
==========================================
  Files         297      302       +5     
  Lines       18255    18357     +102     
==========================================
+ Hits        10037    10087      +50     
- Misses       7478     7517      +39     
- Partials      740      753      +13

…itya/ante-decorator

x/auth/ante/sigverify_test.go

x/auth/ante/sigverify.go

x/auth/ante/ante_test.go

x/auth/ante/fee.go

x/auth/ante/setup.go

x/auth/types/stdtx.go

…mos-sdk into aditya/ante-decorator

types/handler.go

alexanderbez · 2019-10-03T15:57:17Z

x/auth/ante/ante_test.go

@@ -354,12 +344,12 @@ func TestAnteHandlerMemoGas(t *testing.T) {
 	checkInvalidTx(t, anteHandler, ctx, tx, false, sdk.CodeOutOfGas)

 	// memo too large
-	fee = types.NewStdFee(9000, sdk.NewCoins(sdk.NewInt64Coin("atom", 0)))
+	fee = types.NewStdFee(50000, sdk.NewCoins(sdk.NewInt64Coin("atom", 0)))


Do we have a better understanding on the increased gas costs now?

x/auth/ante/basic.go

rigelrozanski

Based on phone call, we should

move the decorators to a new package x/auth/ante/decorators
add a type assertion of standard tx for each decorator custom tx interface requirements

types/handler.go

alexanderbez · 2019-10-08T18:34:25Z

Agree on StdTx assertions ++

I don't see the rationale though for having a subdirectory or additional nesting. This doesn't introduce any burden as far as I can see. Check out Go's os package.

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

…mos-sdk into aditya/ante-decorator

fedekunze

utACK

alexanderbez

One final note on the ChainAnteDecorators godoc. In addition, this definitely warrants changelog entries -- one for any breaking changes clients should know about and one for an improvement stating the cool benefits of this new architecture!

types/handler.go

alexanderbez

testedACK

AdityaSripal added 6 commits August 28, 2019 16:00

start decorator changes

1960993

start replacing ante logic with decorators

12244c5

Fix build errors

5a46ceb

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into ad…

bdcf294

…itya/ante-decorator

fix some tests

ac19f18

fix baseapp tests

9a0eac7

AdityaSripal added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). WIP labels Sep 9, 2019

AdityaSripal added 3 commits September 12, 2019 14:53

fix auth tests

725f5cf

start individual decorator tests

ff5f1f7

add signature tests

73e2739

golangcibot reviewed Sep 17, 2019

View reviewed changes

complete sig tests

77bc7c6

golangcibot reviewed Sep 17, 2019

View reviewed changes

x/auth/ante/sigverify_test.go Outdated Show resolved Hide resolved

x/auth/ante/sigverify_test.go Outdated Show resolved Hide resolved

fix all test errors

baf5bfb

AdityaSripal marked this pull request as ready for review September 17, 2019 22:01

AdityaSripal requested review from alessio, alexanderbez, fedekunze, jackzampolin and rigelrozanski as code owners September 17, 2019 22:01

golangcibot reviewed Sep 17, 2019

View reviewed changes

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

AdityaSripal added 2 commits September 17, 2019 23:31

remove unnecessary &

71e07ce

fix linter errors

3b3a74f

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into ad…

6303bec

…itya/ante-decorator

golangcibot reviewed Sep 18, 2019

View reviewed changes

interface all decorators except sigs

e52e89d

AdityaSripal commented Sep 19, 2019

View reviewed changes

x/auth/ante/sigverify.go Show resolved Hide resolved

tnachen reviewed Oct 3, 2019

View reviewed changes

x/auth/ante/ante_test.go Outdated Show resolved Hide resolved

tnachen reviewed Oct 3, 2019

View reviewed changes

x/auth/ante/fee.go Outdated Show resolved Hide resolved

tnachen reviewed Oct 3, 2019

View reviewed changes

x/auth/ante/setup.go Show resolved Hide resolved

tnachen reviewed Oct 3, 2019

View reviewed changes

x/auth/types/stdtx.go Outdated Show resolved Hide resolved

AdityaSripal and others added 4 commits October 3, 2019 10:49

address tim comments

29e85bf

Merge branch 'aditya/ante-decorator' of https://github.com/cosmos/cos…

f1964cf

…mos-sdk into aditya/ante-decorator

Merge branch 'master' into aditya/ante-decorator

b6d9166

add order comments

0fd1234

alexanderbez suggested changes Oct 8, 2019

View reviewed changes

rigelrozanski approved these changes Oct 8, 2019

View reviewed changes

types/handler.go Show resolved Hide resolved

AdityaSripal mentioned this pull request Oct 8, 2019

Gas Cost for Cached Reads #5154

Open

4 tasks

AdityaSripal and others added 3 commits October 8, 2019 12:00

Add Schwarzenegger art

aad9673

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

add assertions that StdTx implements all necessary decorator interfaces

5ce99da

Merge branch 'aditya/ante-decorator' of https://github.com/cosmos/cos…

bd79e58

…mos-sdk into aditya/ante-decorator

fedekunze approved these changes Oct 8, 2019

View reviewed changes

alexanderbez suggested changes Oct 9, 2019

View reviewed changes

types/handler.go Show resolved Hide resolved

AdityaSripal and others added 7 commits October 9, 2019 15:26

documentation and CHANGELOG

2f54876

Run goimports

a4ef3ec

Update ChainAnteDecorators godoc

33cc17a

Changelog entries cleanup

882fac5

Changelog entries cleanup

163da7f

Merge branch 'master' into aditya/ante-decorator

492cf0d

Fix formatter

1b1a779

alexanderbez approved these changes Oct 10, 2019

View reviewed changes

Merge branch 'master' into aditya/ante-decorator

440a05c

alexanderbez merged commit c0223a4 into master Oct 10, 2019

alexanderbez deleted the aditya/ante-decorator branch October 10, 2019 12:46

AdityaSripal mentioned this pull request Oct 10, 2019

Simulate SigVerification correctly #5179

Closed

5 tasks

tac0turtle mentioned this pull request Oct 12, 2019

R4R - Finish new docs v1 #5186

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AnteDecorator #5006

AnteDecorator #5006

AdityaSripal commented Sep 5, 2019 •

edited by alexanderbez

Loading

AdityaSripal commented Sep 17, 2019

codecov bot commented Sep 18, 2019 •

edited

Loading

alexanderbez Oct 3, 2019

rigelrozanski left a comment •

edited by AdityaSripal

Loading

alexanderbez commented Oct 8, 2019

fedekunze left a comment

alexanderbez left a comment

alexanderbez left a comment

AnteDecorator #5006

AnteDecorator #5006

Conversation

AdityaSripal commented Sep 5, 2019 • edited by alexanderbez Loading

AdityaSripal commented Sep 17, 2019

codecov bot commented Sep 18, 2019 • edited Loading

Codecov Report

alexanderbez Oct 3, 2019

Choose a reason for hiding this comment

rigelrozanski left a comment • edited by AdityaSripal Loading

Choose a reason for hiding this comment

alexanderbez commented Oct 8, 2019

fedekunze left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

AdityaSripal commented Sep 5, 2019 •

edited by alexanderbez

Loading

codecov bot commented Sep 18, 2019 •

edited

Loading

rigelrozanski left a comment •

edited by AdityaSripal

Loading