Simulate SigVerification correctly #5179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
suggested changes
Oct 10, 2019
There was a problem hiding this comment.
the consumeSimSigGas name is misleading since it seems like it is simulating signature verification. Really what it is doing is consuming the gas for the size of the signature since that didn’t happen with ConsumeTxSizeGasDecorator since the signature is nil
how is it misleading tho? consumeSimSigGas seems like it consumes just gas?
it does, but really it is not doing signature verification gas consumption
Codecov Report
@@ Coverage Diff @@
## master #5179 +/- ##
==========================================
+ Coverage 53.36% 53.42% +0.06%
==========================================
Files 290 290
Lines 17696 17701 +5
==========================================
+ Hits 9443 9457 +14
+ Misses 7516 7506 -10
- Partials 737 738 +1 |
fedekunze
reviewed
Oct 13, 2019
|
Closing in favor of #5195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an undetected bug in how signature verification cost gets simulated in #5006. This is a quick PR to fix the issue
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: