-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for github.com/99designs/keyring-backed keybases #5029
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5029 +/- ##
=========================================
- Coverage 55.02% 54.8% -0.23%
=========================================
Files 291 294 +3
Lines 17841 18222 +381
=========================================
+ Hits 9817 9986 +169
- Misses 7317 7490 +173
- Partials 707 746 +39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Pending Changelog
entry
FTR Changelog entry has been added, will fix the conflicts shortly |
crypto/keys/keybase_keyring.go
Outdated
if language != English { | ||
return nil, "", ErrUnsupportedLanguage | ||
} | ||
if algo != Secp256k1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light of #4941, we need to be cognizant of varying signing algos.
@alessio instead of just creating private auxiliary functions that all the Keybase implementations leverage, wouldn't it be more adventagous to have a public "base" Keybase that all the KeyBase implementations embed? This would allow other applications to potentially implement their own not to mention it would improve testing. The overhead to doing this is minimal afaict. |
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Thanks for the thorough review @alexanderbez |
Woohoo |
Introduce new Keybase implementation that can leverage
operating systems' built-in functionalities to securely store
secrets.
This chunk is extracted from @poldsam's original PR:
Thanks: @alexanderbez for the careful review.
docs/
)Unreleased
section inCHANGELOG.md
Files changed
in the github PR explorerFor Admin Use: