Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for github.com/99designs/keyring-backed keybases #5029

Merged
merged 51 commits into from
Sep 21, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 11, 2019

Introduce new Keybase implementation that can leverage
operating systems' built-in functionalities to securely store
secrets.

This chunk is extracted from @poldsam's original PR:

Thanks: @alexanderbez for the careful review.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #5029 into master will decrease coverage by 0.22%.
The diff coverage is 50.4%.

@@            Coverage Diff            @@
##           master   #5029      +/-   ##
=========================================
- Coverage   55.02%   54.8%   -0.23%     
=========================================
  Files         291     294       +3     
  Lines       17841   18222     +381     
=========================================
+ Hits         9817    9986     +169     
- Misses       7317    7490     +173     
- Partials      707     746      +39

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Pending Changelog entry

@alexanderbez alexanderbez added the C:Keys Keybase, KMS and HSMs label Sep 11, 2019
@alessio
Copy link
Contributor Author

alessio commented Sep 12, 2019

FTR Changelog entry has been added, will fix the conflicts shortly

if language != English {
return nil, "", ErrUnsupportedLanguage
}
if algo != Secp256k1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of #4941, we need to be cognizant of varying signing algos.

crypto/keys/keybase_keyring.go Show resolved Hide resolved
crypto/keys/keybase_keyring.go Outdated Show resolved Hide resolved
crypto/keys/keybase_keyring.go Outdated Show resolved Hide resolved
crypto/keys/keybase_keyring.go Show resolved Hide resolved
crypto/keys/keybase_keyring.go Outdated Show resolved Hide resolved
crypto/keys/keybase_keyring.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

@alessio instead of just creating private auxiliary functions that all the Keybase implementations leverage, wouldn't it be more adventagous to have a public "base" Keybase that all the KeyBase implementations embed? This would allow other applications to potentially implement their own not to mention it would improve testing.

The overhead to doing this is minimal afaict.

Alessio Treglia and others added 4 commits September 17, 2019 06:46
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@alexanderbez alexanderbez added S:blocked Status: Blocked and removed S:blocked Status: Blocked labels Sep 21, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio
Copy link
Contributor Author

alessio commented Sep 21, 2019

Thanks for the thorough review @alexanderbez

@alessio alessio merged commit 2c96bbb into master Sep 21, 2019
@alessio alessio deleted the alessio/keystore-start-with-keybase branch September 21, 2019 16:54
@zmanian
Copy link
Member

zmanian commented Sep 23, 2019

Woohoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants