Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK version to latest master (532ea1872) #144

Merged
merged 10 commits into from
Oct 2, 2019

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez changed the title Bump SDK version to fbdf0e778 Bump SDK version to latest master (fbdf0e778) Sep 26, 2019
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #144 into master will decrease coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   66.46%   65.65%   -0.82%     
==========================================
  Files           5        5              
  Lines         492      492              
==========================================
- Hits          327      323       -4     
- Misses        134      138       +4     
  Partials       31       31

@alexanderbez
Copy link
Contributor Author

I've bisected the localnet CI failure down to cosmos/cosmos-sdk#5029 and I have no idea why. Any clues here would be helpful @alessio

@mircea-c
Copy link

mircea-c commented Oct 2, 2019

@alexanderbez what points to that PR as the cause of the failure?

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Oct 2, 2019

Commit 2c96bbbaa fails, the one right before, ab81c798c, works.

* 2c96bbbaa - Add support for github.com/99designs/keyring-backed keybases (#5029) (11 days ago) <Alessio Treglia>
* ab81c798c - Merge PR #5084: Sanitize tools Makefile (12 days ago) <Alexander Bezobchuk>

@alexanderbez alexanderbez changed the title Bump SDK version to latest master (fbdf0e778) Bump SDK version to latest master (608a81962a14) Oct 2, 2019
@alexanderbez alexanderbez changed the title Bump SDK version to latest master (608a81962a14) Bump SDK version to latest master (532ea1872) Oct 2, 2019
@alexanderbez alexanderbez merged commit 8b97a66 into master Oct 2, 2019
@alexanderbez alexanderbez deleted the bez/bump-sdk-version branch October 2, 2019 16:43
@mircea-c
Copy link

mircea-c commented Oct 2, 2019

@mircea-c mircea-c mentioned this pull request Oct 2, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants