Joon/555 tests #688
Merged
Joon/555 tests #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #688 +/- ##
========================================
Coverage 59.25% 59.25%
========================================
Files 62 62
Lines 3286 3286
========================================
Hits 1947 1947
Misses 1194 1194
Partials 145 145 |
|
Can be merged |
|
@sunnya97 can you review this PR? is relevant for tests you were talking about developing? |
sunnya97
requested changes
Mar 30, 2018
There was a problem hiding this comment.
Let's make SignCheckDeliver() and CheckBalance() more general purpose by allowing us to pass in an Account/Address repectively and then let's update all of these msg tests to use those functions. See TestQuizMsg() for example.
Also can we change TestHandler() to something more specific like TestIBCMsgs() or something?
sunnya97
approved these changes
Apr 1, 2018
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
* Fix path in doc * Fix command in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #555