-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ledger/multisig detection in SignTx functions #9026
Conversation
// This function should only be used when signing with a multisig. For | ||
// normal keys, please use SignTx directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is called twice in the sdk, and both are with multisigs. As I understand, there's no use-case for calling this without a multisig, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably right
Codecov Report
@@ Coverage Diff @@
## master #9026 +/- ##
==========================================
- Coverage 58.96% 58.85% -0.11%
==========================================
Files 575 573 -2
Lines 32159 32091 -68
==========================================
- Hits 18963 18888 -75
- Misses 10982 10992 +10
+ Partials 2214 2211 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
* Add ledger/multisig detection in SignTx functions * Fix tests * Update CHANGELOG.md * update cl Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Description
Before:
Some individual commands (
tx sign
,tx sign-batch
) hardcoded to useSIGN_MODE_LEGACY_AMINO_JSON
in the CLI command handler.We forgot to hardcode
SIGN_MODE_LEGACY_AMINO_JSON
in the gentx command, hence the bug #9023After:
Instead of putting the code:
if txF.SignMode == nil {txF.WithSignMode(LEGACY_AMINO_JSON)}
in each individual CLI command, we factorize that in the upstream
.SignTx
and.SignTxWithAddress
functions that the CLI calls.I tested
simd gentx
with a ledger keycloses: #9023
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes