Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.43 audit changes for client/ #9295

Merged
merged 4 commits into from
May 11, 2021
Merged

v0.43 audit changes for client/ #9295

merged 4 commits into from
May 11, 2021

Conversation

aleem1314
Copy link
Contributor

Description

ref: #9218


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels May 11, 2021
@aleem1314 aleem1314 changed the title v0.43 aidut changes for client/ v0.43 audit changes for client/ May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #9295 (01b9bc2) into master (3a774cf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 01b9bc2 differs from pull request most recent head 115428f. Consider uploading reports for the commit 115428f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9295      +/-   ##
==========================================
- Coverage   60.33%   60.33%   -0.01%     
==========================================
  Files         591      591              
  Lines       36940    36942       +2     
==========================================
  Hits        22288    22288              
- Misses      12682    12684       +2     
  Partials     1970     1970              
Impacted Files Coverage Δ
client/config/cmd.go 38.88% <0.00%> (-1.50%) ⬇️
client/keys/add.go 62.50% <ø> (ø)

@aleem1314 aleem1314 marked this pull request as ready for review May 11, 2021 07:02
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of nits.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 11, 2021
@mergify mergify bot merged commit 505cb83 into master May 11, 2021
@mergify mergify bot deleted the aleem/client-audit branch May 11, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants