Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.43 audit changes for client/ #9295

Merged
merged 4 commits into from
May 11, 2021
Merged

v0.43 audit changes for client/ #9295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dfbb66
0.43 aidut changes for client module
aleem1314 May 11, 2021
c0fde4d
Merge branch 'master' into aleem/client-audit
aleem1314 May 11, 2021
01b9bc2
Merge branch 'master' into aleem/client-audit
atheeshp May 11, 2021
115428f
Merge branch 'master' into aleem/client-audit
amaury1093 May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions client/config/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ func runConfigCmd(cmd *cobra.Command, args []string) error {

switch len(args) {
case 0:
// print all client config fields to sdt out
s, _ := json.MarshalIndent(conf, "", "\t")
// print all client config fields to stdout
s, err := json.MarshalIndent(conf, "", "\t")
if err != nil {
return err
}
cmd.Println(string(s))

case 1:
Expand Down
9 changes: 5 additions & 4 deletions client/docs/statik/statik.go
View file
Open in desktop

Large diffs are not rendered by default.

37 changes: 33 additions & 4 deletions client/docs/swagger-ui/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ paths:
parameters:
- in: body
name: delegation
description: The password of the account to remove from the KMS
description: Delegate an amount of liquid coins to a validator
schema:
type: object
properties:
Expand Down Expand Up @@ -1760,7 +1760,7 @@ paths:
parameters:
- in: body
name: delegation
description: The password of the account to remove from the KMS
description: Unbond an amount of bonded shares from a validator
schema:
type: object
properties:
Expand Down Expand Up @@ -16945,6 +16945,11 @@ paths:
bond_denom:
type: string
description: bond_denom defines the bondable coin denomination.
power_reduction:
type: string
title: >-
power_reduction is the amount of staking tokens required
for 1 unit of consensus-engine power
description: >-
QueryParamsResponse is response type for the Query/Params RPC
method.
Expand Down Expand Up @@ -31115,6 +31120,11 @@ definitions:
bond_denom:
type: string
description: bond_denom defines the bondable coin denomination.
power_reduction:
type: string
title: >-
power_reduction is the amount of staking tokens required for 1 unit of
consensus-engine power
description: Params defines the parameters for the staking module.
cosmos.staking.v1beta1.Pool:
type: object
Expand Down Expand Up @@ -32355,6 +32365,11 @@ definitions:
bond_denom:
type: string
description: bond_denom defines the bondable coin denomination.
power_reduction:
type: string
title: >-
power_reduction is the amount of staking tokens required for 1
unit of consensus-engine power
description: QueryParamsResponse is response type for the Query/Params RPC method.
cosmos.staking.v1beta1.QueryPoolResponse:
type: object
Expand Down Expand Up @@ -35881,7 +35896,14 @@ definitions:
transaction.
memo:
type: string
title: memo is any arbitrary memo to be added to the transaction
description: >-
memo is any arbitrary note/comment to be added to the transaction.

WARNING: in clients, any publicly exposed text should not be
called memo,

but should be called `note` instead (see
https://github.com/cosmos/cosmos-sdk/issues/9122).
timeout_height:
type: string
format: uint64
Expand Down Expand Up @@ -36451,7 +36473,14 @@ definitions:
transaction.
memo:
type: string
title: memo is any arbitrary memo to be added to the transaction
description: >-
memo is any arbitrary note/comment to be added to the transaction.

WARNING: in clients, any publicly exposed text should not be called
memo,

but should be called `note` instead (see
https://github.com/cosmos/cosmos-sdk/issues/9122).
timeout_height:
type: string
format: uint64
Expand Down
4 changes: 2 additions & 2 deletions client/docs/swagger_legacy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ paths:
parameters:
- in: body
name: delegation
description: The password of the account to remove from the KMS
description: Delegate an amount of liquid coins to a validator
schema:
type: object
properties:
Expand Down Expand Up @@ -646,7 +646,7 @@ paths:
parameters:
- in: body
name: delegation
description: The password of the account to remove from the KMS
description: Unbond an amount of bonded shares from a validator
schema:
type: object
properties:
Expand Down
1 change: 0 additions & 1 deletion client/keys/add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ output
- armor encrypted private key (saved to file)
*/
func RunAddCmd(ctx client.Context, cmd *cobra.Command, args []string, inBuf *bufio.Reader) error {
// func RunAddCmd(cmd *cobra.Command, args []string, kb keyring.Keyring, inBuf *bufio.Reader) error {
var err error

name := args[0]
Expand Down