fix(keyring): update keyring for kwallet fix

[robert-zaremba]

Description

Closes: #9562

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[ryanchristo]

utACK

We should have someone with kwallet installed review and test before merging.

Also, should we create a followup issue or keep the current issue open to remove the replace once 99designs/keyring#87 has been added?

[robert-zaremba]

OK for the followup issue.

We should have someone with kwallet installed review and test before merging.

I tested it because I was facing this problem.

[amaury1093]

Have one question whether app devs need to change their go.mod

[amaury1093]

In the docs we mentioned to all app developer to add the line replace google.golang.org/grpc => google.golang.org/grpc v1.33.2.

If we merge this PR, should all developers also add this line? If yes, I would maybe prefer to wait for 99designs to merge your PR and wait for the next release.

[robert-zaremba]

The priority is to have a working software.

If we don't want to use replace statement, then we can use my patch (or clone it into cosmos-sdk) and change the dependency - which will require changing it in all files where 99designs/keyring package is used.

[robert-zaremba]

We decided to fork the keyring into cosmos organization and port the patch to the cosmos fork (we don't know how much time it will take 99design to merge and release, and we don't want to be blocked with the v0.43 release).

The remaining question was to use replace or change the dependency. Initially I wanted to change the dependency, but that would involve more changes in the keyring fork (we would need to change imports there and go.mod). So instead I proposed to use the replacement.

[amaury1093]

utACK

The remaining question was to use replace or change the dependency. Initially I wanted to change the dependency, but that would involve more changes in the keyring fork (we would need to change imports there and go.mod). So instead I proposed to use the replacement.

I have a slight preference for replace too.