Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove legacy REST #9594

Merged
merged 36 commits into from
Jul 6, 2021
Merged

feat!: remove legacy REST #9594

merged 36 commits into from
Jul 6, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 28, 2021

Description

ref: #7517

  • Remove the x/{module}/client/rest folder
  • Remove all glue code between simapp/modules and the REST server

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification - see Remove Legacy REST documentation #9615
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate - see Remove Legacy REST documentation #9615
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #9594 (061a8c8) into master (2c6b866) will increase coverage by 2.96%.
The diff coverage is 85.57%.

❗ Current head 061a8c8 differs from pull request most recent head 60950ca. Consider uploading reports for the commit 60950ca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9594      +/-   ##
==========================================
+ Coverage   60.57%   63.54%   +2.96%     
==========================================
  Files         588      570      -18     
  Lines       37458    37473      +15     
==========================================
+ Hits        22692    23811    +1119     
+ Misses      12776    11803     -973     
+ Partials     1990     1859     -131     
Impacted Files Coverage Δ
client/rpc/block.go 0.00% <ø> (-10.00%) ⬇️
client/rpc/status.go 67.74% <ø> (+20.01%) ⬆️
client/rpc/validators.go 0.00% <0.00%> (ø)
client/tx/tx.go 40.83% <ø> (+10.20%) ⬆️
simapp/app.go 83.90% <ø> (+0.81%) ⬆️
types/query/pagination.go 80.00% <ø> (ø)
x/auth/client/cli/query.go 0.00% <0.00%> (ø)
x/auth/client/cli/tx_multisign.go 0.00% <0.00%> (ø)
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)
x/auth/module.go 53.65% <0.00%> (ø)
... and 33 more

@aleem1314 aleem1314 changed the title feat: remove legacy REST feat!: remove legacy REST Jun 30, 2021
@aleem1314 aleem1314 marked this pull request as ready for review June 30, 2021 15:18
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: cosmos#7517 

  * [x] Remove the x/{module}/client/rest folder
  * [x] Remove all glue code between simapp/modules and the REST server

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification - see cosmos#9615
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [x] reviewed API design and naming
- [ ] reviewed documentation is accurate - see cosmos#9615
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
MSalopek pushed a commit to cosmos/interchain-security that referenced this pull request May 22, 2023
@dudong2 dudong2 mentioned this pull request Jul 26, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants