-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations #9780
refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations #9780
Conversation
If some YAML marshallers are being replaced, then I guess all of them would have to be for consistency. There are still some places where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks for the work!
I think we can replace the remaining gopkg.in
instances:
client/context.go
we should be able to useJSONToYAML
method from the new library, but we'll need to manually test that to confirm- I think we can remove the
yaml.Marshaler
references - There are about 7 other files where it shows up and I think we can replace it in all of those
This pull request introduces 1 alert when merging 985390d into 36ab23a - view on LGTM.com new alerts:
|
The nested edit: idk what this means or how to do it, could I please get help |
@AmauryM would you be able to help with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lukerhoads for this PR, and sorry for the delay!
Just had a look, and proposed a fix for the failing test. Could you also merge/rebase master into this branch?
This last test seems to be failing because the sigs.k8s.io yaml package does not call the MarshalYAML function of the StdSignature. The gopkg yaml does, though, as it uses its own type MarshalYAML. This means that we should just call the MarshalYAML function directly to avoid using gopkg yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this overall lgtm! @lukerhoads could you fix the conflict and the failing test? We can merge it right after!
At school right now - when I get home I will get on WSL so I can properly fix the last test, or you guys could take over (as I have been rlly slow and don't have a very good idea of how to fix the TestGRPCWebTestSuite error |
…om/lukerhoads/cosmos-sdk into lukerhoads/remote-yaml-annotations
This reverts commit 75e97ee.
I have no idea why all of the builds are failing, I am not at all experienced with this kind of error |
I believe you simply need to run |
Codecov Report
@@ Coverage Diff @@
## master #9780 +/- ##
==========================================
- Coverage 63.67% 63.65% -0.02%
==========================================
Files 573 573
Lines 53764 53762 -2
==========================================
- Hits 34235 34223 -12
- Misses 17582 17590 +8
- Partials 1947 1949 +2
|
Description
Draft of: #9705
Started off with changing codec
MarshalYaml
function to directly go from JSON to yaml using the new library. Replaced the only usage of UnmarshalYaml per request.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change