Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implementing sigs.k8s.io YAML to remove .proto yaml annotations #9780

Merged
merged 42 commits into from
Sep 24, 2021
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
c1de062
Implementing sigs.k8s.io YAML fork
lukerhoads Jul 27, 2021
47c4f27
Removed unnecessary YAML annotations from moduleAccountPretty
lukerhoads Jul 27, 2021
7b15587
Removed unecessary YAML annotations from vestingAccountYAML
lukerhoads Jul 27, 2021
ebf6215
Merge branch 'cosmos:master' into lukerhoads/remote-yaml-annotations
lukerhoads Jul 27, 2021
0c75cad
Replaced usage of yaml.v2 with new one
lukerhoads Jul 30, 2021
d30726f
Merge branch 'master' into lukerhoads/remote-yaml-annotations
lukerhoads Jul 30, 2021
985390d
Fully removed usage of gopkg yaml
lukerhoads Jul 30, 2021
c902d70
Removed all protobuf moretag annotations
lukerhoads Jul 30, 2021
3a33260
Merge branch 'master' into lukerhoads/remote-yaml-annotations
lukerhoads Aug 1, 2021
5dd48e3
Resolve unused problem
lukerhoads Aug 1, 2021
9f4a035
Merge branch 'cosmos:master' into lukerhoads/remote-yaml-annotations
lukerhoads Aug 3, 2021
5f7839d
Merged master
lukerhoads Aug 9, 2021
ba76ca3
Regenned proto files
lukerhoads Aug 9, 2021
5bd7cb7
Updated CHANGELOG
lukerhoads Aug 9, 2021
9879240
Merge branch 'lukerhoads/remote-yaml-annotations' of https://github.c…
lukerhoads Aug 9, 2021
916c732
Reverted formatting changes
lukerhoads Aug 9, 2021
739a6eb
Regenerated proto files
lukerhoads Aug 9, 2021
f97a9b3
Merged master
lukerhoads Aug 9, 2021
5a15c04
Merged and resolved conflict
lukerhoads Aug 9, 2021
c70a939
Fixed newline formatting for changelog
lukerhoads Aug 9, 2021
8b30a16
Merged master
lukerhoads Sep 1, 2021
65578ae
Removed old yaml dep in go.mod
lukerhoads Sep 1, 2021
8fe0f1f
Fixed most tests
lukerhoads Sep 2, 2021
66468aa
Merge branch 'cosmos:master' into lukerhoads/remote-yaml-annotations
lukerhoads Sep 3, 2021
60f5061
Fixed other straightforward testing errors
lukerhoads Sep 3, 2021
4d288c9
Merge master
lukerhoads Sep 15, 2021
3b0d402
Removed last yaml tags, modified param test cases
lukerhoads Sep 15, 2021
91a91cb
Changed tests to directly call StdSignature marshalYAML as sigs.k8s.i…
lukerhoads Sep 16, 2021
fcec039
Fixed no new var build error
lukerhoads Sep 16, 2021
fbfe8f0
Added CLI breaking change in CHANGELOG
lukerhoads Sep 17, 2021
631d648
Merged master
lukerhoads Sep 17, 2021
bca0f70
Fix build error in bank types
lukerhoads Sep 17, 2021
4814390
Update CHANGELOG.md
amaury1093 Sep 17, 2021
75e97ee
go mod tidy
lukerhoads Sep 17, 2021
425c522
Merge branch 'lukerhoads/remote-yaml-annotations' of https://github.c…
lukerhoads Sep 17, 2021
3e83faa
Revert "go mod tidy"
lukerhoads Sep 17, 2021
9cc5706
Fix merge conflicts
lukerhoads Sep 18, 2021
0ace588
Fix param unit tests
lukerhoads Sep 18, 2021
64bd40c
Merge branch 'master' into lukerhoads/remote-yaml-annotations
lukerhoads Sep 23, 2021
d572a72
Resolve merge conflicts
lukerhoads Sep 23, 2021
a1d5263
Go mod tidy
lukerhoads Sep 24, 2021
a20180d
Merge branch 'master' into lukerhoads/remote-yaml-annotations
amaury1093 Sep 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* [\#9780](https://github.com/cosmos/cosmos-sdk/pull/9780) Remove gogoproto `moretags` YAML annotations and add `sigs.k8s.io/yaml` for YAML marshalling.
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved
* [\#9860](https://github.com/cosmos/cosmos-sdk/pull/9860) Emit transaction fee in ante handler fee decorator. The event type is `tx` and the attribute is `fee`.
* [\#9776](https://github.com/cosmos/cosmos-sdk/pull/9776) Add flag `staking-bond-denom` to specify the staking bond denomination value when initializing a new chain.
* [\#9533](https://github.com/cosmos/cosmos-sdk/pull/9533) Added a new gRPC method, `DenomOwners`, in `x/bank` to query for all account holders of a specific denomination.
Expand Down
16 changes: 4 additions & 12 deletions client/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@ package client

import (
"bufio"
"encoding/json"
"io"
"os"

"github.com/spf13/viper"

"gopkg.in/yaml.v2"
"sigs.k8s.io/yaml"

"github.com/gogo/protobuf/proto"
"github.com/pkg/errors"
Expand Down Expand Up @@ -280,16 +279,9 @@ func (ctx Context) PrintObjectLegacy(toPrint interface{}) error {
}

func (ctx Context) printOutput(out []byte) error {
var err error
if ctx.OutputFormat == "text" {
// handle text format by decoding and re-encoding JSON as YAML
var j interface{}

err := json.Unmarshal(out, &j)
if err != nil {
return err
}

out, err = yaml.Marshal(j)
out, err = yaml.JSONToYAML(out)
if err != nil {
return err
}
Expand All @@ -300,7 +292,7 @@ func (ctx Context) printOutput(out []byte) error {
writer = os.Stdout
}

_, err := writer.Write(out)
_, err = writer.Write(out)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion client/keys/parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/spf13/cobra"
"github.com/tendermint/tendermint/libs/cli"
yaml "gopkg.in/yaml.v2"
"sigs.k8s.io/yaml"

sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/bech32"
Expand Down
2 changes: 1 addition & 1 deletion client/keys/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"io"
"path/filepath"

yaml "gopkg.in/yaml.v2"
"sigs.k8s.io/yaml"

cryptokeyring "github.com/cosmos/cosmos-sdk/crypto/keyring"
)
Expand Down
13 changes: 2 additions & 11 deletions codec/yaml.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package codec

import (
"encoding/json"

"github.com/gogo/protobuf/proto"
"gopkg.in/yaml.v2"
"sigs.k8s.io/yaml"
)

// MarshalYAML marshals toPrint using JSONCodec to leverage specialized MarshalJSON methods
Expand All @@ -18,12 +16,5 @@ func MarshalYAML(cdc JSONCodec, toPrint proto.Message) ([]byte, error) {
return nil, err
}

// generate YAML by decoding JSON and re-encoding to YAML
var j interface{}
err = json.Unmarshal(bz, &j)
if err != nil {
return nil, err
}

return yaml.Marshal(j)
return yaml.JSONToYAML(bz)
}
31 changes: 15 additions & 16 deletions crypto/keys/multisig/keys.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/core/proto-docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ Query defines the gRPC querier service.
| `Accounts` | [QueryAccountsRequest](#cosmos.auth.v1beta1.QueryAccountsRequest) | [QueryAccountsResponse](#cosmos.auth.v1beta1.QueryAccountsResponse) | Accounts returns all the existing accounts | GET|/cosmos/auth/v1beta1/accounts|
| `Account` | [QueryAccountRequest](#cosmos.auth.v1beta1.QueryAccountRequest) | [QueryAccountResponse](#cosmos.auth.v1beta1.QueryAccountResponse) | Account returns account details based on address. | GET|/cosmos/auth/v1beta1/accounts/{address}|
| `Params` | [QueryParamsRequest](#cosmos.auth.v1beta1.QueryParamsRequest) | [QueryParamsResponse](#cosmos.auth.v1beta1.QueryParamsResponse) | Params queries all parameters. | GET|/cosmos/auth/v1beta1/params|
| `ModuleAccounts` | [QueryModuleAccountsRequest](#cosmos.auth.v1beta1.QueryModuleAccountsRequest) | [QueryModuleAccountsResponse](#cosmos.auth.v1beta1.QueryModuleAccountsResponse) | ModuleAccounts returns all the existing Module Accounts. | GET|/cosmos/auth/v1beta1/module_accounts|
| `ModuleAccounts` | [QueryModuleAccountsRequest](#cosmos.auth.v1beta1.QueryModuleAccountsRequest) | [QueryModuleAccountsResponse](#cosmos.auth.v1beta1.QueryModuleAccountsResponse) | ModuleAccounts returns all the existing module accounts. | GET|/cosmos/auth/v1beta1/module_accounts|

<!-- end services -->

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ require (
google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c
google.golang.org/grpc v1.39.1
google.golang.org/protobuf v1.27.1
gopkg.in/yaml.v2 v2.4.0
nhooyr.io/websocket v1.8.6 // indirect
sigs.k8s.io/yaml v1.2.0
)

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1241,4 +1241,6 @@ rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8
rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
sigs.k8s.io/yaml v1.1.0/go.mod h1:UJmg0vDUVViEyp3mgSv9WPwZCDxu4rQW1olrI1uml+o=
sigs.k8s.io/yaml v1.2.0 h1:kr/MCeFWJWTwyaHoR9c8EjH9OumOmoF9YGiZd7lFm/Q=
sigs.k8s.io/yaml v1.2.0/go.mod h1:yfXDCHCao9+ENCvLSE62v9VSji2MKu5jeNfTrofGhJc=
sourcegraph.com/sourcegraph/appdash v0.0.0-20190731080439-ebfcffb1b5c0/go.mod h1:hI742Nqp5OhwiqlzhgfbWU4mW4yO10fP+LoT9WOswdU=
16 changes: 8 additions & 8 deletions proto/cosmos/auth/v1beta1/auth.proto
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ message BaseAccount {

string address = 1;
google.protobuf.Any pub_key = 2
[(gogoproto.jsontag) = "public_key,omitempty", (gogoproto.moretags) = "yaml:\"public_key\""];
uint64 account_number = 3 [(gogoproto.moretags) = "yaml:\"account_number\""];
[(gogoproto.jsontag) = "public_key,omitempty"];
uint64 account_number = 3;
uint64 sequence = 4;
}

Expand All @@ -30,7 +30,7 @@ message ModuleAccount {
option (gogoproto.goproto_stringer) = false;
option (cosmos_proto.implements_interface) = "ModuleAccountI";

BaseAccount base_account = 1 [(gogoproto.embed) = true, (gogoproto.moretags) = "yaml:\"base_account\""];
BaseAccount base_account = 1 [(gogoproto.embed) = true];
string name = 2;
repeated string permissions = 3;
}
Expand All @@ -40,11 +40,11 @@ message Params {
option (gogoproto.equal) = true;
option (gogoproto.goproto_stringer) = false;

uint64 max_memo_characters = 1 [(gogoproto.moretags) = "yaml:\"max_memo_characters\""];
uint64 tx_sig_limit = 2 [(gogoproto.moretags) = "yaml:\"tx_sig_limit\""];
uint64 tx_size_cost_per_byte = 3 [(gogoproto.moretags) = "yaml:\"tx_size_cost_per_byte\""];
uint64 max_memo_characters = 1;
uint64 tx_sig_limit = 2;
uint64 tx_size_cost_per_byte = 3;
uint64 sig_verify_cost_ed25519 = 4
[(gogoproto.customname) = "SigVerifyCostED25519", (gogoproto.moretags) = "yaml:\"sig_verify_cost_ed25519\""];
[(gogoproto.customname) = "SigVerifyCostED25519"];
uint64 sig_verify_cost_secp256k1 = 5
[(gogoproto.customname) = "SigVerifyCostSecp256k1", (gogoproto.moretags) = "yaml:\"sig_verify_cost_secp256k1\""];
[(gogoproto.customname) = "SigVerifyCostSecp256k1"];
}
4 changes: 2 additions & 2 deletions proto/cosmos/bank/v1beta1/bank.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ option go_package = "github.com/cosmos/cosmos-sdk/x/bank/types";
// Params defines the parameters for the bank module.
message Params {
option (gogoproto.goproto_stringer) = false;
repeated SendEnabled send_enabled = 1 [(gogoproto.moretags) = "yaml:\"send_enabled,omitempty\""];
bool default_send_enabled = 2 [(gogoproto.moretags) = "yaml:\"default_send_enabled,omitempty\""];
repeated SendEnabled send_enabled = 1;
bool default_send_enabled = 2;
}

// SendEnabled maps coin denom to a send_enabled status (whether a denom is
Expand Down
2 changes: 1 addition & 1 deletion proto/cosmos/bank/v1beta1/genesis.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ message GenesisState {
[(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins", (gogoproto.nullable) = false];

// denom_metadata defines the metadata of the differents coins.
repeated Metadata denom_metadata = 4 [(gogoproto.moretags) = "yaml:\"denom_metadata\"", (gogoproto.nullable) = false];
repeated Metadata denom_metadata = 4 [(gogoproto.nullable) = false];
}

// Balance defines an account address and balance pair used in the bank module's
Expand Down
4 changes: 2 additions & 2 deletions proto/cosmos/bank/v1beta1/tx.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ message MsgSend {
option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;

string from_address = 1 [(gogoproto.moretags) = "yaml:\"from_address\""];
string to_address = 2 [(gogoproto.moretags) = "yaml:\"to_address\""];
string from_address = 1;
string to_address = 2;
repeated cosmos.base.v1beta1.Coin amount = 3
[(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"];
}
Expand Down
10 changes: 5 additions & 5 deletions proto/cosmos/base/abci/v1beta1/abci.proto
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ message Attribute {
// GasInfo defines tx execution gas context.
message GasInfo {
// GasWanted is the maximum units of work we allow this tx to perform.
uint64 gas_wanted = 1 [(gogoproto.moretags) = "yaml:\"gas_wanted\""];
uint64 gas_wanted = 1;

// GasUsed is the amount of gas actually consumed.
uint64 gas_used = 2 [(gogoproto.moretags) = "yaml:\"gas_used\""];
uint64 gas_used = 2;
}

// Result is the union of ResponseFormat and ResponseCheckTx.
Expand Down Expand Up @@ -123,13 +123,13 @@ message SearchTxsResult {
option (gogoproto.stringer) = true;

// Count of all txs
uint64 total_count = 1 [(gogoproto.moretags) = "yaml:\"total_count\"", (gogoproto.jsontag) = "total_count"];
uint64 total_count = 1 [(gogoproto.jsontag) = "total_count"];
// Count of txs in current page
uint64 count = 2;
// Index of current page, start from 1
uint64 page_number = 3 [(gogoproto.moretags) = "yaml:\"page_number\"", (gogoproto.jsontag) = "page_number"];
uint64 page_number = 3 [(gogoproto.jsontag) = "page_number"];
// Count of total pages
uint64 page_total = 4 [(gogoproto.moretags) = "yaml:\"page_total\"", (gogoproto.jsontag) = "page_total"];
uint64 page_total = 4 [(gogoproto.jsontag) = "page_total"];
// Max count txs per page
uint64 limit = 5;
// List of txs in current page
Expand Down
6 changes: 3 additions & 3 deletions proto/cosmos/capability/v1beta1/capability.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import "gogoproto/gogo.proto";
message Capability {
option (gogoproto.goproto_stringer) = false;

uint64 index = 1 [(gogoproto.moretags) = "yaml:\"index\""];
uint64 index = 1;
}

// Owner defines a single capability owner. An owner is defined by the name of
Expand All @@ -19,8 +19,8 @@ message Owner {
option (gogoproto.goproto_stringer) = false;
option (gogoproto.goproto_getters) = false;

string module = 1 [(gogoproto.moretags) = "yaml:\"module\""];
string name = 2 [(gogoproto.moretags) = "yaml:\"name\""];
string module = 1;
string name = 2;
}

// CapabilityOwners defines a set of owners of a single Capability. The set of
Expand Down
2 changes: 1 addition & 1 deletion proto/cosmos/capability/v1beta1/genesis.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ message GenesisOwners {
uint64 index = 1;

// index_owners are the owners at the given index.
CapabilityOwners index_owners = 2 [(gogoproto.nullable) = false, (gogoproto.moretags) = "yaml:\"index_owners\""];
CapabilityOwners index_owners = 2 [(gogoproto.nullable) = false];
}

// GenesisState defines the capability module's genesis state.
Expand Down
2 changes: 1 addition & 1 deletion proto/cosmos/crisis/v1beta1/genesis.proto
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ message GenesisState {
// constant_fee is the fee used to verify the invariant in the crisis
// module.
cosmos.base.v1beta1.Coin constant_fee = 3
[(gogoproto.nullable) = false, (gogoproto.moretags) = "yaml:\"constant_fee\""];
[(gogoproto.nullable) = false];
}
4 changes: 2 additions & 2 deletions proto/cosmos/crisis/v1beta1/tx.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ message MsgVerifyInvariant {
option (gogoproto.goproto_getters) = false;

string sender = 1;
string invariant_module_name = 2 [(gogoproto.moretags) = "yaml:\"invariant_module_name\""];
string invariant_route = 3 [(gogoproto.moretags) = "yaml:\"invariant_route\""];
string invariant_module_name = 2;
string invariant_route = 3;
}

// MsgVerifyInvariantResponse defines the Msg/VerifyInvariant response type.
Expand Down
4 changes: 2 additions & 2 deletions proto/cosmos/crypto/multisig/keys.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ option go_package = "github.com/cosmos/cosmos-sdk/crypto/keys/multisig";
message LegacyAminoPubKey {
option (gogoproto.goproto_getters) = false;

uint32 threshold = 1 [(gogoproto.moretags) = "yaml:\"threshold\""];
uint32 threshold = 1;
repeated google.protobuf.Any public_keys = 2
[(gogoproto.customname) = "PubKeys", (gogoproto.moretags) = "yaml:\"pubkeys\""];
[(gogoproto.customname) = "PubKeys"];
}
Loading