Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

The param 'isEIP2028' of function IntrinsicGas should be true if Istanbul version enabled #730

Closed
KamiD opened this issue Jan 20, 2021 · 0 comments · Fixed by #731
Closed

Comments

@KamiD
Copy link

KamiD commented Jan 20, 2021

System info: [Include Ethermint commit, operating system name, and other relevant details]

Steps to reproduce:
the param 'isEIP2028' of function IntrinsicGas which was called in TransitionDb Need reset false to true cause Istanbul version has already be enabled

func (st StateTransition) TransitionDb(ctx sdk.Context, config ChainConfig) (*ExecutionResult, error) {
	contractCreation := st.Recipient == nil
 
       //here need reset false to true cause Istanbul version has already be enabled
	cost, err := core.IntrinsicGas(st.Payload, contractCreation,true,false)
	if err != nil {
		return nil, sdkerrors.Wrap(err, "invalid intrinsic gas for transaction")
	}

	// This gas limit the the transaction gas limit with intrinsic gas subtracted
	gasLimit := st.GasLimit - ctx.GasMeter().GasConsumed()

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Additional info: [Include gist of relevant config, logs, etc.]

freddyli7 pushed a commit that referenced this issue Apr 14, 2021
This was referenced Apr 14, 2021
freddyli7 added a commit that referenced this issue Apr 15, 2021
* merge pr #730

* test fix

Co-authored-by: Freddy Li <freddyli@Freddys-MacBook-Pro-2.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant