Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

open eip2028 when the version of Istanbul was enabled #731

Merged
merged 15 commits into from
Jan 28, 2021
Merged

open eip2028 when the version of Istanbul was enabled #731

merged 15 commits into from
Jan 28, 2021

Conversation

KamiD
Copy link

@KamiD KamiD commented Jan 20, 2021

Closes: #730

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@KamiD KamiD requested review from fedekunze and noot as code owners January 20, 2021 08:19
fedekunze
fedekunze approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

x/evm/types/chain_config.go Outdated Show resolved Hide resolved
x/evm/types/chain_config.go Outdated Show resolved Hide resolved
KamiD and others added 2 commits January 21, 2021 10:34
@KamiD @fedekunze
Update x/evm/types/chain_config.go
1d7c886 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@KamiD @fedekunze
Update x/evm/types/chain_config.go
67292a2 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@KamiD
Copy link
Author

KamiD commented Jan 21, 2021 •
edited
Loading

LGTM, minor comment

Cool, all comments has been accepted

@zhongqiuwood zhongqiuwood mentioned this pull request Jan 22, 2021
Closed
@fedekunze
Copy link
Contributor

fedekunze commented Jan 25, 2021 •
edited
Loading

the RPC test needs to be fixed, then I can merge it

@KamiD
Copy link
Author

KamiD commented Jan 28, 2021

the RPC test needs to be fixed, then I can merge it

RPC test has been fixed

@fedekunze fedekunze merged commit c95ad04 into cosmos:development Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@noot noot Awaiting requested review from noot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The param 'isEIP2028' of function IntrinsicGas should be true if Istanbul version enabled
2 participants
@KamiD @fedekunze