DNM: IBC-Gaia Integration #130

mossid · 2019-09-17T15:25:09Z

This PR is the tracking PR for Gaia/IBC integration. To try it out, pull down this branch and build gaia using the instructions in cmd/gaiacli/README.md.

…terface

codecov-io · 2019-09-17T16:51:55Z

Codecov Report

Merging #130 into master will increase coverage by 0.81%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   65.65%   66.46%   +0.81%     
==========================================
  Files           5        5              
  Lines         492      498       +6     
==========================================
+ Hits          323      331       +8     
+ Misses        138      136       -2     
  Partials       31       31

jackzampolin · 2019-09-30T23:09:08Z

I'm in the process of turning this into a 2 chain tutorial. I'll be adding notes here:

CLI commands aren't piped through the correct output function and don't respect --output text or --indent
Lack of input validation on CLI
Lack of error returns for improperly formatted store returns

wlsaud619 · 2019-10-01T17:58:51Z

https://github.com/cosmos/gaia/tree/joon/ibc-gaia-interface/cmd/gaiacli

I tried to test ibc by referring to the above document.
However, gaiacli does not seem to have any ibc related commands.

gaiacli version

$ gaiacli --home ibc0/n0/gaiacli version --long

name: gaia
server_name: gaiad
client_name: gaiacli
version: 0.0.0-68-g5e81764
commit: 5e817641bb5256b80dab6928f45a65ba6b907786
build_tags: netgo,ledger
go: go version go1.13 linux/amd64

gaiacli query

$ gaiacli --home ibc0/n0/gaiacli q ibc client path
Querying subcommands

Usage:
  gaiacli query [command]

Aliases:
  query, q

Available Commands:
  account                  Query account balance

  tendermint-validator-set Get the full tendermint validator set at given height
  block                    Get verified data for a the block at given height
  txs                      Query for paginated transactions that match a set of tags
  tx                       Query for a transaction by hash in a committed block

  auth                     Querying commands for the auth module
  mint                     Querying commands for the minting module
  distribution             Querying commands for the distribution module
  slashing                 Querying commands for the slashing module
  supply                   Querying commands for the supply module
  staking                  Querying commands for the staking module
  gov                      Querying commands for the governance module

Flags:
  -h, --help   help for query

Global Flags:
      --chain-id string   Chain ID of tendermint node
  -e, --encoding string   Binary encoding (hex|b64|btc) (default "hex")
      --home string       directory for config and data (default "/data/node/.gaiacli")
  -o, --output string     Output format (text|json) (default "text")
      --trace             print out full stack trace on errors

Use "gaiacli query [command] --help" for more information about a command.

gaiacli tx

$ gaiacli --home ibc0/n0/gaiacli tx ibc
Transactions subcommands

Usage:
  gaiacli tx [command]

Available Commands:
  send         Create and sign a send tx

  sign         Sign transactions generated offline
  multisign    Generate multisig signatures for transactions generated offline

  broadcast    Broadcast transactions generated offline
  encode       Encode transactions generated offline
  decode       Decode an amino-encoded transaction string

  staking      Staking transaction subcommands
  slashing     Slashing transactions subcommands
  distribution Distribution transactions subcommands
  gov          Governance transactions subcommands
  crisis       Crisis transactions subcommands

Flags:
  -h, --help   help for tx

Global Flags:
      --chain-id string   Chain ID of tendermint node
  -e, --encoding string   Binary encoding (hex|b64|btc) (default "hex")
      --home string       directory for config and data (default "/data/node/.gaiacli")
  -o, --output string     Output format (text|json) (default "text")
      --trace             print out full stack trace on errors

Use "gaiacli tx [command] --help" for more information about a command.

alessio · 2019-10-01T19:24:17Z

Makefile

@@ -87,8 +87,8 @@ else
 endif

 install: go.sum check-ledger
-	go install -mod=readonly $(BUILD_FLAGS) ./cmd/gaiad
-	go install -mod=readonly $(BUILD_FLAGS) ./cmd/gaiacli
+	go install $(BUILD_FLAGS) ./cmd/gaiad


mmmm how comes? Did you have any issues with -mod=readonly? Is there anything I can help out with?

Sure! I was having issues with -mod=readonly!

Why is this the case @alessio?

jackzampolin · 2019-10-01T20:34:57Z

@wlsaud619 It looks like that isn't the right version of gaia.

wlsaud619 · 2019-10-02T00:50:37Z

@jackzampolin Sorry, my mistake. I didn't apply branch ;)

warner · 2019-10-03T15:21:39Z

cmd/gaiacli/README.md

+gaiacli --home ibc0/n0/gaiacli query ibc channel channel ibc-mock chan0 --trust-node
+```
+
+## Send Packet


Both send-packet commands are using ibc0, but all the other sections have matched pairs of ibc0/ibc1 commands. Is this intentional? I'm guessing it's just a typo.

How should the commands look? This part of the instructions are left over from the loopback demo

flush command is currently using ibc0 as its home but making transaction on ibc1, which is bit misleading

@mossid so how would you rewrite the example?

…fore 4th transaction in the handshake

cmd/gaiacli/README.md

… joon/ibc-gaia-interface

wlsaud619 · 2019-10-10T14:12:59Z

Packet send/received well.
However, it seems that the information is not updated at the part of querying channel information.

jackzampolin · 2019-10-10T18:21:39Z

@wlsaud619 It looks like the sequence is updating for me after the flush.

kphed · 2019-10-11T02:55:08Z

cmd/gaiacli/README.md

+gaiacli --home ibc0/n0/gaiacli q ibcmocksend sequence chan0
+
+# Returns the next expected sequence number, for use in scripting
+gaiacli --home ibc0/n0/gaiacli q ibcmocksend next chan0


On a fresh install:

Running gaiacli --home ibc0/n0/gaiacli q ibcmocksend sequence chan0 returns 0

Running gaiacli --home ibc0/n0/gaiacli q ibcmocksend next chan0 immediately afterward returns 2 (without having sent any packets)

I was able to reproduce the above after stopping the testnet gaiad processes, removing the entire ibc-testnets directory, and starting over. Will try on a new machine tomorrow (currently, on a Mac).

Wanted to add that manually inputting the correct sequence number (should be 1 instead of 2) to successfully send a packet the first time, then using the above to get subsequent "next sequence" numbers works.

https://github.com/cosmos/cosmos-sdk/blob/e69029151525422924e384cd9175778fa8533c51/x/ibc/mock/send/client/cli/query.go#L70

In L74 of the function add 1 to res, so if value is nil, res should be set to 0 instead of 1.

kphed · 2019-10-11T03:03:13Z

cmd/gaiacli/README.md

+  --node1 tcp://localhost:26657 \
+  --node2 tcp://localhost:26557 \
+  --chain-id2 ibc1 \
+  --from1 n0 --from2 n1 -y -o text


The -y option doesn't seem to exist for this build and running this command results in this error:
ERROR: unknown shorthand flag: 'y' in -y

Ran gaiacli --home ibc0/n0/gaiacli tx ibc channel flush ibcmocksend --help and didn't see the option/flag listed either (edit: oh lol it was to confirm the transaction - getting late here).

… joon/ibc-gaia-interface

stale · 2019-12-12T11:02:25Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mossid added 5 commits September 3, 2019 16:39

update mod

0f68573

fix mod

601ea4c

update mod

e6563ce

Merge branch 'master' of github.com:cosmos/gaia into joon/ibc-gaia-in…

d6b9f98

…terface

fix go mod problem completly

38e34ca

mossid force-pushed the joon/ibc-gaia-interface branch from bec3cdb to 38e34ca Compare September 17, 2019 16:45

mossid added 3 commits September 19, 2019 22:40

reflect sdk commit

609c4b8

add shell scripts, add readme

bbc7aed

add channel handshake

d3e21d2

jackzampolin and others added 4 commits September 30, 2019 16:53

Fix IBC docs

e583706

Update docs

6102c55

fix handshake

90abacc

add mocksend/mockrecv apps

114be93

jackzampolin marked this pull request as ready for review October 1, 2019 15:26

jackzampolin requested review from alessio, alexanderbez, jackzampolin and rigelrozanski as code owners October 1, 2019 15:26

remove -mod=readonly

18a6b52

alessio reviewed Oct 1, 2019

View reviewed changes

warner reviewed Oct 3, 2019

View reviewed changes

fedekunze added 2 commits October 3, 2019 20:59

use cosmos/cosmos-sdk#5124 as SDK-IBC interface

edffb9c

merge master

b96de61

fedekunze added the WIP label Oct 3, 2019

fedekunze changed the title ~~IBC-Gaia Integration~~ DNM: IBC-Gaia Integration Oct 3, 2019

jackzampolin added 3 commits October 4, 2019 10:41

Verifier creation working properly, debugging panic on store query be…

0d7afc9

…fore 4th transaction in the handshake

Just need to be able to flush packet from channel

4848be2

Clarify which branch in instructions

3ecb299

kphed reviewed Oct 8, 2019

View reviewed changes

cmd/gaiacli/README.md Outdated Show resolved Hide resolved

fix readme

171ae0f

fedekunze reviewed Oct 9, 2019

View reviewed changes

cmd/gaiacli/README.md Outdated Show resolved Hide resolved

fedekunze and others added 3 commits October 9, 2019 11:22

Update cmd/gaiacli/README.md

513e0cd

update go mod

409d5ff

Merge branch 'joon/ibc-gaia-interface' of github.com:cosmos/gaia into…

ced210a

… joon/ibc-gaia-interface

Update IBC CLI UX

176c722

kphed reviewed Oct 11, 2019

View reviewed changes

mossid and others added 6 commits October 12, 2019 22:36

add ibcante, update readme

2c4c56b

Merge branch 'joon/ibc-gaia-interface' of github.com:cosmos/gaia into…

7eec0a3

… joon/ibc-gaia-interface

fix go.sum

c1c09be

Merge PR #157: Fix typos

121357d

Demo in working state

6df9ff7

Fix go.mod

9248903

fedekunze mentioned this pull request Oct 29, 2019

IBC v1.0.0 #172

Closed

5 tasks

stale bot added the stale label Dec 12, 2019

stale bot closed this Dec 16, 2019

alexanderbez deleted the joon/ibc-gaia-interface branch April 23, 2020 16:57

snyk-bot mentioned this pull request Dec 24, 2020

[Snyk] Security upgrade vuepress-theme-cosmos from 1.0.133 to 1.0.174 ArmDaniel/band-consumer#2

Open

snyk-bot mentioned this pull request Sep 6, 2021

[Snyk] Security upgrade vuepress-theme-cosmos from 1.0.133 to 1.0.174 ArmDaniel/band-consumer#4

Open

snyk-bot mentioned this pull request Jan 10, 2022

[Snyk] Security upgrade vuepress-theme-cosmos from 1.0.133 to 1.0.174 ArmDaniel/band-consumer#5

Open

ArmDaniel mentioned this pull request Nov 5, 2022

[Snyk] Security upgrade vuepress-theme-cosmos from 1.0.133 to 1.0.174 ArmDaniel/band-consumer#8

Open

ArmDaniel mentioned this pull request Dec 26, 2022

[Snyk] Security upgrade vuepress-theme-cosmos from 1.0.133 to 1.0.174 ArmDaniel/band-consumer#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNM: IBC-Gaia Integration #130

DNM: IBC-Gaia Integration #130

mossid commented Sep 17, 2019 •

edited by jackzampolin

Loading

codecov-io commented Sep 17, 2019 •

edited

Loading

jackzampolin commented Sep 30, 2019 •

edited

Loading

wlsaud619 commented Oct 1, 2019

alessio Oct 1, 2019

jackzampolin Oct 1, 2019

fedekunze Oct 3, 2019

jackzampolin commented Oct 1, 2019

wlsaud619 commented Oct 2, 2019

warner Oct 3, 2019

jackzampolin Oct 3, 2019 •

edited

Loading

mossid Oct 4, 2019

jackzampolin Oct 4, 2019

wlsaud619 commented Oct 10, 2019

jackzampolin commented Oct 10, 2019

kphed Oct 11, 2019

kphed Oct 11, 2019

wlsaud619 Oct 11, 2019

kphed Oct 11, 2019 •

edited

Loading

stale bot commented Dec 12, 2019

DNM: IBC-Gaia Integration #130

DNM: IBC-Gaia Integration #130

Conversation

mossid commented Sep 17, 2019 • edited by jackzampolin Loading

codecov-io commented Sep 17, 2019 • edited Loading

Codecov Report

jackzampolin commented Sep 30, 2019 • edited Loading

wlsaud619 commented Oct 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackzampolin commented Oct 1, 2019

wlsaud619 commented Oct 2, 2019

Choose a reason for hiding this comment

jackzampolin Oct 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wlsaud619 commented Oct 10, 2019

jackzampolin commented Oct 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kphed Oct 11, 2019 • edited Loading

Choose a reason for hiding this comment

stale bot commented Dec 12, 2019

mossid commented Sep 17, 2019 •

edited by jackzampolin

Loading

codecov-io commented Sep 17, 2019 •

edited

Loading

jackzampolin commented Sep 30, 2019 •

edited

Loading

jackzampolin Oct 3, 2019 •

edited

Loading

kphed Oct 11, 2019 •

edited

Loading