Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC v1.0.0 #172

Closed
wants to merge 16 commits into from
Closed

IBC v1.0.0 #172

wants to merge 16 commits into from

Conversation

fedekunze
Copy link
Collaborator

replaces #130

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@fedekunze fedekunze added the WIP label Oct 29, 2019
ibc-demo.md Outdated Show resolved Hide resolved
ibc-demo.sh Outdated Show resolved Hide resolved
Copy link

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the demo, good stuff! A few minor comments.

ibc-demo.md Outdated Show resolved Hide resolved
ibc-demo.md Outdated Show resolved Hide resolved
ibc-demo.md Outdated Show resolved Hide resolved
ibc-demo.md Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Nov 20, 2019
5 tasks
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #172 into master will decrease coverage by 1.09%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #172     +/-   ##
=========================================
- Coverage   66.86%   65.76%   -1.1%     
=========================================
  Files           5        5             
  Lines         507      517     +10     
=========================================
+ Hits          339      340      +1     
- Misses        137      146      +9     
  Partials       31       31
Impacted Files Coverage Δ
app/utils.go 0% <0%> (ø) ⬆️
app/app.go 89.05% <100%> (+0.08%) ⬆️

@fedekunze fedekunze added the pinned Pinned issues that won't be closed by stalebot label Dec 16, 2019
@fedekunze
Copy link
Collaborator Author

replaced by #288

@fedekunze fedekunze closed this Mar 16, 2020
@fedekunze fedekunze deleted the fedekunze/ibc branch March 16, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Pinned issues that won't be closed by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants