Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #151

Closed
wants to merge 1 commit into from
Closed

Update README.md #151

wants to merge 1 commit into from

Conversation

everstake
Copy link

minor escape symbols and markup fix

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

Update README.md
dda1bf8 
minor escape symbols and markup fix
alexanderbez
alexanderbez suggested changes Oct 8, 2019
View reviewed changes
cmd/gaiacli/README.md Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

@everstake mind rebasing/fixing conflicts please?

@fedekunze fedekunze added scope: docs Improvements or additions to documentation R4R labels Oct 25, 2019
@fedekunze
Copy link
Collaborator

closing as outdated. Check out the new PR for the alpha implementation #172

@fedekunze fedekunze closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
scope: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everstake @alexanderbez @fedekunze