fix(export-genesis): fix export genesis command for missing values

[Pantani]

part of #1384

Description

Some values are missing in the genesis JSON when we are exporting it. So we can't validate the genesis after export.

Most of the values should be upgraded based on default genesis parameters, but maybe we should also add the liquidityPoolRecords parameter from the liquidity module

[codecov]

Codecov Report

Merging #1800 (cbd1656) into main (5e569a1) will not change coverage.
The diff coverage is n/a.

❗ Current head cbd1656 differs from pull request most recent head 40b2b8e. Consider uploading reports for the commit 40b2b8e to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1800   +/-   ##
=======================================
  Coverage   43.13%   43.13%           
=======================================
  Files          15       15           
  Lines        1340     1340           
=======================================
  Hits          578      578           
  Misses        742      742           
  Partials       20       20           

[mmulji-ic]

@Pantani @glnro this is not tested via the current tests that we have right? If not, is it practical to add something?

[yaruwangway]

Hi, when i query the node in public net, denom-metadata is already there.

{"metadatas":[{"description":"The native staking token of the Cosmos Hub.","denom_units":[{"denom":"uatom","exponent":0,"aliases":["microatom"]},{"denom":"matom","exponent":3,"aliases":["milliatom"]},{"denom":"atom","exponent":6,"aliases":[]}],"base":"uatom","display":"atom","name":"","symbol":""}],"pagination":{"next_key":null,"total":"1"}}

also, the denom is uatom.

[glnro]

I think this is different than the actual denom

[glnro]

https://github.com/cosmos/cosmos-sdk/blob/55054282d2df794d9a5fe2599ea25473379ebc3d/x/bank/types/metadata_test.go

[Pantani]

We can confirm the parameter through mainnet API (http://<rpc...>:1317/cosmos/bank/v1beta1/denoms_metadata) . The parameter the SDK use as a key index is base, and we are using uatom:

$ curl http://<RPC_ADDRESS>:1317/cosmos/bank/v1beta1/denoms_metadata
{
  "metadatas": [
    {
      "description": "The native staking token of the Cosmos Hub.",
      "denom_units": [
        {
          "denom": "uatom",
          "exponent": 0,
          "aliases": [
            "microatom"
          ]
        },
        {
          "denom": "matom",
          "exponent": 3,
          "aliases": [
            "milliatom"
          ]
        },
        {
          "denom": "atom",
          "exponent": 6,
          "aliases": [
          ]
        }
      ],
      "base": "uatom",
      "display": "atom",
      "name": "",
      "symbol": ""
    }
  ],
  "pagination": {
    "next_key": null,
    "total": "1"
  }
}

[Pantani]

https://github.com/cosmos/cosmos-sdk/blob/a975f67b245c214fa11408c4eb361147b4679d62/x/bank/keeper/keeper.go#L309-L309

[okwme]

It's strange that Name and Symbol were left empty when the rest was populated.
We should ensure whatever it is it matches https://github.com/cosmos/chain-registry/blob/master/cosmoshub/assetlist.json

They have us listed as

        "name": "Cosmos",
        "symbol": "ATOM",

Either we update the chain registry or update here so that name = Cosmos instead of Cosmos Hub Atom.
I prefer the former since there may be wallets, exchanges or explorers using the chain-registry already.

[okwme]

change "Name" to "Cosmos" or change registry

[okwme]

tests are timing out but I checked them locally and they pass e2e : )