Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export-genesis): fix export genesis command for missing values #1800

Merged
merged 8 commits into from
Oct 24, 2022
Merged

fix(export-genesis): fix export genesis command for missing values #1800

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89d63d6
add bank denom metadata
Pantani Oct 11, 2022
afece90
check if the atom denom exists
Pantani Oct 11, 2022
d4730a6
Merge branch 'main' into fix/export-genesis
Pantani Oct 11, 2022
3f8728a
Merge branch 'main' into fix/export-genesis
glnro Oct 13, 2022
e64843a
update atom name
Pantani Oct 13, 2022
b07ca86
Merge branch 'main' into fix/export-genesis
Pantani Oct 13, 2022
cbd1656
update atom metadata name to `Cosmos Hub Atom`
Pantani Oct 19, 2022
40b2b8e
Merge branch 'main' into fix/export-genesis
okwme Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/upgrades/v8/upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package v8

import (
"errors"

sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/module"
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
Expand All @@ -16,6 +18,15 @@ func CreateUpgradeHandler(
return func(ctx sdk.Context, plan upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) {
ctx.Logger().Info("start to run module migrations...")

// Add atom name and symbol into the bank keeper
atomMetaData, found := keepers.BankKeeper.GetDenomMetaData(ctx, "uatom")
if !found {
return nil, errors.New("atom denom not found")
}
atomMetaData.Name = "Cosmos Hub Atom"
okwme marked this conversation as resolved.
Show resolved Hide resolved
atomMetaData.Symbol = "ATOM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, when i query the node in public net, denom-metadata is already there.

{"metadatas":[{"description":"The native staking token of the Cosmos Hub.","denom_units":[{"denom":"uatom","exponent":0,"aliases":["microatom"]},{"denom":"matom","exponent":3,"aliases":["milliatom"]},{"denom":"atom","exponent":6,"aliases":[]}],"base":"uatom","display":"atom","name":"","symbol":""}],"pagination":{"next_key":null,"total":"1"}}

also, the denom is uatom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is different than the actual denom

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cosmos/cosmos-sdk/blob/55054282d2df794d9a5fe2599ea25473379ebc3d/x/bank/types/metadata_test.go

Copy link
Contributor Author

@Pantani Pantani Oct 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can confirm the parameter through mainnet API (http://<rpc...>:1317/cosmos/bank/v1beta1/denoms_metadata) . The parameter the SDK use as a key index is base, and we are using uatom:

$ curl http://<RPC_ADDRESS>:1317/cosmos/bank/v1beta1/denoms_metadata
{
  "metadatas": [
    {
      "description": "The native staking token of the Cosmos Hub.",
      "denom_units": [
        {
          "denom": "uatom",
          "exponent": 0,
          "aliases": [
            "microatom"
          ]
        },
        {
          "denom": "matom",
          "exponent": 3,
          "aliases": [
            "milliatom"
          ]
        },
        {
          "denom": "atom",
          "exponent": 6,
          "aliases": [
          ]
        }
      ],
      "base": "uatom",
      "display": "atom",
      "name": "",
      "symbol": ""
    }
  ],
  "pagination": {
    "next_key": null,
    "total": "1"
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cosmos/cosmos-sdk/blob/a975f67b245c214fa11408c4eb361147b4679d62/x/bank/keeper/keeper.go#L309-L309

keepers.BankKeeper.SetDenomMetaData(ctx, atomMetaData)

return mm.RunMigrations(ctx, configurator, vm)
}
}