-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update v8.0.1 changelog #2221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
February 17, 2023 19:51
shaspitz
approved these changes
Feb 17, 2023
jtremback
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
(cherry picked from commit e99ce3e)
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
(cherry picked from commit e99ce3e)
This was referenced Feb 17, 2023
glnro
added a commit
that referenced
this pull request
Feb 17, 2023
glnro
added a commit
that referenced
this pull request
Feb 17, 2023
yaruwangway
added a commit
that referenced
this pull request
Mar 1, 2023
* Update changelog for v9 rc7 (#2219) * Update v8.0.1 changelog (#2221) * Consistently generate build tags on newer Make (#2018) With Make 4.3+, the empty whitespace does not seem to work as originally intended. This causes build tags to be "netgo ledger," on Ubuntu 22.04 and other systems that include the newer Make version. The build tags were intended as "netgo,ledger" which can be observed on Make 4.2 (shipped with Ubuntu 20.04). This change swaps out the `+=` use in favor of an explicit `:=`. Ref: https://www.gnu.org/software/make/manual/html_node/Appending.html Closes #2017. Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> * - Update doc to follow Go conventions - Improve code readability * update params * docs: update docs * fix: lint --------- Co-authored-by: lg <8335464+glnro@users.noreply.github.com> Co-authored-by: Valters Jansons <sigv@users.noreply.github.com> Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.