merge two global fee refactor branch #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Make 4.3+, the empty whitespace does not seem to work as originally intended. This causes build tags to be "netgo ledger," on Ubuntu 22.04 and other systems that include the newer Make version. The build tags were intended as "netgo,ledger" which can be observed on Make 4.2 (shipped with Ubuntu 20.04). This change swaps out the `+=` use in favor of an explicit `:=`. Ref: https://www.gnu.org/software/make/manual/html_node/Appending.html Closes #2017. Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
- Improve code readability
yaruwangway
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
|
|
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## yaru/globalfee-refactor #2242 +/- ##
===========================================================
+ Coverage 84.77% 85.67% +0.90%
===========================================================
Files 21 21
Lines 1484 1459 -25
===========================================================
- Hits 1258 1250 -8
+ Misses 181 167 -14
+ Partials 45 42 -3
|
|
|
Closed
yaruwangway
commented
Feb 23, 2023
| func (coins DecCoins) Validate() error { | ||
| switch len(coins) { |
There was a problem hiding this comment.
this will be refactored later if globalfee does not allow zero coins
sainoe
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.