fix!: add GovVoteDecorator #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
MSalopek
reviewed
Jan 31, 2024
Co-authored-by: MSalopek <matija.salopek994@gmail.com>
|
LGTM! |
sainoe
approved these changes
Feb 1, 2024
MSalopek
added a commit
that referenced
this pull request
Feb 5, 2024
#2912 introuced the VoteSpamDecorator. The implementation was not complete and only v1beta1 gov types were handled. The CLI supports v1 gov types so the validation was not sufficient. This commit expands the antehandler validation to allow correct processing of both v1 and v1beta1 messages.
18 tasks
MSalopek
added a commit
that referenced
this pull request
Feb 6, 2024
* fix!: check v1 and v1beta1 MsgVote in VoteSpamDecorator #2912 introuced the VoteSpamDecorator. The implementation was not complete and only v1beta1 gov types were handled. The CLI supports v1 gov types so the validation was not sufficient. This commit expands the antehandler validation to allow correct processing of both v1 and v1beta1 messages. * appease linter * test: stop app from failing non-determinism test on gov vote * ante: handle edgecase with 0 minStakedTokens * appease linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2910
Add ante handler that allows
MsgVotefrom accounts with at least 1 atom staked.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change