Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: check v1 and v1beta1 MsgVote in VoteSpamDecorator #2923

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Feb 5, 2024

#2912 introuced the VoteSpamDecorator.

The implementation was not complete and only v1beta1 gov types were handled.

The CLI supports v1 gov types so the validation was not sufficient.

This commit expands the antehandler validation to allow correct processing of both v1 and v1beta1 messages.

Tests were expanded to cover both possible scenarios.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

#2912 introuced the VoteSpamDecorator.

The implementation was not complete and only v1beta1 gov types were handled.

The CLI supports v1 gov types so the validation was not sufficient.

This commit expands the antehandler validation to allow correct processing of both v1 and v1beta1 messages.
@MSalopek
Copy link
Contributor Author

MSalopek commented Feb 6, 2024

Leaving some notes:

These commits fix deactivate the VoteSpamDecorator in simulation tests:

I was unable to find a different way of doing it since there is no way to prevent the antehandler from running in non-determinism tests.

Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

administrative approval

@MSalopek MSalopek merged commit 52a0f44 into main Feb 6, 2024
17 checks passed
@MSalopek MSalopek deleted the masa/fix-2912-gov-vote-antehandler branch February 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants