Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if fee module is locked before distributing fees on acknowledgement and timeout #1320

Closed
crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1340
Closed

Return error if fee module is locked before distributing fees on acknowledgement and timeout #1320

crodriguezvega opened this issue May 1, 2022 · 1 comment · Fixed by #1340
Labels
29-fee
Milestone
Fee middleware beta

Comments

@crodriguezvega
Copy link
Contributor

Return an error in case the fee modules is locked and don’t delete fees in escrow in DistributePacketFeesOnAcknowledgement and DistributePacketFeesOnTimeout.
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone May 1, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 1, 2022
@colin-axner
Copy link
Contributor

colin-axner commented May 3, 2022 •
edited
Loading

Move DeletePacketFees call into the Distribution functions. The packetID will need to be added as an argument to the distribution function. Adjust the tests as well, check that the packet fees are deleted

@vuong177 vuong177 mentioned this issue May 5, 2022
Merged
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go May 5, 2022
@mergify mergify bot closed this as completed in #1340 May 16, 2022
mergify bot pushed a commit that referenced this issue May 16, 2022
@vuong177
Return error if fee module is locked before distributing fees on ackn…
b7b4400 
…owledgement and timeout (#1340)

## Description
 - Return error if fee module is locked
 - Move `DeleteFeesInEscrow` into `DistributePacketFees` func


closes: #1320
---
Repository owner moved this from In review to Done in ibc-go May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
2 participants
@crodriguezvega @colin-axner