Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateClient Audit Findings #176

Closed
1 of 8 tasks
colin-axner opened this issue May 17, 2021 · 0 comments · Fixed by #181
Closed
1 of 8 tasks

UpdateClient Audit Findings #176

colin-axner opened this issue May 17, 2021 · 0 comments · Fixed by #181
Assignees
@colin-axner
Milestone
1.0.0

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 17, 2021 •
edited by AdityaSripal
Loading

Summary

While auditing the UpdateClient proposal we noticed several areas of improvement, primarily with regards to efficiency

  • 07-tendermint only needs to copy over the latest consensus state of the substitute client (and remove initial height)
  • Ensure substitute is active and subject is inactive in 02-client proposal handler
  • set the consensus state key in update proposal (iteration and process height missing) (fixed by Block Delay Parameter #171)
  • remove Validate() and IsExpired() checks in update proposal
  • replace chain-id with substitute client value.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue May 17, 2021
Closed
30 tasks
@colin-axner colin-axner self-assigned this May 17, 2021
@colin-axner colin-axner added this to the 1.0.0 milestone May 17, 2021
@colin-axner colin-axner mentioned this issue May 19, 2021
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@dependabot
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 (cosmos#176)
59316c1 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.41.0...v1.42.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

simplify UpdateClient proposal cosmos/ibc-go
1 participant
@colin-axner