Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify UpdateClient proposal #181

Merged
merged 14 commits into from
May 27, 2021
Merged

simplify UpdateClient proposal #181

merged 14 commits into from
May 27, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented May 19, 2021

Description

closes: #176


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner marked this pull request as ready for review May 20, 2021 11:05
@colin-axner colin-axner requested a review from cwgoes May 20, 2021 11:05
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #181 (6f10f18) into main (4570955) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   80.04%   80.08%   +0.04%     
==========================================
  Files         109      109              
  Lines        6481     6474       -7     
==========================================
- Hits         5188     5185       -3     
+ Misses        936      932       -4     
  Partials      357      357              
Impacted Files Coverage Δ
modules/core/02-client/types/proposal.go 83.92% <ø> (-0.82%) ⬇️
...ht-clients/06-solomachine/types/proposal_handle.go 100.00% <ø> (ø)
...s/light-clients/09-localhost/types/client_state.go 93.91% <ø> (ø)
...ght-clients/07-tendermint/types/proposal_handle.go 85.00% <64.70%> (+4.23%) ⬆️
modules/core/02-client/keeper/proposal.go 92.15% <100.00%> (+1.04%) ⬆️
modules/light-clients/07-tendermint/types/store.go 87.82% <100.00%> (+0.21%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2021

This pull request introduces 1 alert when merging 05d7e67 into f412334 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

add additional helper function to set consensus metadata set by substitute
@colin-axner colin-axner mentioned this pull request May 24, 2021
30 tasks
@AdityaSripal AdityaSripal enabled auto-merge (squash) May 26, 2021 19:56
@AdityaSripal AdityaSripal merged commit c3f4820 into main May 27, 2021
@AdityaSripal AdityaSripal deleted the colin/176-update-client branch May 27, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateClient Audit Findings
3 participants